ElasticsearchBaseTest::setUp() - Code Metrics - Inspection of "WIP: Retesting failed tests after nesting fix" - gordonbanderson/silverstripe-elastica - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev2 ( 774f9d...0919fb )

by Gordon

created 2015-12-31 07:28 UTC

ElasticsearchBaseTest::setUp() D

↳ Parent: ElasticsearchBaseTest

Complexity

Conditions	8
Paths	460

Size

Total Lines	84
Code Lines	47

Duplication

Lines	6
Ratio	7.14 %

Code Coverage

Tests	39
CRAP Score	8.8338

Metric	Value
dl	6
loc	84
ccs	39
cts	51
cp	0.7647
rs	4.5161
cc	8
eloc	47
nc	460
nop	0
crap	8.8338

How to fix Long Method

<?php
use SilverStripe\Elastica\ElasticaUtil;
use SilverStripe\Elastica\ReindexTask;
use SilverStripe\Elastica\ElasticaService;

class ElasticsearchBaseTest extends SapphireTest {

	public static $ignoreFixtureFileFor = array();

	protected $extraDataObjects = array(
		'SearchableTestPage','FlickrPhotoTO','FlickrAuthorTO','FlickrSetTO','FlickrTagTO',
		'SearchableTestFatherPage','SearchableTestGrandFatherPage','AutoCompleteOption'
	);


	public function setUpOnce() {
		ElasticaUtil::setPrinterOutput(false);

		// add Searchable extension where appropriate
		FlickrSetTO::add_extension('SilverStripe\Elastica\Searchable');
		FlickrPhotoTO::add_extension('SilverStripe\Elastica\Searchable');
		FlickrTagTO::add_extension('SilverStripe\Elastica\Searchable');
		FlickrAuthorTO::add_extension('SilverStripe\Elastica\Searchable');
		SearchableTestPage::add_extension('SilverStripe\Elastica\Searchable');


		$config = Config::inst();
		$config->remove('Injector', 'SilverStripe\Elastica\ElasticaService');
		$constructor = array('constructor' => array('%$Elastica\Client', 'elastica_ss_module_test'));
		$config->update('Injector', 'SilverStripe\Elastica\ElasticaService', $constructor);
		parent::setUpOnce();
	}


	public function setUp() {
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
		error_log('++++ EL BASE SET UP T1');
		// no need to index here as it's done when fixtures are loaded during setup method
		$cache = SS_Cache::factory('elasticsearch');
		$cache->clean(Zend_Cache::CLEANING_MODE_ALL);
		SS_Cache::set_cache_lifetime('elasticsearch', 3600, 1000);
		error_log('++++ EL BASE SET UP T2');

		// this needs to be called in order to create the list of searchable
		// classes and fields that are available.  Simulates part of a build
		$classes = array('SearchableTestPage','SiteTree','Page','FlickrPhotoTO','FlickrSetTO',
			'FlickrTagTO', 'FlickrAuthorTO');
		$this->requireDefaultRecordsFrom = $classes;

		error_log('++++ EL BASE SET UP T3');

		// clear the index
		$this->service = Injector::inst()->create('SilverStripe\Elastica\ElasticaService');
		$this->service->setTestMode(true);

		error_log('++++ EL BASE SET UP T4');

		$elasticException = false;

		try {
			// A previous test may have deleted the index and then failed, so check for this
			if (!$this->service->getIndex()->exists()) {
				error_log('++++ EL BASE SET UP T4a');

				$this->service->getIndex()->create();
			}
			error_log('++++ EL BASE SET UP T4b');
			$this->service->reset();
			error_log('++++ EL BASE SET UP T4c');
			// FIXME - use request getVar instead?
			$_GET['progress'] = 20;
			// load fixtures

			$orig_fixture_file = static::$fixture_file;
			error_log('++++ EL BASE SET UP T5');

			foreach (static::$ignoreFixtureFileFor as $testPattern) {

				$pattern = '/'.$testPattern.'/';
				if (preg_match($pattern, $this->getName())) {
					static::$fixture_file = null;
				}
			}

			error_log('++++ EL BASE SET UP T6');
		} catch (Exception $e) {
			error_log("**** EXCEPTION T1 ".$e->getMessage());
			$elasticException = true;
		}
			error_log('++++ EL BASE SET UP T7');


		// this needs to run otherwise nested injector errors show up
		parent::setUp();

		if ($elasticException) {
			$this->fail('T1 An error has occurred trying to contact Elasticsearch server');

		}

		try {
			static::$fixture_file = $orig_fixture_file;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

			$this->publishSiteTree();
			$this->service->reset();

			// index loaded fixtures
			$task = new ReindexTask($this->service);
			// null request is fine as no parameters used

			$task->run(null);
		} catch (Exception $e) {
			error_log("**** EXCEPTION T2 ".$e->getMessage());
			$elasticException = true;
		}

		if ($elasticException) {
			$this->fail('T2 An error has occurred trying to contact Elasticsearch server');

		}

	}


	protected function devBuild() {
		$task = new \BuildTask();
		// null request is fine as no parameters used
		$task->run(null);
	}


	private function publishSiteTree() {
		foreach (SiteTree::get()->getIterator() as $page) {
			// temporarily disable Elasticsearch indexing, it will be done in a batch
			$page->IndexingOff = true;
			$page->publish('Stage','Live');
		}
	}


	public function generateAssertionsFromArray($toAssert) {

		echo '$expected = array('."\n";
		foreach ($toAssert as $key => $value) {
			$escValue = str_replace("'", '\\\'', $value);
			echo "'$key' => '$escValue',\n";
		}
		echo ");\n";
		echo '$this->assertEquals($expected, $somevar);'."\n";
	}


	public function generateAssertionsFromArray1D($toAssert) {

		echo '$expected = array('."\n";
		foreach ($toAssert as $key => $value) {
			$escValue = str_replace("'", '\\\'', $value);
			echo "'$escValue',";
		}
		echo ");\n";
		echo '$this->assertEquals($expected, $somevar);'."\n";
	}


	public function generateAssertionsFromArrayRecurse($toAssert) {
		echo '$expected = ';
			$this->recurseArrayAssertion($toAssert,1, 'FIXME');
		echo '$this->assertEquals($expected, $somevar);'."\n";
	}


	private function recurseArrayAssertion($toAssert, $depth, $parentKey) {
		$prefix = str_repeat("\t",$depth);
		echo "\t{$prefix}'$parentKey' => array(\n";
		$ctr = 0;
		$len = sizeof(array_keys($toAssert));
		foreach ($toAssert as $key => $value) {
			if (is_array($value)) {
				$this->recurseArrayAssertion($value, $depth+1, $key);
			} else {
				$escValue = str_replace("'", '\\\'', $value);
				$comma = ',';
				if ($ctr == $len-1) {
					$comma = '';
				}
				echo "\t\t$prefix'$key' => '$escValue'$comma\n";
			}

			$ctr++;

		}
		echo "\t$prefix),\n";

	}


	/*
	Helper methods for testing CMS fields
	 */
	public function checkTabExists($fields, $tabName) {
		$tab = $fields->findOrMakeTab("Root.{$tabName}");
		$actualTabName = $tab->getName();
		$splits = explode('.', $tabName);
		$size = sizeof($splits);
		$nameToCheck = end($splits);
		$this->assertEquals($actualTabName, $nameToCheck);
		if ($size == 1) {
			$this->assertEquals("Root_${tabName}", $tab->id());
		} else {
			$expected = "Root_{$splits[0]}_set_{$splits[1]}";
			$this->assertEquals($expected, $tab->id());
		}

		return $tab;
	}


	public function checkFieldExists($tab,$fieldName) {
		$fields = $tab->Fields();
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		$field = $tab->fieldByName($fieldName);
		$this->assertTrue($field != null);
		return $field;
	}


	/**
	 * From https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/
	 * Call protected/private method of a class.
	 *
	 * @param object &$object    Instantiated object that we will run method on.
	 * @param string $methodName Method name to call
	 * @param array  $parameters Array of parameters to pass into method.
	 *
	 * @return mixed Method return.
	 */
	public function invokeMethod(&$object, $methodName, array $parameters = array())
	{
	    $reflection = new \ReflectionClass(get_class($object));
	    $method = $reflection->getMethod($methodName);
	    $method->setAccessible(true);

	    return $method->invokeArgs($object, $parameters);
	}


	public function checkNumberOfIndexedDocuments($expectedAmount) {
		$index = $this->service->getIndex();
		$status = $index->getStatus()->getData();

		$numberDocsInIndex = -1; // flag value for not yet indexed
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
		error_log('CHECKING NUMBER OF INDEXED DOCUMENTS, SHOULD BE ' . $expectedAmount);
		error_log(print_r($status,1));

		if (isset($status['indices']['elastica_ss_module_test_en_us']['docs'])) {
			$numberDocsInIndex = $status['indices']['elastica_ss_module_test_en_us']['docs']['num_docs'];
			error_log('DOCUMENTS FOUND:'.$numberDocsInIndex);
		} else {
			$numberDocsInIndex = 0;
		}

		$this->assertEquals($expectedAmount,$numberDocsInIndex);
	}

	/*
	Get the number of documents in an index.  It is assumed the index exists, if not the test will fail
	 */
	public function getNumberOfIndexedDocuments() {
		$index = $this->service->getIndex();
		$status = $index->getStatus()->getData();

		$numberDocsInIndex = -1; // flag value for not yet indexed
		if (isset($status['indices']['elastica_ss_module_test_en_us']['docs'])) {
			$numberDocsInIndex = $status['indices']['elastica_ss_module_test_en_us']['docs']['num_docs'];
		}

		$this->assertGreaterThan(-1, $numberDocsInIndex);
		return $numberDocsInIndex;
	}
}


1			<?php
2			use SilverStripe\Elastica\ElasticaUtil;
3			use SilverStripe\Elastica\ReindexTask;
4			use SilverStripe\Elastica\ElasticaService;
5
6			class ElasticsearchBaseTest extends SapphireTest {
7
8			public static $ignoreFixtureFileFor = array();
9
10			protected $extraDataObjects = array(
11			'SearchableTestPage','FlickrPhotoTO','FlickrAuthorTO','FlickrSetTO','FlickrTagTO',
12			'SearchableTestFatherPage','SearchableTestGrandFatherPage','AutoCompleteOption'
13			);
14
15
16			public function setUpOnce() {
17			ElasticaUtil::setPrinterOutput(false);
18
19			// add Searchable extension where appropriate
20			FlickrSetTO::add_extension('SilverStripe\Elastica\Searchable');
21			FlickrPhotoTO::add_extension('SilverStripe\Elastica\Searchable');
22			FlickrTagTO::add_extension('SilverStripe\Elastica\Searchable');
23			FlickrAuthorTO::add_extension('SilverStripe\Elastica\Searchable');
24			SearchableTestPage::add_extension('SilverStripe\Elastica\Searchable');
25
26
27			$config = Config::inst();
28			$config->remove('Injector', 'SilverStripe\Elastica\ElasticaService');
29			$constructor = array('constructor' => array('%$Elastica\Client', 'elastica_ss_module_test'));
30			$config->update('Injector', 'SilverStripe\Elastica\ElasticaService', $constructor);
31			parent::setUpOnce();
32			}
33
34
35	4		public function setUp() {
			0 ignored issues – show Coding Style introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report `setUp` uses the super-global variable `$_GET` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
36	4		error_log('++++ EL BASE SET UP T1');
37			// no need to index here as it's done when fixtures are loaded during setup method
38	4		$cache = SS_Cache::factory('elasticsearch');
39	4		$cache->clean(Zend_Cache::CLEANING_MODE_ALL);
40	4		SS_Cache::set_cache_lifetime('elasticsearch', 3600, 1000);
41	4		error_log('++++ EL BASE SET UP T2');
42
43			// this needs to be called in order to create the list of searchable
44			// classes and fields that are available. Simulates part of a build
45	4		$classes = array('SearchableTestPage','SiteTree','Page','FlickrPhotoTO','FlickrSetTO',
46	4		'FlickrTagTO', 'FlickrAuthorTO');
47	4		$this->requireDefaultRecordsFrom = $classes;
48
49	4		error_log('++++ EL BASE SET UP T3');
50
51			// clear the index
52	4		$this->service = Injector::inst()->create('SilverStripe\Elastica\ElasticaService');
53	4		$this->service->setTestMode(true);
54
55	4		error_log('++++ EL BASE SET UP T4');
56
57	4		$elasticException = false;
58
59			try {
60			// A previous test may have deleted the index and then failed, so check for this
61	4		if (!$this->service->getIndex()->exists()) {
62	1		error_log('++++ EL BASE SET UP T4a');
63
64	1		$this->service->getIndex()->create();
65	1		}
66	4		error_log('++++ EL BASE SET UP T4b');
67	4		$this->service->reset();
68	4		error_log('++++ EL BASE SET UP T4c');
69			// FIXME - use request getVar instead?
70	4		$_GET['progress'] = 20;
71			// load fixtures
72
73	4		$orig_fixture_file = static::$fixture_file;
74	4		error_log('++++ EL BASE SET UP T5');
75
76	4	View Code Duplication	foreach (static::$ignoreFixtureFileFor as $testPattern) {
			0 ignored issues – show Duplication introduced 2015-12-29 09:15 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
77			$pattern = '/'.$testPattern.'/';
78			if (preg_match($pattern, $this->getName())) {
79			static::$fixture_file = null;
80			}
81	4		}
82
83	4		error_log('++++ EL BASE SET UP T6');
84	4		} catch (Exception $e) {
85			error_log("**** EXCEPTION T1 ".$e->getMessage());
86			$elasticException = true;
87			}
88	4		error_log('++++ EL BASE SET UP T7');
89
90
91			// this needs to run otherwise nested injector errors show up
92	4		parent::setUp();
93
94	4		if ($elasticException) {
95			$this->fail('T1 An error has occurred trying to contact Elasticsearch server');
			0 ignored issues – show Bug introduced 2015-12-31 07:33 UTC by Report Bug Copy Issue Report The method `fail()` does not seem to exist on `object<ElasticsearchBaseTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
96			}
97
98			try {
99	4		static::$fixture_file = $orig_fixture_file;
			0 ignored issues – show Bug introduced 2015-12-31 07:33 UTC by Report Bug Copy Issue Report The variable `$orig_fixture_file` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
100
101	4		$this->publishSiteTree();
102	4		$this->service->reset();
103
104			// index loaded fixtures
105	4		$task = new ReindexTask($this->service);
106			// null request is fine as no parameters used
107
108	4		$task->run(null);
109	4		} catch (Exception $e) {
110			error_log("**** EXCEPTION T2 ".$e->getMessage());
111			$elasticException = true;
112			}
113
114	4		if ($elasticException) {
115			$this->fail('T2 An error has occurred trying to contact Elasticsearch server');
			0 ignored issues – show Bug introduced 2015-12-31 07:33 UTC by Report Bug Copy Issue Report The method `fail()` does not seem to exist on `object<ElasticsearchBaseTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
116			}
117
118	4		}
119
120
121			protected function devBuild() {
122			$task = new \BuildTask();
123			// null request is fine as no parameters used
124			$task->run(null);
125			}
126
127
128	4		private function publishSiteTree() {
129	4		foreach (SiteTree::get()->getIterator() as $page) {
130			// temporarily disable Elasticsearch indexing, it will be done in a batch
131			$page->IndexingOff = true;
132			$page->publish('Stage','Live');
133	4		}
134	4		}
135
136
137		View Code Duplication	public function generateAssertionsFromArray($toAssert) {
			1 ignored issue – show Duplication introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
138			echo '$expected = array('."\n";
139			foreach ($toAssert as $key => $value) {
140			$escValue = str_replace("'", '\\\'', $value);
141			echo "'$key' => '$escValue',\n";
142			}
143			echo ");\n";
144			echo '$this->assertEquals($expected, $somevar);'."\n";
145			}
146
147
148		View Code Duplication	public function generateAssertionsFromArray1D($toAssert) {
			1 ignored issue – show Duplication introduced 2015-12-01 14:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
149			echo '$expected = array('."\n";
150			foreach ($toAssert as $key => $value) {
151			$escValue = str_replace("'", '\\\'', $value);
152			echo "'$escValue',";
153			}
154			echo ");\n";
155			echo '$this->assertEquals($expected, $somevar);'."\n";
156			}
157
158
159			public function generateAssertionsFromArrayRecurse($toAssert) {
160			echo '$expected = ';
161			$this->recurseArrayAssertion($toAssert,1, 'FIXME');
162			echo '$this->assertEquals($expected, $somevar);'."\n";
163			}
164
165
166			private function recurseArrayAssertion($toAssert, $depth, $parentKey) {
167			$prefix = str_repeat("\t",$depth);
168			echo "\t{$prefix}'$parentKey' => array(\n";
169			$ctr = 0;
170			$len = sizeof(array_keys($toAssert));
171			foreach ($toAssert as $key => $value) {
172			if (is_array($value)) {
173			$this->recurseArrayAssertion($value, $depth+1, $key);
174			} else {
175			$escValue = str_replace("'", '\\\'', $value);
176			$comma = ',';
177			if ($ctr == $len-1) {
178			$comma = '';
179			}
180			echo "\t\t$prefix'$key' => '$escValue'$comma\n";
181			}
182
183			$ctr++;
184
185			}
186			echo "\t$prefix),\n";
187
188			}
189
190
191			/*
192			Helper methods for testing CMS fields
193			*/
194	1		public function checkTabExists($fields, $tabName) {
195			$tab = $fields->findOrMakeTab("Root.{$tabName}");
196			$actualTabName = $tab->getName();
197			$splits = explode('.', $tabName);
198			$size = sizeof($splits);
199	1		$nameToCheck = end($splits);
200			$this->assertEquals($actualTabName, $nameToCheck);
201			if ($size == 1) {
202			$this->assertEquals("Root_${tabName}", $tab->id());
203			} else {
204			$expected = "Root_{$splits[0]}_set_{$splits[1]}";
205			$this->assertEquals($expected, $tab->id());
206			}
207
208			return $tab;
209			}
210
211
212			public function checkFieldExists($tab,$fieldName) {
213			$fields = $tab->Fields();
			0 ignored issues – show Unused Code introduced 2015-12-29 09:15 UTC by Report Bug Copy Issue Report `$fields` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
214			$field = $tab->fieldByName($fieldName);
215			$this->assertTrue($field != null);
216			return $field;
217			}
218
219
220			/**
221			* From https://jtreminio.com/2013/03/unit-testing-tutorial-part-3-testing-protected-private-methods-coverage-reports-and-crap/
222			* Call protected/private method of a class.
223			*
224			* @param object &$object Instantiated object that we will run method on.
225			* @param string $methodName Method name to call
226			* @param array $parameters Array of parameters to pass into method.
227			*
228			* @return mixed Method return.
229			*/
230			public function invokeMethod(&$object, $methodName, array $parameters = array())
231			{
232			$reflection = new \ReflectionClass(get_class($object));
233			$method = $reflection->getMethod($methodName);
234			$method->setAccessible(true);
235
236			return $method->invokeArgs($object, $parameters);
237			}
238
239
240			public function checkNumberOfIndexedDocuments($expectedAmount) {
241			$index = $this->service->getIndex();
242			$status = $index->getStatus()->getData();
243
244			$numberDocsInIndex = -1; // flag value for not yet indexed
			0 ignored issues – show Unused Code introduced 2015-12-30 12:07 UTC by Report Bug Copy Issue Report `$numberDocsInIndex` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
245			error_log('CHECKING NUMBER OF INDEXED DOCUMENTS, SHOULD BE ' . $expectedAmount);
246			error_log(print_r($status,1));
247
248			if (isset($status['indices']['elastica_ss_module_test_en_us']['docs'])) {
249			$numberDocsInIndex = $status['indices']['elastica_ss_module_test_en_us']['docs']['num_docs'];
250			error_log('DOCUMENTS FOUND:'.$numberDocsInIndex);
251			} else {
252			$numberDocsInIndex = 0;
253			}
254
255			$this->assertEquals($expectedAmount,$numberDocsInIndex);
256			}
257
258			/*
259			Get the number of documents in an index. It is assumed the index exists, if not the test will fail
260			*/
261			public function getNumberOfIndexedDocuments() {
262			$index = $this->service->getIndex();
263			$status = $index->getStatus()->getData();
264
265			$numberDocsInIndex = -1; // flag value for not yet indexed
266			if (isset($status['indices']['elastica_ss_module_test_en_us']['docs'])) {
267			$numberDocsInIndex = $status['indices']['elastica_ss_module_test_en_us']['docs']['num_docs'];
268			}
269
270			$this->assertGreaterThan(-1, $numberDocsInIndex);
271			return $numberDocsInIndex;
272			}
273			}
274

gordonbanderson / silverstripe-elastica

Push — dev2 ( 774f9d...0919fb )

ElasticsearchBaseTest::setUp() D

Complexity

Size

Duplication

Code Coverage

How to fix Long Method

Long Method

Available Fixes

Duplication Side-by-Side

Filter issues like