gordonbanderson / silverstripe-elastica

tests/ElasticSearchPage_Validator_Test.php

Doc Comments +4 added lines

@@ -106,6 +106,10 @@
 	}
 
 
+	/**
+	 * @param string $fieldName
+	 * @param string $message
+	 */
 	private function checkForError($fieldName, $badValue, $message) {
 		$this->ElasticSearchPage->$fieldName = $badValue;
 

Spacing +6 added lines, -6 removed lines

@@ -8,7 +8,7 @@ 
 		parent::setup();
 		$this->ElasticSearchPage = $this->objFromFixture('ElasticSearchPage', 'search');
 
-		$this->ElasticSearchPage->SimilarityStopWords =  'a,the,which';
+		$this->ElasticSearchPage->SimilarityStopWords = 'a,the,which';
 		$this->ElasticSearchPage->write();
 
 		$this->Validator = $this->ElasticSearchPage->getCMSValidator();
@@ -34,7 +34,7 @@ 
 			'AutoCompleteFieldID' => null,
 			'AutoCompleteFunctionID' => null,
 			'SearchHelper' => null,
-			'SimilarityStopWords' => array('a', 'an', 'the', ),
+			'SimilarityStopWords' => array('a', 'an', 'the',),
 			'MinTermFreq' => 2,
 			'MaxTermFreq' => 25,
 			'MinDocFreq' => 2,
@@ -102,7 +102,7 @@ 
 		$esp->Identifier = 'THISWILLBECOPIED';
 		$esp->write();
 		$this->checkForError('Identifier', 'THISWILLBECOPIED',
-			'The identifier THISWILLBECOPIED already exists' );
+			'The identifier THISWILLBECOPIED already exists');
 	}
 
 
@@ -126,9 +126,9 @@ 
 
 		foreach ($errors as $error) {
 			echo "Checking error\n";
-			echo " - " . $error['fieldName'].' => '.$error['message']."\n";
-			echo "\tT1:".($error['message'] == $message);
-			echo "\n\tT2:".($error['fieldName'] == $fieldName);
+			echo " - " . $error['fieldName'] . ' => ' . $error['message'] . "\n";
+			echo "\tT1:" . ($error['message'] == $message);
+			echo "\n\tT2:" . ($error['fieldName'] == $fieldName);
 
 			if ($error['message'] == $message && $error['fieldName'] == $fieldName) {
 				$found = true;

tests/ElasticsearchTestBase.php

Doc Comments +11 added lines

@@ -132,6 +132,10 @@ 
 	}
 
 
+	/**
+	 * @param integer $depth
+	 * @param string $parentKey
+	 */
 	private function recurseArrayAssertion($toAssert, $depth, $parentKey) {
 		$prefix = str_repeat("\t",$depth);
 		echo "\t{$prefix}'$parentKey' => array(\n";
@@ -160,6 +164,10 @@ 
 	/*
 	Helper methods for testing CMS fields
 	 */
+
+	/**
+	 * @param string $tabName
+	 */
 	public function checkTabExists($fields, $tabName) {
 		echo "Searching for tab $tabName\n";
 		$tab = $fields->findOrMakeTab("Root.{$tabName}");
@@ -184,6 +192,9 @@ 
 	}
 
 
+	/**
+	 * @param string $fieldName
+	 */
 	public function checkFieldExists($tab,$fieldName) {
 		$fields = $tab->Fields();
 		echo "TAB:{$tab->Name}\n";

Indentation +4 added lines, -4 removed lines

@@ -208,11 +208,11 @@
 	 */
 	public function invokeMethod(&$object, $methodName, array $parameters = array())
 	{
-	    $reflection = new \ReflectionClass(get_class($object));
-	    $method = $reflection->getMethod($methodName);
-	    $method->setAccessible(true);
+		$reflection = new \ReflectionClass(get_class($object));
+		$method = $reflection->getMethod($methodName);
+		$method->setAccessible(true);
 
-	    return $method->invokeArgs($object, $parameters);
+		return $method->invokeArgs($object, $parameters);
 	}
 
 

Spacing +19 added lines, -19 removed lines

@@ -9,8 +9,8 @@ 
 	public static $ignoreFixtureFileFor = array();
 
 	protected $extraDataObjects = array(
-		'SearchableTestPage','FlickrPhotoTO','FlickrAuthorTO','FlickrSetTO','FlickrTagTO',
-		'SearchableTestFatherPage','SearchableTestGrandFatherPage','AutoCompleteOption'
+		'SearchableTestPage', 'FlickrPhotoTO', 'FlickrAuthorTO', 'FlickrSetTO', 'FlickrTagTO',
+		'SearchableTestFatherPage', 'SearchableTestGrandFatherPage', 'AutoCompleteOption'
 	);
 
 
@@ -39,7 +39,7 @@ 
 
 		// this needs to be called in order to create the list of searchable
 		// classes and fields that are available.  Simulates part of a build
-		$classes = array('SearchableTestPage','SiteTree','Page','FlickrPhotoTO','FlickrSetTO',
+		$classes = array('SearchableTestPage', 'SiteTree', 'Page', 'FlickrPhotoTO', 'FlickrSetTO',
 			'FlickrTagTO', 'FlickrAuthorTO');
 		$this->requireDefaultRecordsFrom = $classes;
 
@@ -61,13 +61,13 @@ 
 		$orig_fixture_file = static::$fixture_file;
 
 		foreach (static::$ignoreFixtureFileFor as $testPattern) {
-			$pattern = '/'.$testPattern.'/';
+			$pattern = '/' . $testPattern . '/';
 			if (preg_match($pattern, $this->getName())) {
 				static::$fixture_file = null;
 			}
 		}
 
-		echo "\n\n\n\nEXECUTING TEST {$this->getName()}, FIXTURES=".static::$fixture_file."\n";
+		echo "\n\n\n\nEXECUTING TEST {$this->getName()}, FIXTURES=" . static::$fixture_file . "\n";
 
 		parent::setUp();
 		static::$fixture_file = $orig_fixture_file;
@@ -97,53 +97,53 @@ 
 			// temporarily disable Elasticsearch indexing, it will be done in a batch
 			$page->IndexingOff = true;
 
-			echo "Publishing ".$page->Title."\n";
-			$page->publish('Stage','Live');
+			echo "Publishing " . $page->Title . "\n";
+			$page->publish('Stage', 'Live');
 		}
 	}
 
 
 	public function generateAssertionsFromArray($toAssert) {
-		echo '$expected = array('."\n";
+		echo '$expected = array(' . "\n";
 		foreach ($toAssert as $key => $value) {
 			$escValue = str_replace("'", '\\\'', $value);
 			echo "'$key' => '$escValue',\n";
 		}
 		echo ");\n";
-		echo '$this->assertEquals($expected, $somevar);'."\n";
+		echo '$this->assertEquals($expected, $somevar);' . "\n";
 	}
 
 
 	public function generateAssertionsFromArray1D($toAssert) {
-		echo '$expected = array('."\n";
+		echo '$expected = array(' . "\n";
 		foreach ($toAssert as $key => $value) {
 			$escValue = str_replace("'", '\\\'', $value);
 			echo "'$escValue',";
 		}
 		echo ");\n";
-		echo '$this->assertEquals($expected, $somevar);'."\n";
+		echo '$this->assertEquals($expected, $somevar);' . "\n";
 	}
 
 
 	public function generateAssertionsFromArrayRecurse($toAssert) {
 		echo '$expected = ';
-			$this->recurseArrayAssertion($toAssert,1, 'FIXME');
-		echo '$this->assertEquals($expected, $somevar);'."\n";
+			$this->recurseArrayAssertion($toAssert, 1, 'FIXME');
+		echo '$this->assertEquals($expected, $somevar);' . "\n";
 	}
 
 
 	private function recurseArrayAssertion($toAssert, $depth, $parentKey) {
-		$prefix = str_repeat("\t",$depth);
+		$prefix = str_repeat("\t", $depth);
 		echo "\t{$prefix}'$parentKey' => array(\n";
 		$ctr = 0;
 		$len = sizeof(array_keys($toAssert));
 		foreach ($toAssert as $key => $value) {
 			if (is_array($value)) {
-				$this->recurseArrayAssertion($value, $depth+1, $key);
+				$this->recurseArrayAssertion($value, $depth + 1, $key);
 			} else {
 				$escValue = str_replace("'", '\\\'', $value);
 				$comma = ',';
-				if ($ctr == $len-1) {
+				if ($ctr == $len - 1) {
 					$comma = '';
 				}
 				echo "\t\t$prefix'$key' => '$escValue'$comma\n";
@@ -184,11 +184,11 @@ 
 	}
 
 
-	public function checkFieldExists($tab,$fieldName) {
+	public function checkFieldExists($tab, $fieldName) {
 		$fields = $tab->Fields();
 		echo "TAB:{$tab->Name}\n";
 		foreach ($fields as $fi) {
-			echo "NAME:".$fi->Name."\n";
+			echo "NAME:" . $fi->Name . "\n";
 		}
 		$field = $tab->fieldByName($fieldName);
 		$this->assertTrue($field != null);
@@ -225,7 +225,7 @@ 
 			$numberDocsInIndex = $status['indices']['elastica_ss_module_test_en_us']['docs']['num_docs'];
 		}
 
-		$this->assertEquals($expectedAmount,$numberDocsInIndex);
+		$this->assertEquals($expectedAmount, $numberDocsInIndex);
 	}
 
 	/*

tests/mock/Translatable.php

Doc Comments +2 added lines, -3 removed lines

@@ -282,7 +282,6 @@ 
 	 * to "auto-filter" all SELECT queries by this language.
 	 * See {@link disable_locale_filter()} on how to override this behaviour temporarily.
 	 *
-	 * @param string $lang New reading language.
 	 */
 	static function set_current_locale($locale) {
 		self::$current_locale = $locale;
@@ -373,7 +372,7 @@ 
 	 * Check if a given SQLQuery filters on the Locale field
 	 *
 	 * @param SQLQuery $query
-	 * @return boolean
+	 * @return boolean|null
 	 */
 	protected function filtersOnLocale($query) {
 		foreach($query->getWhere() as $condition) {
@@ -536,7 +535,7 @@ 
 	 * This ID might equal the record ID, but doesn't have to -
 	 * it just points to one "original" record in the list.
 	 *
-	 * @return int Numeric ID of the translationgroup in the <classname>_translationgroup table
+	 * @return false|string Numeric ID of the translationgroup in the <classname>_translationgroup table
 	 */
 	public function getTranslationGroup() {
 		if(!$this->owner->exists()) return false;

Indentation +1 added lines, -1 removed lines

@@ -892,7 +892,7 @@
 	 * to Translatable
 	 *
 	 * @return bool
-     */
+	 */
 	public function augmentValidURLSegment() {
 		$reEnableFilter = false;
 		if(!Config::inst()->get('Translatable', 'enforce_global_unique_urls')) {

Spacing +51 added lines, -51 removed lines

@@ -344,14 +344,14 @@ 
 		parent::setOwner($owner, $ownerBaseClass);
 
 		// setting translatable fields by inspecting owner - this should really be done in the constructor
-		if($this->owner && $this->translatableFields === null) {
+		if ($this->owner && $this->translatableFields === null) {
 			$this->translatableFields = array_merge(
 				array_keys($this->owner->db()),
 				array_keys($this->owner->has_many()),
 				array_keys($this->owner->many_many())
 			);
 			foreach (array_keys($this->owner->has_one()) as $fieldname) {
-				$this->translatableFields[] = $fieldname.'ID';
+				$this->translatableFields[] = $fieldname . 'ID';
 			}
 		}
 	}
@@ -376,8 +376,8 @@ 
 	 * @return boolean
 	 */
 	protected function filtersOnLocale($query) {
-		foreach($query->getWhere() as $condition) {
-			if(preg_match('/("|\'|`)Locale("|\'|`)/', $condition)) return true;
+		foreach ($query->getWhere() as $condition) {
+			if (preg_match('/("|\'|`)Locale("|\'|`)/', $condition)) return true;
 		}
 	}
 
@@ -389,18 +389,18 @@ 
 	 *
 	 * Use {@link disable_locale_filter()} to temporarily disable this "auto-filtering".
 	 */
-	public function augmentSQL(SQLQuery &$query, DataQuery $dataQuery = null) {
+	public function augmentSQL(SQLQuery & $query, DataQuery $dataQuery = null) {
 		// If the record is saved (and not a singleton), and has a locale,
 		// limit the current call to its locale. This fixes a lot of problems
 		// with other extensions like Versioned
-		if($this->owner->ID && !empty($this->owner->Locale)) {
+		if ($this->owner->ID && !empty($this->owner->Locale)) {
 			$locale = $this->owner->Locale;
 		} else {
 			$locale = Translatable::get_current_locale();
 		}
 
 		$baseTable = ClassInfo::baseDataClass($this->owner->class);
-		if(
+		if (
 			$locale
 			// unless the filter has been temporarily disabled
 			&& self::locale_filter_enabled()
@@ -415,13 +415,13 @@ 
 			// call or through custom SQL filters)
 			&& !$this->filtersOnLocale($query)
 			//&& !$query->filtersOnFK()
-		)  {
+		) {
 			$qry = sprintf('"%s"."Locale" = \'%s\'', $baseTable, Convert::raw2sql($locale));
 			$query->addWhere($qry);
 		}
 	}
 
-	function augmentDataQueryCreation(SQLQuery &$sqlQuery, DataQuery &$dataQuery) {
+	function augmentDataQueryCreation(SQLQuery & $sqlQuery, DataQuery & $dataQuery) {
 		$enabled = self::locale_filter_enabled();
 		$dataQuery->setQueryParam(self::QUERY_LOCALE_FILTER_ENABLED, $enabled);
 	}
@@ -429,7 +429,7 @@ 
 	 // FIXME - NO TEST COVERAGE BUT REQUIRED
 	function augmentDatabase() {
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
-		if($this->owner->class != $baseDataClass) return;
+		if ($this->owner->class != $baseDataClass) return;
 
 		$fields = array(
 			'OriginalID' => 'Int',
@@ -445,7 +445,7 @@ 
 
 		// Remove 2.2 style tables
 		DB::dontRequireTable("{$baseDataClass}_lang");
-		if($this->owner->hasExtension('Versioned')) {
+		if ($this->owner->hasExtension('Versioned')) {
 			DB::dontRequireTable("{$baseDataClass}_lang_Live");
 			DB::dontRequireTable("{$baseDataClass}_lang_versions");
 		}
@@ -456,7 +456,7 @@ 
 	 */
 	public function requireDefaultRecords() {
 		// @todo This relies on the Locale attribute being on the base data class, and not any subclasses
-		if($this->owner->class != ClassInfo::baseDataClass($this->owner->class)) return false;
+		if ($this->owner->class != ClassInfo::baseDataClass($this->owner->class)) return false;
 
 		// Permissions: If a group doesn't have any specific TRANSLATE_<locale> edit rights,
 		// but has CMS_ACCESS_CMSMain (general CMS access), then assign TRANSLATE_ALL permissions as a default.
@@ -468,14 +468,14 @@ 
 			'CMS_ACCESS_LeftAndMain',
 			'ADMIN'
 		));
-		if($groups) foreach($groups as $group) {
+		if ($groups) foreach ($groups as $group) {
 			$codes = $group->Permissions()->column('Code');
 			$hasTranslationCode = false;
-			foreach($codes as $code) {
-				if(preg_match('/^TRANSLATE_/', $code)) $hasTranslationCode = true;
+			foreach ($codes as $code) {
+				if (preg_match('/^TRANSLATE_/', $code)) $hasTranslationCode = true;
 			}
 			// Only add the code if no more restrictive code exists
-			if(!$hasTranslationCode) Permission::grant($group->ID, 'TRANSLATE_ALL');
+			if (!$hasTranslationCode) Permission::grant($group->ID, 'TRANSLATE_ALL');
 		}
 
 		// If the Translatable extension was added after the first records were already
@@ -485,7 +485,7 @@ 
 			'SELECT "ID" FROM "%s" WHERE "Locale" IS NULL OR "Locale" = \'\'',
 			ClassInfo::baseDataClass($this->owner->class)
 		))->column();
-		if(!$idsWithoutLocale) return;
+		if (!$idsWithoutLocale) return;
 
 
 
@@ -502,13 +502,13 @@ 
 	 * @param boolean $overwrite
 	 */
 	public function addTranslationGroup($originalID, $overwrite = false) {
-		if(!$this->owner->exists()) return false;
+		if (!$this->owner->exists()) return false;
 
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
 		$existingGroupID = $this->getTranslationGroup($originalID);
 
 		// Remove any existing groups if overwrite flag is set
-		if($existingGroupID && $overwrite) {
+		if ($existingGroupID && $overwrite) {
 			$sql = sprintf(
 				'DELETE FROM "%s_translationgroups" WHERE "TranslationGroupID" = %d AND "OriginalID" = %d',
 				$baseDataClass,
@@ -520,7 +520,7 @@ 
 		}
 
 		// Add to group (only if not in existing group or $overwrite flag is set)
-		if(!$existingGroupID) {
+		if (!$existingGroupID) {
 			$sql = sprintf(
 				'INSERT INTO "%s_translationgroups" ("TranslationGroupID","OriginalID") VALUES (%d,%d)',
 				$baseDataClass,
@@ -539,7 +539,7 @@ 
 	 * @return int Numeric ID of the translationgroup in the <classname>_translationgroup table
 	 */
 	public function getTranslationGroup() {
-		if(!$this->owner->exists()) return false;
+		if (!$this->owner->exists()) return false;
 
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
 		return DB::query(
@@ -587,7 +587,7 @@ 
 		// of the content, as a "single language" website might be expanded
 		// later on. See {@link requireDefaultRecords()} for batch setting
 		// of empty Locale columns on each dev/build call.
-		if(!$this->owner->Locale) {
+		if (!$this->owner->Locale) {
 			$this->owner->Locale = Translatable::get_current_locale();
 		}
 
@@ -597,12 +597,12 @@ 
 		// Caution: This logic is very sensitve to infinite loops when translation status isn't determined properly
 		// If a parent for the newly written translation was existing before this
 		// onBeforeWrite() call, it will already have been linked correctly through createTranslation()
-		if(
+		if (
 			class_exists('SiteTree')
 			&& $this->owner->hasField('ParentID')
 			&& $this->owner instanceof SiteTree
 		) {
-			if(
+			if (
 				!$this->owner->ID
 				&& $this->owner->ParentID
 				&& !$this->owner->Parent()->hasTranslation($this->owner->Locale)
@@ -614,7 +614,7 @@ 
 
 		// Has to be limited to the default locale, the assumption is that the "page type"
 		// dropdown is readonly on all translations.
-		if($this->owner->ID && $this->owner->Locale == Translatable::default_locale()) {
+		if ($this->owner->ID && $this->owner->Locale == Translatable::default_locale()) {
 			$changedFields = $this->owner->getChangedFields();
 			$changed = isset($changedFields['ClassName']);
 
@@ -642,11 +642,11 @@ 
 				}
 			}
 
-			if($changed) {
+			if ($changed) {
 				$this->owner->ClassName = $changedFields['ClassName']['before'];
 				$translations = $this->owner->getTranslations();
 				$this->owner->ClassName = $changedFields['ClassName']['after'];
-				if($translations) foreach($translations as $translation) {
+				if ($translations) foreach ($translations as $translation) {
 					$translation->setClassName($this->owner->ClassName);
 					$translation = $translation->newClassInstance($translation->ClassName);
 					$translation->populateDefaults();
@@ -657,7 +657,7 @@ 
 		}
 
 		// see onAfterWrite()
-		if(!$this->owner->ID) {
+		if (!$this->owner->ID) {
 			$this->owner->_TranslatableIsNewRecord = true;
 		}
 	}
@@ -665,12 +665,12 @@ 
 	function onAfterWrite() {
 		// hacky way to determine if the record was created in the database,
 		// or just updated
-		if($this->owner->_TranslatableIsNewRecord) {
+		if ($this->owner->_TranslatableIsNewRecord) {
 			// this would kick in for all new records which are NOT
 			// created through createTranslation(), meaning they don't
 			// have the translation group automatically set.
 			$translationGroupID = $this->getTranslationGroup();
-			if(!$translationGroupID) {
+			if (!$translationGroupID) {
 				$this->addTranslationGroup(
 					$this->owner->_TranslationGroupID ? $this->owner->_TranslationGroupID : $this->owner->ID
 				);
@@ -705,7 +705,7 @@ 
 
 		// Find the locale language-independent of the page
 		self::disable_locale_filter();
-		$default = SiteTree::get()->where(sprintf (
+		$default = SiteTree::get()->where(sprintf(
 			'"URLSegment" = \'%s\'%s',
 			Convert::raw2sql($URLSegment),
 			(is_int($parentID) ? " AND \"ParentID\" = $parentID" : null)
@@ -721,7 +721,7 @@ 
 	public function updateRelativeLink(&$base, &$action) {
 		// Prevent home pages for non-default locales having their urlsegments
 		// reduced to the site root.
-		if($base === null && $this->owner->Locale != self::default_locale()){
+		if ($base === null && $this->owner->Locale != self::default_locale()) {
 			$base = $this->owner->URLSegment;
 		}
 	}
@@ -745,14 +745,14 @@ 
 	 * @return DataObjectSet
 	 */
 	function getTranslations($locale = null, $stage = null) {
-		if(!$this->owner->exists()) return new ArrayList();
+		if (!$this->owner->exists()) return new ArrayList();
 
 		// HACK need to disable language filtering in augmentSQL(),
 		// as we purposely want to get different language
 		// also save state of locale-filter, revert to this state at the
 		// end of this method
 		$localeFilterEnabled = false;
-		if(self::locale_filter_enabled()) {
+		if (self::locale_filter_enabled()) {
 			self::disable_locale_filter();
 			$localeFilterEnabled = true;
 		}
@@ -761,7 +761,7 @@ 
 
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
 		$filter = sprintf('"%s_translationgroups"."TranslationGroupID" = %d', $baseDataClass, $translationGroupID);
-		if($locale) {
+		if ($locale) {
 			$filter .= sprintf(' AND "%s"."Locale" = \'%s\'', $baseDataClass, Convert::raw2sql($locale));
 		} else {
 			// exclude the language of the current owner
@@ -769,15 +769,15 @@ 
 		}
 		$currentStage = Versioned::current_stage();
 		$joinOnClause = sprintf('"%s_translationgroups"."OriginalID" = "%s"."ID"', $baseDataClass, $baseDataClass);
-		if($this->owner->hasExtension("Versioned")) {
-			if($stage) Versioned::reading_stage($stage);
+		if ($this->owner->hasExtension("Versioned")) {
+			if ($stage) Versioned::reading_stage($stage);
 			$translations = Versioned::get_by_stage(
 				$baseDataClass,
 				Versioned::current_stage(),
 				$filter,
 				null
 			)->leftJoin("{$baseDataClass}_translationgroups", $joinOnClause);
-			if($stage) Versioned::reading_stage($currentStage);
+			if ($stage) Versioned::reading_stage($currentStage);
 		} else {
 			$class = $this->owner->class;
 			$translations = $baseDataClass::get()
@@ -786,7 +786,7 @@ 
 		}
 
 		// only re-enable locale-filter if it was enabled at the beginning of this method
-		if($localeFilterEnabled) {
+		if ($localeFilterEnabled) {
 			self::enable_locale_filter();
 		}
 
@@ -827,7 +827,7 @@ 
 	 */
 	static function get_existing_content_languages($className = 'SiteTree', $where = '') {
 		$baseTable = ClassInfo::baseDataClass($className);
-		$query = new SQLQuery("Distinct \"Locale\"","\"$baseTable\"",$where, '', "\"Locale\"");
+		$query = new SQLQuery("Distinct \"Locale\"", "\"$baseTable\"", $where, '', "\"Locale\"");
 		$dbLangs = $query->execute()->column();
 		$langlist = array_merge((array)Translatable::default_locale(), (array)$dbLangs);
 		$returnMap = array();
@@ -836,8 +836,8 @@ 
 			Config::inst()->get('i18n', 'common_locales')
 		);
 		foreach ($langlist as $langCode) {
-			if($langCode && isset($allCodes[$langCode])) {
-				if(is_array($allCodes[$langCode])) {
+			if ($langCode && isset($allCodes[$langCode])) {
+				if (is_array($allCodes[$langCode])) {
 					$returnMap[$langCode] = $allCodes[$langCode]['name'];
 				} else {
 					$returnMap[$langCode] = $allCodes[$langCode];
@@ -860,8 +860,8 @@ 
 		$original = SiteTree::get_by_link(RootURLController::config()->default_homepage_link);
 		self::set_current_locale($originalLocale);
 
-		if($original) {
-			if($translation = $original->getTranslation($locale)) return trim($translation->RelativeLink(true), '/');
+		if ($original) {
+			if ($translation = $original->getTranslation($locale)) return trim($translation->RelativeLink(true), '/');
 		}
 	}
 
@@ -870,7 +870,7 @@ 
 	 * @deprecated 2.4 Use {@link Translatable::get_homepage_link_by_locale()}
 	 */
 	static function get_homepage_urlsegment_by_locale($locale) {
-		user_error (
+		user_error(
 			'Translatable::get_homepage_urlsegment_by_locale() is deprecated, please use get_homepage_link_by_locale()',
 			E_USER_NOTICE
 		);
@@ -884,7 +884,7 @@ 
 	 * Return a piece of text to keep DataObject cache keys appropriately specific
 	 */
 	function cacheKeyComponent() {
-		return 'locale-'.self::get_current_locale();
+		return 'locale-' . self::get_current_locale();
 	}
 
 	/**
@@ -895,18 +895,18 @@ 
      */
 	public function augmentValidURLSegment() {
 		$reEnableFilter = false;
-		if(!Config::inst()->get('Translatable', 'enforce_global_unique_urls')) {
+		if (!Config::inst()->get('Translatable', 'enforce_global_unique_urls')) {
 			self::enable_locale_filter();
-		} elseif(self::locale_filter_enabled()) {
+		} elseif (self::locale_filter_enabled()) {
 			self::disable_locale_filter();
 			$reEnableFilter = true;
 		}
 
-		$IDFilter = ($this->owner->ID) ? "AND \"SiteTree\".\"ID\" <> {$this->owner->ID}" :  null;
+		$IDFilter = ($this->owner->ID) ? "AND \"SiteTree\".\"ID\" <> {$this->owner->ID}" : null;
 		$parentFilter = null;
 
 		if (Config::inst()->get('SiteTree', 'nested_urls')) {
-			if($this->owner->ParentID) {
+			if ($this->owner->ParentID) {
 				$parentFilter = " AND \"SiteTree\".\"ParentID\" = {$this->owner->ParentID}";
 			} else {
 				$parentFilter = ' AND "SiteTree"."ParentID" = 0';
@@ -916,7 +916,7 @@ 
 		$existingPage = SiteTree::get()
 			// disable get_one cache, as this otherwise may pick up results from when locale_filter was on
 			->where("\"URLSegment\" = '{$this->owner->URLSegment}' $IDFilter $parentFilter")->First();
-		if($reEnableFilter) self::enable_locale_filter();
+		if ($reEnableFilter) self::enable_locale_filter();
 
 		// By returning TRUE or FALSE, we overrule the base SiteTree->validateURLSegment() logic
 		return !$existingPage;

Braces +45 added lines, -15 removed lines

@@ -377,7 +377,9 @@ 
 	 */
 	protected function filtersOnLocale($query) {
 		foreach($query->getWhere() as $condition) {
-			if(preg_match('/("|\'|`)Locale("|\'|`)/', $condition)) return true;
+			if(preg_match('/("|\'|`)Locale("|\'|`)/', $condition)) {
+				return true;
+			}
 		}
 	}
 
@@ -429,7 +431,9 @@ 
 	 // FIXME - NO TEST COVERAGE BUT REQUIRED
 	function augmentDatabase() {
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
-		if($this->owner->class != $baseDataClass) return;
+		if($this->owner->class != $baseDataClass) {
+			return;
+		}
 
 		$fields = array(
 			'OriginalID' => 'Int',
@@ -456,7 +460,9 @@ 
 	 */
 	public function requireDefaultRecords() {
 		// @todo This relies on the Locale attribute being on the base data class, and not any subclasses
-		if($this->owner->class != ClassInfo::baseDataClass($this->owner->class)) return false;
+		if($this->owner->class != ClassInfo::baseDataClass($this->owner->class)) {
+			return false;
+		}
 
 		// Permissions: If a group doesn't have any specific TRANSLATE_<locale> edit rights,
 		// but has CMS_ACCESS_CMSMain (general CMS access), then assign TRANSLATE_ALL permissions as a default.
@@ -468,14 +474,20 @@ 
 			'CMS_ACCESS_LeftAndMain',
 			'ADMIN'
 		));
-		if($groups) foreach($groups as $group) {
+		if($groups) {
+			foreach($groups as $group) {
 			$codes = $group->Permissions()->column('Code');
+		}
 			$hasTranslationCode = false;
 			foreach($codes as $code) {
-				if(preg_match('/^TRANSLATE_/', $code)) $hasTranslationCode = true;
+				if(preg_match('/^TRANSLATE_/', $code)) {
+					$hasTranslationCode = true;
+				}
 			}
 			// Only add the code if no more restrictive code exists
-			if(!$hasTranslationCode) Permission::grant($group->ID, 'TRANSLATE_ALL');
+			if(!$hasTranslationCode) {
+				Permission::grant($group->ID, 'TRANSLATE_ALL');
+			}
 		}
 
 		// If the Translatable extension was added after the first records were already
@@ -485,7 +497,9 @@ 
 			'SELECT "ID" FROM "%s" WHERE "Locale" IS NULL OR "Locale" = \'\'',
 			ClassInfo::baseDataClass($this->owner->class)
 		))->column();
-		if(!$idsWithoutLocale) return;
+		if(!$idsWithoutLocale) {
+			return;
+		}
 
 
 
@@ -502,7 +516,9 @@ 
 	 * @param boolean $overwrite
 	 */
 	public function addTranslationGroup($originalID, $overwrite = false) {
-		if(!$this->owner->exists()) return false;
+		if(!$this->owner->exists()) {
+			return false;
+		}
 
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
 		$existingGroupID = $this->getTranslationGroup($originalID);
@@ -539,7 +555,9 @@ 
 	 * @return int Numeric ID of the translationgroup in the <classname>_translationgroup table
 	 */
 	public function getTranslationGroup() {
-		if(!$this->owner->exists()) return false;
+		if(!$this->owner->exists()) {
+			return false;
+		}
 
 		$baseDataClass = ClassInfo::baseDataClass($this->owner->class);
 		return DB::query(
@@ -646,8 +664,10 @@ 
 				$this->owner->ClassName = $changedFields['ClassName']['before'];
 				$translations = $this->owner->getTranslations();
 				$this->owner->ClassName = $changedFields['ClassName']['after'];
-				if($translations) foreach($translations as $translation) {
+				if($translations) {
+					foreach($translations as $translation) {
 					$translation->setClassName($this->owner->ClassName);
+				}
 					$translation = $translation->newClassInstance($translation->ClassName);
 					$translation->populateDefaults();
 					$translation->forceChange();
@@ -745,7 +765,9 @@ 
 	 * @return DataObjectSet
 	 */
 	function getTranslations($locale = null, $stage = null) {
-		if(!$this->owner->exists()) return new ArrayList();
+		if(!$this->owner->exists()) {
+			return new ArrayList();
+		}
 
 		// HACK need to disable language filtering in augmentSQL(),
 		// as we purposely want to get different language
@@ -770,14 +792,18 @@ 
 		$currentStage = Versioned::current_stage();
 		$joinOnClause = sprintf('"%s_translationgroups"."OriginalID" = "%s"."ID"', $baseDataClass, $baseDataClass);
 		if($this->owner->hasExtension("Versioned")) {
-			if($stage) Versioned::reading_stage($stage);
+			if($stage) {
+				Versioned::reading_stage($stage);
+			}
 			$translations = Versioned::get_by_stage(
 				$baseDataClass,
 				Versioned::current_stage(),
 				$filter,
 				null
 			)->leftJoin("{$baseDataClass}_translationgroups", $joinOnClause);
-			if($stage) Versioned::reading_stage($currentStage);
+			if($stage) {
+				Versioned::reading_stage($currentStage);
+			}
 		} else {
 			$class = $this->owner->class;
 			$translations = $baseDataClass::get()
@@ -861,7 +887,9 @@ 
 		self::set_current_locale($originalLocale);
 
 		if($original) {
-			if($translation = $original->getTranslation($locale)) return trim($translation->RelativeLink(true), '/');
+			if($translation = $original->getTranslation($locale)) {
+				return trim($translation->RelativeLink(true), '/');
+			}
 		}
 	}
 
@@ -916,7 +944,9 @@ 
 		$existingPage = SiteTree::get()
 			// disable get_one cache, as this otherwise may pick up results from when locale_filter was on
 			->where("\"URLSegment\" = '{$this->owner->URLSegment}' $IDFilter $parentFilter")->First();
-		if($reEnableFilter) self::enable_locale_filter();
+		if($reEnableFilter) {
+			self::enable_locale_filter();
+		}
 
 		// By returning TRUE or FALSE, we overrule the base SiteTree->validateURLSegment() logic
 		return !$existingPage;

tests/QueryGeneratorTest.php

Doc Comments +3 added lines

@@ -38,6 +38,9 @@
 	}
 
 
+	/**
+	 * @param string $q
+	 */
 	private function getDefaultSuggest($q) {
 		return array(
 				'query-phrase-suggestions' => array(

Spacing +27 added lines, -27 removed lines

@@ -122,7 +122,7 @@ 
 
 		$qg->setShowResultsForEmptyQuery(false);
 		$qs = array('multi_match' => array(
-			'fields' => array('Title','Title.*','Description','Description.*'),
+			'fields' => array('Title', 'Title.*', 'Description', 'Description.*'),
 			'type' => 'most_fields',
 			'query' => 'New Zealand',
 			'lenient' => true
@@ -158,7 +158,7 @@ 
 		$qg->setShowResultsForEmptyQuery(false);
 		$qs = array(
 			'multi_match' => array(
-				'fields' => array('Title','Title.*','Description','Description.*'),
+				'fields' => array('Title', 'Title.*', 'Description', 'Description.*'),
 				'type' => 'most_fields',
 				'query' => '',
 				'lenient' => true
@@ -369,8 +369,8 @@ 
 				'filtered' => array(
 					'filter' =>
 					array('and' => array(
-						0 => array( 'term' =>  array('ISO' => 400)),
-						1 => array( 'range' => array(
+						0 => array('term' =>  array('ISO' => 400)),
+						1 => array('range' => array(
 							'AspectRatio' => array(
 								'gte' => '0.9',
 								'lt' => '1.2'
@@ -413,14 +413,14 @@ 
 			'query' => array(
 				'filtered' => array('filter' =>
 					array('and' => array(
-						0 => array( 'term' =>  array('ISO' => 400)),
-						1 => array( 'range' => array(
+						0 => array('term' =>  array('ISO' => 400)),
+						1 => array('range' => array(
 							'AspectRatio' => array(
 								'gte' => '0.9',
 								'lt' => '1.2'
 							)
 						)),
-						2 => array( 'term' =>  array('Aperture' => 5.6)),
+						2 => array('term' =>  array('Aperture' => 5.6)),
 					)
 				))
 			),
@@ -472,7 +472,7 @@ 
 		$expected['query']['filtered']['query']['multi_match'] = array(
 			'query' => 'New Zealand',
 			'lenient' => true,
-			'fields' => array('Title^2', 'Title.*^2','Content', 'Content.*'),
+			'fields' => array('Title^2', 'Title.*^2', 'Content', 'Content.*'),
 			'type' => 'most_fields'
 		);
 
@@ -503,8 +503,8 @@ 
 				'filtered' => array(
 					'filter' =>
 					array('and' => array(
-						0 => array( 'term' =>  array('ISO' => 400)),
-						1 => array( 'range' => array(
+						0 => array('term' =>  array('ISO' => 400)),
+						1 => array('range' => array(
 							'AspectRatio' => array(
 								'gte' => '0.9',
 								'lt' => '1.2'
@@ -525,7 +525,7 @@ 
 		$expected['query']['filtered']['query']['multi_match'] = array(
 			'query' => 'New Zealand',
 			'lenient' => true,
-			'fields' => array('Title^2', 'Title.*^2','Content', 'Content.*'),
+			'fields' => array('Title^2', 'Title.*^2', 'Content', 'Content.*'),
 			'type' => 'most_fields'
 		);
 		$expected['suggest'] = $this->getDefaultSuggest('New Zealand');
@@ -553,14 +553,14 @@ 
 			'query' => array(
 				'filtered' => array('filter' =>
 					array('and' => array(
-						0 => array( 'term' =>  array('ISO' => 400)),
-						1 => array( 'range' => array(
+						0 => array('term' =>  array('ISO' => 400)),
+						1 => array('range' => array(
 							'AspectRatio' => array(
 								'gte' => '0.9',
 								'lt' => '1.2'
 							)
 						)),
-						2 => array( 'term' =>  array('Aperture' => 5.6)),
+						2 => array('term' =>  array('Aperture' => 5.6)),
 					)
 				))
 			),
@@ -575,7 +575,7 @@ 
 		$expected['query']['filtered']['query']['multi_match'] = array(
 			'query' => 'New Zealand',
 			'lenient' => true,
-			'fields' => array('Title^2', 'Title.*^2','Content', 'Content.*'),
+			'fields' => array('Title^2', 'Title.*^2', 'Content', 'Content.*'),
 			'type' => 'most_fields'
 		);
 		$expected['suggest'] = $this->getDefaultSuggest('New Zealand');
@@ -590,7 +590,7 @@ 
 		$qg = new QueryGenerator();
 		$qg->setClasses('FlickrPhotoTO');
 		$fields = array('Title' => 1, 'Description' => 1);
-		$expected = array('Title', 'Title.*','Description', 'Description.*');
+		$expected = array('Title', 'Title.*', 'Description', 'Description.*');
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 	}
 
@@ -599,7 +599,7 @@ 
 		$qg = new QueryGenerator();
 		$qg->setClasses('FlickrPhotoTO');
 		$fields = array('Title' => 2, 'Description' => 1);
-		$expected = array('Title^2', 'Title.*^2','Description', 'Description.*');
+		$expected = array('Title^2', 'Title.*^2', 'Description', 'Description.*');
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 	}
 
@@ -631,10 +631,10 @@ 
 		$qg = new QueryGenerator();
 		$qg->setClasses('FlickrPhotoTO,Page');
 		$fields = array('Title' => 2, 'Description' => 1);
-		$expected = array('Title^2', 'Title.*^2','Description', 'Description.*');
+		$expected = array('Title^2', 'Title.*^2', 'Description', 'Description.*');
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 
-		$qg->setClasses(array('FlickrPhotoTO','Page'));
+		$qg->setClasses(array('FlickrPhotoTO', 'Page'));
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 
 	}
@@ -648,7 +648,7 @@ 
 		$qg = new QueryGenerator();
 		$qg->setClasses('FlickrPhotoTO,Page');
 		$fields = array('Title' => 2, 'Description' => 1);
-		$expected = array('Title^2', 'Title.*^2','Description', 'Description.*');
+		$expected = array('Title^2', 'Title.*^2', 'Description', 'Description.*');
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 
 		//Execute a 2nd time
@@ -667,11 +667,11 @@ 
 		$qg = new QueryGenerator();
 		$qg->setClasses(null); // select all of site tree classes
 		$fields = array('Title' => 2, 'Content' => 1);
-		$expected = array('Title^2', 'Title.*^2','Content', 'Content.*');
+		$expected = array('Title^2', 'Title.*^2', 'Content', 'Content.*');
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 
 		echo "--------------------\n";
-		$qg->setClasses(array('FlickrPhotoTO','Page'));
+		$qg->setClasses(array('FlickrPhotoTO', 'Page'));
 		$this->assertEquals($expected, $qg->convertWeightedFieldsForElastica($fields));
 
 	}
@@ -720,21 +720,21 @@ 
 				'order' => array('_term' => 'asc')
 			)
 		);
-		$result['ShutterSpeed'] =  array(
+		$result['ShutterSpeed'] = array(
 			'terms' => array(
 				'field' => 'ShutterSpeed',
 				'size' => 0,
 				'order' => array('_term' => 'asc')
 			)
 		);
-		$result['FocalLength35mm'] =  array(
+		$result['FocalLength35mm'] = array(
 			'terms' => array(
 				'field' => 'FocalLength35mm',
 				'size' => 0,
 				'order' => array('_term' => 'asc')
 			)
 		);
-		$result['ISO'] =  array(
+		$result['ISO'] = array(
 			'terms' => array(
 				'field' => 'ISO',
 				'size' => 0,
@@ -749,7 +749,7 @@ 
 		$ranges[3] = array('from' => '1.2', 'to' => '1.79', 'key' => 'Vertical');
 		$ranges[4] = array('from' => '1.79', 'to' => '10000000', 'key' => 'Tallest');
 
-		$result['Aspect'] =  array(
+		$result['Aspect'] = array(
 			'range' => array(
 				'field' => 'AspectRatio',
 				'ranges' => $ranges
@@ -769,7 +769,7 @@ 
 
 	public function testToQuotedCSVFromArray() {
 		$expected = "'Bangkok','Nonthaburi','Saraburi','Chiang Mai'";
-		$items = array('Bangkok','Nonthaburi','Saraburi','Chiang Mai');
+		$items = array('Bangkok', 'Nonthaburi', 'Saraburi', 'Chiang Mai');
 		$quoted = QueryGenerator::convertToQuotedCSV($items);
 		$this->assertEquals($expected, $quoted);
 	}

tests/SearchableTest.php

Doc Comments +3 added lines

@@ -812,6 +812,9 @@
 	}
 
 
+	/**
+	 * @param string $query
+	 */
 	private function getResultsFor($query, $pageLength = 10) {
 		$es = new ElasticSearcher();
 		$es->setStart(0);

Indentation +3 added lines, -3 removed lines

@@ -553,10 +553,10 @@
 		print_r($sr);
 
 
-    	//$sr2 = array('Photographer', 'FlickrTagTOs', 'FlickrSetTOs');
+		//$sr2 = array('Photographer', 'FlickrTagTOs', 'FlickrSetTOs');
 
-    	// MUST REMOVE FIRST.  Otherwise append and the erroroneus value above still exists
-    	$config->remove('FlickrPhotoTO', 'searchable_relationships');
+		// MUST REMOVE FIRST.  Otherwise append and the erroroneus value above still exists
+		$config->remove('FlickrPhotoTO', 'searchable_relationships');
 		$config->update('FlickrPhotoTO' ,'searchable_relationships', $sr);
 	}
 

Spacing +27 added lines, -27 removed lines

@@ -13,7 +13,7 @@ 
 	public function setUp() {
 		// this needs to be called in order to create the list of searchable
 		// classes and fields that are available.  Simulates part of a build
-		$classes = array('SearchableTestPage','SiteTree','Page','FlickrPhotoTO','FlickrSetTO',
+		$classes = array('SearchableTestPage', 'SiteTree', 'Page', 'FlickrPhotoTO', 'FlickrSetTO',
 			'FlickrTagTO', 'FlickrAuthorTO', 'FlickrSetTO');
 		$this->requireDefaultRecordsFrom = $classes;
 
@@ -188,15 +188,15 @@ 
 
 
 		// check strings
-		$shouldBeString = array('Title','Description');
-		$shouldBeInt = array('ISO','FlickrID','FocalLength35mm');
+		$shouldBeString = array('Title', 'Description');
+		$shouldBeInt = array('ISO', 'FlickrID', 'FocalLength35mm');
 		$shouldBeBoolean = array('IsInSiteTree');
 		$shouldBeDouble = array('Aperture');
 		$shouldBeDateTime = array('TakenAt');
 		$shouldBeDate = array('FirstViewed');
 
 		// tokens are strings that have analyzer 'not_analyzed', namely the string is indexed as is
-		$shouldBeTokens = array('ShutterSpeed','Link');
+		$shouldBeTokens = array('ShutterSpeed', 'Link');
 
 
 		// check strings
@@ -213,7 +213,7 @@ 
 
 			// check for unstemmed analaysis
 
-			$this->assertEquals($expectedStandardArray,$fieldProperties['fields']['standard']);
+			$this->assertEquals($expectedStandardArray, $fieldProperties['fields']['standard']);
 
 			// check for only 3 entries
 			$this->assertEquals(4, sizeof(array_keys($fieldProperties)));
@@ -224,7 +224,7 @@ 
 			$fieldProperties = $properties[$fieldName];
 			$type = $fieldProperties['type'];
 			$this->assertEquals(1, sizeof(array_keys($fieldProperties)));
-			$this->assertEquals('integer',$type);
+			$this->assertEquals('integer', $type);
 		}
 
 
@@ -233,7 +233,7 @@ 
 			$fieldProperties = $properties[$fieldName];
 			$type = $fieldProperties['type'];
 			$this->assertEquals(1, sizeof(array_keys($fieldProperties)));
-			$this->assertEquals('double',$type);
+			$this->assertEquals('double', $type);
 		}
 
 		// check boolean
@@ -241,7 +241,7 @@ 
 			$fieldProperties = $properties[$fieldName];
 			$type = $fieldProperties['type'];
 			$this->assertEquals(1, sizeof(array_keys($fieldProperties)));
-			$this->assertEquals('boolean',$type);
+			$this->assertEquals('boolean', $type);
 		}
 
 
@@ -249,7 +249,7 @@ 
 			$fieldProperties = $properties[$fieldName];
 			$type = $fieldProperties['type'];
 			$this->assertEquals(2, sizeof(array_keys($fieldProperties)));
-			$this->assertEquals('date',$type);
+			$this->assertEquals('date', $type);
 			$this->assertEquals('y-M-d', $fieldProperties['format']);
 		}
 
@@ -260,7 +260,7 @@ 
 			$fieldProperties = $properties[$fieldName];
 			$type = $fieldProperties['type'];
 			$this->assertEquals(2, sizeof(array_keys($fieldProperties)));
-			$this->assertEquals('date',$type);
+			$this->assertEquals('date', $type);
 			$this->assertEquals('y-M-d H:m:s', $fieldProperties['format']);
 		}
 
@@ -299,7 +299,7 @@ 
 		$doc = $flickrPhoto->getElasticaDocument()->getData();
 
 		$expected = array();
-		$expected['Title'] = 'Bangkok' ;
+		$expected['Title'] = 'Bangkok';
 		$expected['FlickrID'] = '1234567';
 		$expected['Description'] = 'Test photograph';
 		$expected['TakenAt'] = '2011-07-04 20:36:00';
@@ -388,7 +388,7 @@ 
 		$page = $this->objFromFixture('SiteTree', 'sitetree001');
 		$page->doUnpublish();
 
-		$this->checkNumberOfIndexedDocuments($nDocsAtStart-1);
+		$this->checkNumberOfIndexedDocuments($nDocsAtStart - 1);
 
 		$page->doPublish();
 		$this->checkNumberOfIndexedDocuments($nDocsAtStart);
@@ -481,7 +481,7 @@ 
 		$flickrPhoto = $this->objFromFixture('FlickrPhotoTO', 'photo0001');
 		$fields = $flickrPhoto->getCMSFields();
 
-		$tab = $this->checkTabExists($fields,'ElasticaTermsset');
+		$tab = $this->checkTabExists($fields, 'ElasticaTermsset');
 	}
 
 
@@ -497,7 +497,7 @@ 
 			$this->assertEquals('The field $searchable_fields must be set for the class FlickrPhotoTO', $e->getMessage());
 		}
 
-		$config->update('FlickrPhotoTO' ,'searchable_fields', $sf);
+		$config->update('FlickrPhotoTO', 'searchable_fields', $sf);
 	}
 
 
@@ -513,7 +513,7 @@ 
 			$this->assertEquals('The field $searchable_fields must be set for the class FlickrTagTO', $e->getMessage());
 		}
 
-		$config->update('FlickrTagTO' ,'searchable_fields', $sf);
+		$config->update('FlickrTagTO', 'searchable_fields', $sf);
 
 	}
 
@@ -530,7 +530,7 @@ 
 			$this->assertEquals('The field $searchable_fields must be set for the class FlickrAuthorTO', $e->getMessage());
 		}
 
-		$config->update('FlickrAuthorTO' ,'searchable_fields', $sf);
+		$config->update('FlickrAuthorTO', 'searchable_fields', $sf);
 
 	}
 
@@ -539,7 +539,7 @@ 
 		$config = Config::inst();
 		$sr = $config->get('FlickrPhotoTO', 'searchable_relationships');
 		$config->remove('FlickrPhotoTO', 'searchable_relationships');
-		$config->update('FlickrPhotoTO', 'searchable_relationships',array('thisMethodDoesNotExist'));
+		$config->update('FlickrPhotoTO', 'searchable_relationships', array('thisMethodDoesNotExist'));
 		$fp = Injector::inst()->create('FlickrPhotoTO');
 		try {
 			$fields = $fp->getAllSearchableFields();
@@ -557,7 +557,7 @@ 
 
     	// MUST REMOVE FIRST.  Otherwise append and the erroroneus value above still exists
     	$config->remove('FlickrPhotoTO', 'searchable_relationships');
-		$config->update('FlickrPhotoTO' ,'searchable_relationships', $sr);
+		$config->update('FlickrPhotoTO', 'searchable_relationships', $sr);
 	}
 
 
@@ -669,9 +669,9 @@ 
 
 		$photographer->write();
 
-		$flickrPhoto->PhotographerID = $photographer->ID;;
+		$flickrPhoto->PhotographerID = $photographer->ID; ;
 		$flickrPhoto->write();
-		echo 'ID='.$flickrPhoto->PhotographerID;
+		echo 'ID=' . $flickrPhoto->PhotographerID;
 		$a = $flickrPhoto->getFieldValuesAsArray();
 
 		print_r($a);
@@ -718,7 +718,7 @@ 
 
 
 		$flickrPhoto->write();
-		echo 'ID='.$flickrPhoto->PhotographerID;
+		echo 'ID=' . $flickrPhoto->PhotographerID;
 		$a = $flickrPhoto->getFieldValuesAsArray();
 
 		print_r($a);
@@ -766,15 +766,15 @@ 
 			foreach ($tab->FieldList() as $field) {
 				array_push($tabFields, $field->getName());
 			}
-			$expectedName = 'TermsFor'.$tab->getName();;
+			$expectedName = 'TermsFor' . $tab->getName(); ;
 			$expected = array($expectedName);
 			$this->assertEquals($expected, $tabFields);
 			array_push($tabNames, $tab->getName());
 		}
-		$expected = array('Description','Description_shingles','Description_standard',
-			'ShutterSpeed',  'TestMethod', 'TestMethod_shingles', 'TestMethod_standard',
+		$expected = array('Description', 'Description_shingles', 'Description_standard',
+			'ShutterSpeed', 'TestMethod', 'TestMethod_shingles', 'TestMethod_standard',
 			'TestMethodHTML', 'TestMethodHTML_shingles', 'TestMethodHTML_standard',
-			'Title','Title_autocomplete','Title_shingles','Title_standard');
+			'Title', 'Title_autocomplete', 'Title_shingles', 'Title_standard');
 
 		$this->assertEquals($expected, $tabNames);
 	}
@@ -798,13 +798,13 @@ 
 			foreach ($tab->FieldList() as $field) {
 				array_push($tabFields, $field->getName());
 			}
-			$expectedName = 'TermsFor'.$tab->getName();;
+			$expectedName = 'TermsFor' . $tab->getName(); ;
 			$expected = array($expectedName);
 			$this->assertEquals($expected, $tabFields);
 			array_push($tabNames, $tab->getName());
 		}
 		$expected = array(
-			'Content','Content_standard','Link','Title','Title_autocomplete','Title_shingles',
+			'Content', 'Content_standard', 'Link', 'Title', 'Title_autocomplete', 'Title_shingles',
 			'Title_standard');
 		$this->generateAssertionsFromArray1D($tabNames);
 		$this->assertEquals($expected, $tabNames);

tests/SearchAndIndexingTest.php

Doc Comments +3 added lines

@@ -479,6 +479,9 @@
 	}
 
 
+	/**
+	 * @param string $query
+	 */
 	private function getResultsFor($query, $pageLength = 10, $fields = array('Title' => 1, 'Description' => 1)) {
 		$es = new ElasticSearcher();
 		$es->setStart(0);

Indentation +1 added lines, -1 removed lines

@@ -140,7 +140,7 @@
 
 	public function testEach() {
 		$callback = function($fp) {
-		    $this->assertTrue(true, 'Callback reached');
+			$this->assertTrue(true, 'Callback reached');
 		};
 		$resultList = $this->getResultsFor('New Zealand',10);
 		$resultList->each($callback);

Spacing +37 added lines, -37 removed lines

@@ -43,16 +43,16 @@ 
 		$stopwords = "a,the,then,this";
 		$englishIndex = new EnglishIndexSettings();
 		$englishIndex->setStopwords($stopwords);
-		$expected = array('a','the','then','this');
+		$expected = array('a', 'the', 'then', 'this');
 		$this->assertEquals($expected, $englishIndex->getStopwords());
 	}
 
 
 	public function testSetStopwordsConfigurationArray() {
-		$stopwords = array('a','the','then','this');
+		$stopwords = array('a', 'the', 'then', 'this');
 		$englishIndex = new EnglishIndexSettings();
 		$englishIndex->setStopwords($stopwords);
-		$expected = array('a','the','then','this');
+		$expected = array('a', 'the', 'then', 'this');
 		$this->assertEquals($expected, $englishIndex->getStopwords());
 	}
 
@@ -92,9 +92,9 @@ 
 			'ISO' => 1
 		);
 
-		$expected = array('that','into','a','an','and','are','as','at','be','but','by','for','if',
-			'in','into','is','it','of','on','or','such','that','the','their','then','there','these',
-			'they','this','to','was','will','with');
+		$expected = array('that', 'into', 'a', 'an', 'and', 'are', 'as', 'at', 'be', 'but', 'by', 'for', 'if',
+			'in', 'into', 'is', 'it', 'of', 'on', 'or', 'such', 'that', 'the', 'their', 'then', 'there', 'these',
+			'they', 'this', 'to', 'was', 'will', 'with');
 		$this->assertEquals($expected, $stopwords);
 	}
 
@@ -106,7 +106,7 @@ 
 
 
 	public function testResultListGetMap() {
-		$resultList = $this->getResultsFor('New Zealand',10);
+		$resultList = $this->getResultsFor('New Zealand', 10);
 		//default is ID -> Title, useful for dropdowns
 		$mapping = $resultList->map();
 		$ctr = 0;
@@ -119,7 +119,7 @@ 
 
 
 	public function testResultListColumn() {
-		$resultList = $this->getResultsFor('New Zealand',10);
+		$resultList = $this->getResultsFor('New Zealand', 10);
 		$ids = $resultList->column();
 
 		$expected = array();
@@ -127,14 +127,14 @@ 
 			array_push($expected, $item->ID);
 		}
 
-		$this->assertEquals($expected,$ids);
+		$this->assertEquals($expected, $ids);
 
 		$expected = array();
 		foreach ($resultList as $item) {
 			array_push($expected, $item->Title);
 		}
 		$titles = $resultList->column('Title');
-		$this->assertEquals($expected,$titles);
+		$this->assertEquals($expected, $titles);
 	}
 
 
@@ -142,7 +142,7 @@ 
 		$callback = function($fp) {
 		    $this->assertTrue(true, 'Callback reached');
 		};
-		$resultList = $this->getResultsFor('New Zealand',10);
+		$resultList = $this->getResultsFor('New Zealand', 10);
 		$resultList->each($callback);
 	}
 
@@ -152,22 +152,22 @@ 
 	that all of the fixtures should have 'New Zealand' in them.  Test page length from 1 to 100
 	 */
 	public function testResultListPageLength() {
-		for ($i=1; $i <= 100 ; $i++) {
-			$resultList = $this->getResultsFor('New Zealand',$i);
+		for ($i = 1; $i <= 100; $i++) {
+			$resultList = $this->getResultsFor('New Zealand', $i);
 			$this->assertEquals($i, $resultList->count());
 		}
 	}
 
 
 	public function testResultListIndex() {
-		$resultList = $this->getResultsFor('New Zealand',10);
+		$resultList = $this->getResultsFor('New Zealand', 10);
 		$index = $resultList->getService()->getIndex();
 		$this->assertEquals('elastica_ss_module_test_en_us', $index->getName());
 	}
 
 
 	public function testResultListGetQuery() {
-		$resultList = $this->getResultsFor('New Zealand',10);
+		$resultList = $this->getResultsFor('New Zealand', 10);
 		$query = $resultList->getQuery()->toArray();
 
 		$expected = array();
@@ -192,7 +192,7 @@ 
 	Check that the time for the search was more than zero
 	 */
 	public function testResultListGetTotalTime() {
-		$resultList = $this->getResultsFor('New Zealand',10);
+		$resultList = $this->getResultsFor('New Zealand', 10);
 		$time = $resultList->getTotalTime();
 		$this->assertGreaterThan(0, $time);
 	}
@@ -202,12 +202,12 @@ 
 	Test the result list iterator function
 	 */
 	public function testResultListGetIterator() {
-		$resultList = $this->getResultsFor('New Zealand',100);
+		$resultList = $this->getResultsFor('New Zealand', 100);
 		$ctr = 0;
 		foreach ($resultList->getIterator() as $result) {
 			$ctr++;
 		}
-		$this->assertEquals(100,$ctr);
+		$this->assertEquals(100, $ctr);
 	}
 
 
@@ -215,15 +215,15 @@ 
 	Check some basic properties of the array returned for a result
 	 */
 	public function testToArrayFunction() {
-		$resultList = $this->getResultsFor('New Zealand',1);
+		$resultList = $this->getResultsFor('New Zealand', 1);
 		$expected = array();
 		$result = $resultList->toArray();
 
-		$this->assertEquals(1,sizeof($result));
+		$this->assertEquals(1, sizeof($result));
 		$fp = $result[0];
 		$this->assertEquals('FlickrPhotoTO', $fp->ClassName);
 		$this->assertEquals(2147483647, $fp->FlickrID);
-		$this->assertTrue(preg_match('/New Zealand/',$fp->Title) == 1);
+		$this->assertTrue(preg_match('/New Zealand/', $fp->Title) == 1);
 	}
 
 
@@ -231,21 +231,21 @@ 
 	Check some basic properties of the array returned for a result
 	 */
 	public function testToNestedArrayFunction() {
-		$resultList = $this->getResultsFor('New Zealand',4);
+		$resultList = $this->getResultsFor('New Zealand', 4);
 		$expected = array();
 		$result = $resultList->toNestedArray();
 
-		$this->assertEquals(4,sizeof($result));
+		$this->assertEquals(4, sizeof($result));
 		$fp = $result[0];
 		$this->assertEquals('FlickrPhotoTO', $fp['ClassName']);
 		$this->assertEquals(2147483647, $fp['FlickrID']);
-		$this->assertTrue(preg_match('/New Zealand/',$fp['Title']) == 1);
+		$this->assertTrue(preg_match('/New Zealand/', $fp['Title']) == 1);
 	}
 
 
 	public function testResultListOffsetExistsNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$resultList->offsetExists(10);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
@@ -256,7 +256,7 @@ 
 
 	public function testResultListOffsetGetNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$resultList->offsetGet(10);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
@@ -267,8 +267,8 @@ 
 
 	public function testResultListOffsetSetNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
-			$resultList->offsetSet(10,null);
+			$resultList = $this->getResultsFor('New Zealand', 10);
+			$resultList->offsetSet(10, null);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
 			$this->assertEquals('Not implemented', $e->getMessage());
@@ -278,7 +278,7 @@ 
 
 	public function testResultListOffsetUnsetNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$resultList->offsetUnset(10);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
@@ -289,7 +289,7 @@ 
 
 	public function testResultListAddNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$fp = new FlickrPhotoTO();
 			$resultList->add($fp);
 			$this->assertFalse(true, "This line should not have been reached");
@@ -301,7 +301,7 @@ 
 
 	public function testResultListRemoveNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$fp = new FlickrPhotoTO();
 			$resultList->remove($fp);
 			$this->assertFalse(true, "This line should not have been reached");
@@ -313,9 +313,9 @@ 
 
 	public function testResultListFindNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$fp = new FlickrPhotoTO();
-			$resultList->find(4,$fp);
+			$resultList->find(4, $fp);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
 			$this->assertEquals('Not implemented', $e->getMessage());
@@ -351,9 +351,9 @@ 
 
 	public function testResultListFirstNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$fp = new FlickrPhotoTO();
-			$resultList->first(4,$fp);
+			$resultList->first(4, $fp);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
 			$this->assertEquals('Not implemented', $e->getMessage());
@@ -363,9 +363,9 @@ 
 
 	public function testResultListLastNotImplemented() {
 		try {
-			$resultList = $this->getResultsFor('New Zealand',10);
+			$resultList = $this->getResultsFor('New Zealand', 10);
 			$fp = new FlickrPhotoTO();
-			$resultList->last(4,$fp);
+			$resultList->last(4, $fp);
 			$this->assertFalse(true, "This line should not have been reached");
 		} catch (Exception $e) {
 			$this->assertEquals('Not implemented', $e->getMessage());

tests/TranslatableUnitTest.php

Doc Comments +3 added lines

@@ -233,6 +233,9 @@
 
 
 
+	/**
+	 * @param PaginatedList $paginated
+	 */
 	private function makeCode($paginated) {
 		$results = $paginated->getList()->toArray();
 		$ctr = 0;

Spacing +10 added lines, -10 removed lines

@@ -20,7 +20,7 @@ 
 		$form = new \ElasticSearchForm(new \Controller(), 'TestForm');
 		$fields = $form->Fields();
 		$result = array();
-		foreach($fields as $field) {
+		foreach ($fields as $field) {
 			echo $field->getName();
 			$result[$field->getName()] = $field->Value();
 		}
@@ -51,12 +51,12 @@ 
 				$wordFound = false;
 				$lcquery = explode(' ', strtolower($query));
 				foreach ($lcquery as $part) {
-					$bracketed = '<strong class="hl">'.$part.'</strong>';
+					$bracketed = '<strong class="hl">' . $part . '</strong>';
 					if (strpos($snippet, $bracketed) > 0) {
 						$wordFound = true;
 					}
 				}
-				$this->assertTrue($wordFound,'Highlight should have been found');
+				$this->assertTrue($wordFound, 'Highlight should have been found');
 			}
 		}
 	}
@@ -89,7 +89,7 @@ 
 		$es->setLocale($locale);
 		$es->setClasses('FlickrPhotoTO');
 
-		$fields = array('Description.standard' => 1,'Title.standard' => 1);
+		$fields = array('Description.standard' => 1, 'Title.standard' => 1);
 		$results = $es->moreLikeThis($fp, $fields, true);
 
 		echo "RESULTS:\n";
@@ -110,7 +110,7 @@ 
 		$expected = array('texas');
 		$this->assertEquals($expected, $terms['Title.standard']);
 
-		$expected = array('new', 'see','photographs', 'information','resolution', 'company', 'view',
+		$expected = array('new', 'see', 'photographs', 'information', 'resolution', 'company', 'view',
 			'high', 'collection', 'pacific', 'orleans', 'degolyer', 'southern', 'everett',
 			'railroad', 'texas');
 
@@ -144,7 +144,7 @@ 
 		$fields = array('Title.standard' => 1, 'Description.standard' => 1);
 		$paginated = $es->moreLikeThis($fp, $fields, true);
 		foreach ($paginated->getList() as $result) {
-			echo $result->ID. ' : '.$result->Title."\n";
+			echo $result->ID . ' : ' . $result->Title . "\n";
 		}
 		$this->assertEquals(32, $paginated->getTotalItems());
 		$results = $paginated->getList()->toArray();
@@ -179,7 +179,7 @@ 
 		//Check that the number of indexing requests has increased by 2
 		$deltaReqs = $this->service->getIndexingRequestCtr() - $reqs;
 		//One call is made for each of Page and FlickrPhotoTO
-		$this->assertEquals(2,$deltaReqs);
+		$this->assertEquals(2, $deltaReqs);
 
 		// default installed pages plus 100 FlickrPhotoTOs
 		$this->checkNumberOfIndexedDocuments(103);
@@ -195,7 +195,7 @@ 
 		$fields = array('Title.standard' => 1, 'Description.standard' => 1);
 		$paginated = $es->moreLikeThis($fp, $fields, true);
 		foreach ($paginated->getList() as $result) {
-			echo $result->ID. ' : '.$result->Title."\n";
+			echo $result->ID . ' : ' . $result->Title . "\n";
 		}
 		$this->assertEquals(14, $paginated->getTotalItems());
 		$results = $paginated->getList()->toArray();
@@ -236,9 +236,9 @@ 
 	private function makeCode($paginated) {
 		$results = $paginated->getList()->toArray();
 		$ctr = 0;
-		echo '$result = $paginated->getList()->toArray();'."\n";
+		echo '$result = $paginated->getList()->toArray();' . "\n";
 		foreach ($results as $result) {
-			echo '$this->assertEquals("'.$result->Title.'", $results['.$ctr.']->Title);'."\n";
+			echo '$this->assertEquals("' . $result->Title . '", $results[' . $ctr . ']->Title);' . "\n";
 			$ctr++;
 		}
 	}

code/SearchableClass.php

Indentation +12 added lines, -12 removed lines

@@ -29,20 +29,20 @@ 
 		$config->removeComponent($config->getComponentByType('GridFieldDeleteAction'));
 
 		$config->getComponentByType('GridFieldDataColumns')->setDisplayFields(array(
-            'Name' => 'Name',
-            'Weight' => 'Weighting',
-            'Searchable' => 'Search this field?'
-        ));
+			'Name' => 'Name',
+			'Weight' => 'Weighting',
+			'Searchable' => 'Search this field?'
+		));
 
 
-        $gridField = new GridField(
-            'SearchableField', // Field name
-            'Field Name', // Field title
-            SearchableField::get()->filter('SearchableClassID', $this->ID)->sort('Name'),
-            $config
-        );
+		$gridField = new GridField(
+			'SearchableField', // Field name
+			'Field Name', // Field title
+			SearchableField::get()->filter('SearchableClassID', $this->ID)->sort('Name'),
+			$config
+		);
 
-        $fields->addFieldToTab('Root.Main', $gridField);
+		$fields->addFieldToTab('Root.Main', $gridField);
 
 		/*
 	    $fields = new FieldList();
@@ -50,7 +50,7 @@ 
 
 
         */
-	    return $fields;
+		return $fields;
 	}
 
 

Spacing +3 added lines, -3 removed lines

@@ -15,10 +15,10 @@
 
 		$fields = new FieldList();
 
-		$fields->push( new TabSet( "Root", $mainTab = new Tab( "Main" ) ) );
-		$mainTab->setTitle( _t( 'SiteTree.TABMAIN', "Main" ) );
+		$fields->push(new TabSet("Root", $mainTab = new Tab("Main")));
+		$mainTab->setTitle(_t('SiteTree.TABMAIN', "Main"));
 
-		$fields->addFieldToTab( 'Root.Main',  $nf = new TextField( 'Name', 'Name') );
+		$fields->addFieldToTab('Root.Main', $nf = new TextField('Name', 'Name'));
 		$nf->setReadOnly(true);
 		$nf->setDisabled(true);
 

code/SearchableField.php

Spacing +4 added lines, -4 removed lines

@@ -24,10 +24,10 @@
 
 	function getCMSFields() {
 		$fields = new FieldList();
-		$fields->push( new TabSet( "Root", $mainTab = new Tab( "Main" ) ) );
-		$mainTab->setTitle( _t( 'SiteTree.TABMAIN', "Main" ) );
-		$fields->addFieldToTab( 'Root.Main',  $cf = new TextField( 'ClazzName', 'Class sourced from') );
-		$fields->addFieldToTab( 'Root.Main',  $nf = new TextField( 'Name', 'Name') );
+		$fields->push(new TabSet("Root", $mainTab = new Tab("Main")));
+		$mainTab->setTitle(_t('SiteTree.TABMAIN', "Main"));
+		$fields->addFieldToTab('Root.Main', $cf = new TextField('ClazzName', 'Class sourced from'));
+		$fields->addFieldToTab('Root.Main', $nf = new TextField('Name', 'Name'));
 		$cf->setDisabled(true);
 		$nf->setDisabled(true);
 		$cf->setReadOnly(true);