ElasticSearchPage_Validator

Complexity

Total Complexity

11

Size/Duplication

Total Lines	81
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	3

Test Coverage

Coverage

0%

2 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
C	php()	0	67	10

<?php

class ElasticSearchPage_Validator extends RequiredFields {

This class is not in CamelCase format.

	protected $customRequired = array('Name');

	/**
	 * Constructor
	 */
	public function __construct() {
		$required = array('ResultsPerPage', 'Identifier');

		parent::__construct($required);
	}

	function php($data) {

It is generally recommended to explicitly declare the visibility for methods.

		parent::php($data);
		$valid = true;

$valid is not used, you could remove the assignment.

		//Debug::message("Validating data: " . print_r($data, true));

59% of this comment could be valid code. Did you maybe forget this after debugging?

		$valid = parent::php($data);
		//Debug::message("Returning false, just to check");

72% of this comment could be valid code. Did you maybe forget this after debugging?

		//return false;
		//

		if ($data['ClassesToSearch'] == array()) {
			$data['ClassesToSearch'] = '';
		}
		$debug = $data['SiteTreeOnly'];

$debug is not used, you could remove the assignment.

		// Check if any classes to search if site tree only is not ticked
		if (!$data['SiteTreeOnly']) {
			if (!$data['ClassesToSearch']) {
				$valid = false;
				$this->validationError("ClassesToSearch",
					"Please provide at least one class to search, or select 'Site Tree Only'",
					'error'
				);
			} else {
				$toSearch = $data['ClassesToSearch'];
				foreach ($toSearch as $clazz) {
					try {
						$instance = Injector::inst()->create($clazz);
						if (!$instance->hasExtension('SilverStripe\Elastica\Searchable')) {
							$this->validationError('ClassesToSearch', 'The class '.$clazz.' must have the Searchable extension');
						}
					} catch (ReflectionException $e) {
						$this->validationError("ClassesToSearch",
							'The class '.$clazz.' does not exist',
							'error'
						);
					}
				}
			}
		}


		// Check the identifier is unique
		$mode = Versioned::get_reading_mode();
		$suffix =  '';
		if ($mode == 'Stage.Live') {
			$suffix = '_Live';
		}
		$where = 'ElasticSearchPage'.$suffix.'.ID != '.$data['ID']." AND `Identifier` = '".$data['Identifier']."'";
		$existing = ElasticSearchPage::get()->where($where)->count();
		if ($existing > 0) {
			$valid = false;
			$this->validationError('Identifier',
					'The identifier '.$data['Identifier'].' already exists',
					'error'
			);
		}


		// Check number of results per page >= 1
		if ($data['ResultsPerPage'] <= 0) {
			$valid = false;
			$this->validationError('ResultsPerPage',
				'Results per page must be >=1'
				,'error'
			);
		}
		return $valid;
	}
}