PageWithImage

Complexity

Total Complexity

12

Size/Duplication

Total Lines	75
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	5

Test Coverage

Coverage

0%

10 Methods

Rating	Name	Duplication	Size	Complexity
A	getOGImage()	0	3	1
A	getCMSFields()	0	10	1
A	getPortletTitle()	0	3	1
A	getPortletImage()	0	3	1
A	getPortletCaption()	0	3	1
A	getTwitterTitle()	0	3	1
A	getTwitterImage()	0	3	1
A	getTwitterDescription()	0	3	1
A	getImagesForSeo()	0	8	2
A	getLinksForSeo()	0	7	2

<?php
/**
* Defines the SupportingProjectPage page type - initial code created by ss generator
*/
class PageWithImage extends Page implements RenderableAsPortlet, RenderableAsTwitterCard, SeoInformationProvider {

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

	// Brief summary to show on facebook and twitter when linking
	private static $db = array(

The property $db is not used and could be removed.

		'ImageAttribution' => 'Varchar(255)',
		'BriefIntroduction' => 'HTMLText'
	);


	static $has_one = array(

The visibility should be declared for property $has_one.

		'MainImage' => 'Image'
	);


	// for rendering thumbnail when linked in facebook
	function getOGImage() {

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for getOGImage.

		return $this->MainImage();
	}


	function getCMSFields() {

It is generally recommended to explicitly declare the visibility for methods.

It is recommend to declare an explicit visibility for getCMSFields.

		$fields = parent::getCMSFields();
		$imagename = _t('PageWithImage.IMAGE', 'Image');
		$fields->addFieldToTab( 'Root.'.$imagename, $uf = new UploadField('MainImage', _t('PageWithImage.MAIN_IMAGE', 'Main Image')));
		$dirname = strtolower($this->ClassName).'s';
		$uf->setFolderName($dirname);
		$fields->addFieldToTab('Root.'.$imagename, new TextField('ImageAttribution', 'Image Credit'));
		$fields->addFieldToTab('Root', new TextAreaField('BriefIntroduction', 'Brief description of the page for Twitter and Facebook purposes'), 'Content');
		return $fields;
	}


	public function getPortletTitle() {
		return $this->Title;
	}

	public function getPortletImage() {
		return $this->MainImage();
	}

	public function getPortletCaption() {
		return $this->BriefIntroduction;
	}

	public function getTwitterTitle() {
		return $this->Title;
	}

	public function getTwitterImage() {
		return $this->MainImage();
	}

	public function getTwitterDescription() {
		return Convert::html2raw($this->BriefIntroduction);
	}

	public function getImagesForSeo() {
		$result = new ArrayList();
		$mainimage = $this->owner->MainImage();
		if ($mainimage) {
			$result->push($mainimage);
		}
		return $result;

The return type of return $result; (ArrayList) is incompatible with the return type declared by the interface SeoInformationProvider::getImagesForSeo of type DataList.

	}


	public function getLinksForSeo() {
		$result = false;
		if ($this->hasExtension('LinksExtension')) {
			$result = $this->Links();
		}
		return $result;
	}

}

class PageWithImage_Controller extends Page_Controller {

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

This class is not in CamelCase format.

}