gordonbanderson / facebook-tools

code/FacebookCredentials.php

<?php

//require_once "facebook.php";

class FacebookCredentials extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $db = array(
    'BulkTitle' => 'Varchar',
    'BulkCaption' => 'Varchar',
    'BulkCopyright' => 'Varchar',
    'BulkLicense' => 'Varchar',
    'FacebookAlbumID' => 'Varchar',
  );

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

  // facebook information

  // the id of the facebook application
  protected static $facebook_application_id = null;

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

  // the secret of the facebook application
  protected static $facebook_application_secret = null;

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

  // user id to search
  protected static $facebook_user_id = null;

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

    public static $has_many = array(
    'AttachedFiles' => 'ImageFile',
  );

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

    public static $has_one = array(
      'CoverPhoto' => 'Image',
   );

It seems like the identation of this line is off (expected at least 4 spaces, but found 3).

  //Uncle Cheese hack from http://silverstripe.org/data-model-questions/show/6805 << to detect multiple calls to on after write or on before write
  public static $has_written = false;

It seems like the identation of this line is off (expected at least 4 spaces, but found 2).

    public function CanUseFacebook()

Method name "FacebookCredentials::CanUseFacebook" is not in camel caps format

    {
        $result = (self::$facebook_application_id != null);
        $result = $result && (self::$facebook_application_secret != null);
        $result = $result && (self::$facebook_user_id != null);

        return $result;
    }

    public static function setFacebookApplicationID($new_app_id)
    {
        return self::$facebook_application_id = $new_app_id;
    }

    public static function setFacebookApplicationSecret($new_sec)
    {
        return self::$facebook_application_secret = $new_sec;
    }

    public static function setFacebookUserID($new_user_id)
    {
        return self::$facebook_user_id = $new_user_id;
    }

    public static function getFacebookApplicationID()
    {
        $config = SiteConfig::current_site_config();

        return $config->getOGApplicationID();
    }

    public static function getFacebookApplicationSecret()
    {
        return self::$facebook_application_secret;
    }

    public static function getFacebookUserID()
    {
        $config = SiteConfig::current_site_config();

        return $config->getOGAdminID();
    }
}