gordonbanderson / Slider

code/SlidePage.php

<?php
/**
* Defines the StaffPage page type.
*/
class SlidePage extends Page

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

{
    public static $db = array(
        'Caption' => 'Text',
    );

    public static $has_one = array(
        'Photo' => 'Image',
        'InternalPage' => 'SiteTree',
    );

    public static $allowed_children = 'none';

    private static $defaults = array(

The property $defaults is not used and could be removed.

       'ShowInMenus' => false,
       'ShowInSearch' => false,
    );

    public function getThumbnail2()
    {
        return $this->InternalPage()->getPortletImage()->CMSThumbnail()->Tag;
    }

    public function getCMSFields()
    {
        Requirements::javascript('slider/javascript/slideredit.js');

        $fields = parent::getCMSFields();
        $existing_photo = null;
        $photo_field = null;

$photo_field is not used, you could remove the assignment.

        $internal_page = $this->InternalPage();

        if ($internal_page instanceof RenderableAsPortlet) {

The class RenderableAsPortlet does not exist. Did you forget a USE statement, or did you not list all dependencies?

            error_log('Class implements renderable as a portlet');
            $existing_photo = $this->InternalPage()->getPortletImage();
        } else {
            // check parents recursively
            $parents = class_parents($internal_page);
            error_log(print_r($parents, 1));
        }

        $fields->addFieldToTab('Root.Main',
            new TreeDropdownField('InternalPageID', _t('SlidePage.CHOOSE_INTERNAL_LINK', 'Select a page on the website to link to'), 'SiteTree'));

        $composite_photoField = null;

$composite_photoField is not used, you could remove the assignment.

        if (!$existing_photo) {
            $photo_field = new UploadField('Photo', _t('SlidePage.PHOTO', 'Photo'));
            $photo_info = new LiteralField('PhotoInfo', _t('Slide.PHOTO_INFO', 'If the page you choose to link to has an image already it will appear here'), 'Photo');

The call to LiteralField::__construct() has too many arguments starting with 'Photo'.

            $composite_photoField = CompositeField::create($photo_field, $photo_info);
        } else {
            // FIXME, find a cleaner way of doing this
            $composite_photoField = new LiteralField('Thumbnail2', '<div id="Thumbnail2" class="field readonly">
    <label class="left" for="Form_EditForm_Thumbnail2">Photo</label>
    <div class="middleColumn">
    <span id="Form_EditForm_Thumbnail2" class="readonly">
        <img src="'.$existing_photo->SetWidth(400)->URL.'" alt="'.$existing_photo->Title.'" />
    </span>
    </div>
</div>');
        }

        $composite_photoField->setTitle('Photo');
        $fields->addFieldToTab('Root.Main', $composite_photoField);
        $fields->addFieldToTab('Root.Main', new TextField('Caption', _t('SlidePage.CAPTION', 'Caption')));
        $fields->renameField('Title', 'Slide Title');

        $fields->removeFieldFromTab('Root.Main', 'Content');

        return $fields;
    }

    /*
    Accessible from templates as $PortletImage
    */
    public function getPortletImage()
    {
        $image = null;

$image is not used, you could remove the assignment.

        if ($this->InternalPage() instanceof RenderableAsPortlet) {

The class RenderableAsPortlet does not exist. Did you forget a USE statement, or did you not list all dependencies?

            $image = $this->InternalPage()->getPortletImage();
        } else {
            $image = $this->Photo();
        }

        return $image;
    }

    public function getThumbnail()
    {
        if ($Image = $this->Photo()) {
            return $Image->CMSThumbnail();
        } else {
            return '(No Image)';
        }
    }

    public function getWebsiteAddress()
    {
        $result = '#"';

        if ($this->InternalPageID) {
            $targetPage = DataObject::get_by_id('Page', $this->InternalPageID);
            if ($targetPage) {
                $result = $targetPage->Link();
            } else {
                $result = '#';
            }
        }

        return $result;
    }
}

class SlidePage_Controller extends Page_Controller

PSR1 recommends that each class should be in its own file to aid autoloaders.

PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions.

This class is not in CamelCase format.

{
    private static $allowed_actions = array('newpageselected' => true);

The property $allowed_actions is not used and could be removed.

    /*
    When a new item is selected return JSON containing the title and image
    */
    public function newpageselected(SS_HTTPRequest $request)
    {
        $sitetree_id = $request->param('ID');
        $page = SiteTree::get_by_id($sitetree_id);
        $result = array();
        if ($page) {
            $result['Title'] = $page->Title;
        }
        return json_encode($result);
    }
}