Issues in MappableDataTest.php (3.1) - Issues in 3.1 - gordonbanderson/Mappable - Measure and Improve Code Quality continuously with Scrutinizer

Issues (125)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/MappableDataTest.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class MappableDataTest extends SapphireTest
{
    public function setUpOnce()
    {
        $this->requiredExtensions = array(
            'Member' => array('MapExtension'),
        );

        parent::setupOnce();
    }

    public function setUp()
    {
        MapUtil::reset();
        parent::setUp();
    }

    public function testGetRenderableMapSetNoMarkerValues()
    {
        $instance = $this->getInstance();
        $instance->MapPinEdited = true;
        $html = $instance->getRenderableMap(300, 800, 2)->setDivId('testmap')->forTemplate()->getValue();

        $expected = <<<HTML


<div id="testmap" data-google-map-lang="en"  style="width:300; height: 800;"
 class=" mappable"
data-map
data-centre='{"lat":13.8188931,"lng":100.5005558}'
data-zoom=2
data-maptype='road'
data-allowfullscreen='1'
data-clusterergridsize=50,
data-clusterermaxzoom=17,
data-enableautocentrezoom=false
data-enablewindowzoom=false
data-infowindowzoom=13
data-mapmarkers='[{"latitude":13.8188931,"longitude":100.5005558,"html":"MEMBER: Test User","category":"default","icon":false}]'
data-defaulthidemarker=false
data-lines='[]'
data-kmlfiles='[]'
data-mapstyles='[]'
data-useclusterer=false
>
</div>

HTML;
        $this->assertEquals($expected, $html);
    }

    /**
     * The existenve of 'TestKeyVal' in the markers is the test here.
     *
     * FIXME: Leading blank space
     */
    public function testSetMarkerTemplateValues()
    {
        $instance = $this->getInstance();
        $instance->MapPinEdited = true;
        $vals = array('TestKey' => ' TestKeyVal');
        $instance->setMarkerTemplateValues($vals);
        $html = $instance->getRenderableMap(300, 800, 2)->setDivId('testmap')->forTemplate()->getValue();
        $expected = <<<HTML


<div id="testmap" data-google-map-lang="en"  style="width:300; height: 800;"
 class=" mappable"
data-map
data-centre='{"lat":13.8188931,"lng":100.5005558}'
data-zoom=2
data-maptype='road'
data-allowfullscreen='1'
data-clusterergridsize=50,
data-clusterermaxzoom=17,
data-enableautocentrezoom=false
data-enablewindowzoom=false
data-infowindowzoom=13
data-mapmarkers='[{"latitude":13.8188931,"longitude":100.5005558,"html":"MEMBER: Test User TestKeyVal","category":"default","icon":false}]'
data-defaulthidemarker=false
data-lines='[]'
data-kmlfiles='[]'
data-mapstyles='[]'
data-useclusterer=false
>
</div>

HTML;

        $this->assertEquals($expected, $html);
    }

    public function testStaticMapChangeLocation()
    {
        $instance = $this->getInstance();
        $instance->Lat = 13.84;
        $instance->Lon = 100.52;
        $html = $instance->StaticMap(300, 800);
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.84%2C100.52&amp;markers=13.84%2C100.52'
                  .'&amp;zoom=13&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=roadmap" width="300" height="800" alt="User" />';
        $this->assertEquals($expected, $html);
    }

    public function testStaticMapVarySize()
    {
        $instance = $this->getInstance();
        $instance->Lat = 13.8188931;
        $instance->Lon = 100.5005558;
        $html = $instance->StaticMap(300, 800);
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=13&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=roadmap" width="300" height="800" alt="User" />';
        $this->assertEquals($expected, $html);

        $html = $instance->StaticMap(310, 810);
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=13&amp;size=310x810&amp;sensor=false&amp;mapt'
                  .'ype=roadmap" width="310" height="810" alt="User" />';
        $this->assertEquals($expected, $html);
    }

    public function testStaticMapVaryTerrain()
    {
        $instance = $this->getInstance();
        $instance->Lat = 13.8188931;
        $instance->Lon = 100.5005558;
        $html = $instance->StaticMap(300, 800, null, 'satellite');
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=13&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=satellite" width="300" height="800" alt="User" />';
        $this->assertEquals($expected, $html);

        $html = $instance->StaticMap(300, 800, null, 'terrain');
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=13&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=terrain" width="300" height="800" alt="User" />';

        $html = $instance->StaticMap(300, 800, null, 'hybrid');
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=13&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=hybrid" width="300" height="800" alt="User" />';
        $this->assertEquals($expected, $html);
    }

    public function testStaticMapVaryZoom()
    {
        $instance = $this->getInstance();

        $html = $instance->StaticMap(300, 800, 2);
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=2&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=roadmap" width="300" height="800" alt="User" />';
        $this->assertEquals($expected, $html);

        $html = $instance->StaticMap(300, 800, 12);
        $expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
                  .'13.8188931%2C100.5005558&amp;markers=13.8188931%2C100.5005'
                  .'558&amp;zoom=12&amp;size=300x800&amp;sensor=false&amp;mapt'
                  .'ype=roadmap" width="300" height="800" alt="User" />';
        $this->assertEquals($expected, $html);
    }

    public function testStaticMapWithMapPin()
    {
        $instance = $this->getInstance();
        $this->addMapPinToInstance($instance);

        $html = $instance->StaticMap(300, 800, 2);

        $this->assertStringStartsWith('<img src="//maps.googleapis.com/maps/api/staticmap?center=13.8188931%2C100.5005558&amp;markers=icon%3A', $html);
        $this->assertStringEndsWith('%2Fassets%2Fmapicontest.png%7C13.8188931%2C100.5005558&amp;zoom=2&amp;size=300x800&amp;sensor=false&amp;maptype=roadmap" width="300" height="800" alt="User, Test" />', $html);
    }

    private function getInstance()

    {
        $instance = new Member();
        $instance->Lat = 13.8188931;
        $instance->Lon = 100.5005558;
        $instance->FirstName = 'Test';
        $instance->Surname = 'User';

        return $instance;
    }

    /**
     * @param Member $instance
     */
    private function addMapPinToInstance(&$instance)

    {
        // Create a pin
        $copied = copy('mappable/tests/images/mapicontest.png', 'assets/mapicontest.png');
        $this->assertTrue($copied);

        $imageFile = new Image(array('Name' => 'mapicontest.png', 'Filename' => 'assets/mapicontest.png'));
        $imageFile->write();
        $instance->MapPinIconID = $imageFile->ID;
        $instance->write();
    }
}


1			<?php
2
3			class MappableDataTest extends SapphireTest
4			{
5			public function setUpOnce()
6			{
7			$this->requiredExtensions = array(
8			'Member' => array('MapExtension'),
9			);
10
11			parent::setupOnce();
12			}
13
14	7		public function setUp()
15			{
16	7		MapUtil::reset();
17	7		parent::setUp();
18	7		}
19
20	1		public function testGetRenderableMapSetNoMarkerValues()
21			{
22	1		$instance = $this->getInstance();
23	1		$instance->MapPinEdited = true;
24	1		$html = $instance->getRenderableMap(300, 800, 2)->setDivId('testmap')->forTemplate()->getValue();
25
26			$expected = <<<HTML
27
28
29			<div id="testmap" data-google-map-lang="en" style="width:300; height: 800;"
30			class=" mappable"
31			data-map
32			data-centre='{"lat":13.8188931,"lng":100.5005558}'
33			data-zoom=2
34			data-maptype='road'
35			data-allowfullscreen='1'
36			data-clusterergridsize=50,
37			data-clusterermaxzoom=17,
38			data-enableautocentrezoom=false
39			data-enablewindowzoom=false
40			data-infowindowzoom=13
41			data-mapmarkers='[{"latitude":13.8188931,"longitude":100.5005558,"html":"MEMBER: Test User","category":"default","icon":false}]'
42			data-defaulthidemarker=false
43			data-lines='[]'
44			data-kmlfiles='[]'
45			data-mapstyles='[]'
46			data-useclusterer=false
47			>
48			</div>
49
50	1		HTML;
51	1		$this->assertEquals($expected, $html);
52	1		}
53
54			/**
55			* The existenve of 'TestKeyVal' in the markers is the test here.
56			*
57			* FIXME: Leading blank space
58			*/
59	1		public function testSetMarkerTemplateValues()
60			{
61	1		$instance = $this->getInstance();
62	1		$instance->MapPinEdited = true;
63	1		$vals = array('TestKey' => ' TestKeyVal');
64	1		$instance->setMarkerTemplateValues($vals);
65	1		$html = $instance->getRenderableMap(300, 800, 2)->setDivId('testmap')->forTemplate()->getValue();
66			$expected = <<<HTML
67
68
69			<div id="testmap" data-google-map-lang="en" style="width:300; height: 800;"
70			class=" mappable"
71			data-map
72			data-centre='{"lat":13.8188931,"lng":100.5005558}'
73			data-zoom=2
74			data-maptype='road'
75			data-allowfullscreen='1'
76			data-clusterergridsize=50,
77			data-clusterermaxzoom=17,
78			data-enableautocentrezoom=false
79			data-enablewindowzoom=false
80			data-infowindowzoom=13
81			data-mapmarkers='[{"latitude":13.8188931,"longitude":100.5005558,"html":"MEMBER: Test User TestKeyVal","category":"default","icon":false}]'
82			data-defaulthidemarker=false
83			data-lines='[]'
84			data-kmlfiles='[]'
85			data-mapstyles='[]'
86			data-useclusterer=false
87			>
88			</div>
89
90	1		HTML;
91
92	1		$this->assertEquals($expected, $html);
93	1		}
94
95	1		public function testStaticMapChangeLocation()
96			{
97	1		$instance = $this->getInstance();
98	1		$instance->Lat = 13.84;
99	1		$instance->Lon = 100.52;
100	1		$html = $instance->StaticMap(300, 800);
101			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
102			.'13.84%2C100.52&markers=13.84%2C100.52'
103	1		.'&zoom=13&size=300x800&sensor=false&mapt'
104	1		.'ype=roadmap" width="300" height="800" alt="User" />';
105	1		$this->assertEquals($expected, $html);
106	1		}
107
108	1		public function testStaticMapVarySize()
109			{
110	1		$instance = $this->getInstance();
111	1		$instance->Lat = 13.8188931;
112	1		$instance->Lon = 100.5005558;
113	1		$html = $instance->StaticMap(300, 800);
114			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
115			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
116	1		.'558&zoom=13&size=300x800&sensor=false&mapt'
117	1		.'ype=roadmap" width="300" height="800" alt="User" />';
118	1		$this->assertEquals($expected, $html);
119
120	1		$html = $instance->StaticMap(310, 810);
121			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
122			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
123	1		.'558&zoom=13&size=310x810&sensor=false&mapt'
124	1		.'ype=roadmap" width="310" height="810" alt="User" />';
125	1		$this->assertEquals($expected, $html);
126	1		}
127
128	1		public function testStaticMapVaryTerrain()
129			{
130	1		$instance = $this->getInstance();
131	1		$instance->Lat = 13.8188931;
132	1		$instance->Lon = 100.5005558;
133	1		$html = $instance->StaticMap(300, 800, null, 'satellite');
134			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
135			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
136	1		.'558&zoom=13&size=300x800&sensor=false&mapt'
137	1		.'ype=satellite" width="300" height="800" alt="User" />';
138	1		$this->assertEquals($expected, $html);
139
140	1		$html = $instance->StaticMap(300, 800, null, 'terrain');
			0 ignored issues – show Unused Code introduced 2015-12-22 11:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$html` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
141			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
			0 ignored issues – show Unused Code introduced 2015-12-22 11:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$expected` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
142			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
143	1		.'558&zoom=13&size=300x800&sensor=false&mapt'
144	1		.'ype=terrain" width="300" height="800" alt="User" />';
145
146	1		$html = $instance->StaticMap(300, 800, null, 'hybrid');
147			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
148			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
149	1		.'558&zoom=13&size=300x800&sensor=false&mapt'
150	1		.'ype=hybrid" width="300" height="800" alt="User" />';
151	1		$this->assertEquals($expected, $html);
152	1		}
153
154	1		public function testStaticMapVaryZoom()
155			{
156	1		$instance = $this->getInstance();
157
158	1		$html = $instance->StaticMap(300, 800, 2);
159			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
160			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
161	1		.'558&zoom=2&size=300x800&sensor=false&mapt'
162	1		.'ype=roadmap" width="300" height="800" alt="User" />';
163	1		$this->assertEquals($expected, $html);
164
165	1		$html = $instance->StaticMap(300, 800, 12);
166			$expected = '<img src="//maps.googleapis.com/maps/api/staticmap?center='
167			.'13.8188931%2C100.5005558&markers=13.8188931%2C100.5005'
168	1		.'558&zoom=12&size=300x800&sensor=false&mapt'
169	1		.'ype=roadmap" width="300" height="800" alt="User" />';
170	1		$this->assertEquals($expected, $html);
171	1		}
172
173	1		public function testStaticMapWithMapPin()
174			{
175	1		$instance = $this->getInstance();
176	1		$this->addMapPinToInstance($instance);
177
178	1		$html = $instance->StaticMap(300, 800, 2);
179
180	1		$this->assertStringStartsWith('<img src="//maps.googleapis.com/maps/api/staticmap?center=13.8188931%2C100.5005558&markers=icon%3A', $html);
181	1		$this->assertStringEndsWith('%2Fassets%2Fmapicontest.png%7C13.8188931%2C100.5005558&zoom=2&size=300x800&sensor=false&maptype=roadmap" width="300" height="800" alt="User, Test" />', $html);
182	1		}
183
184	7	View Code Duplication	private function getInstance()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
185			{
186	7		$instance = new Member();
187	7		$instance->Lat = 13.8188931;
188	7		$instance->Lon = 100.5005558;
189	7		$instance->FirstName = 'Test';
190	7		$instance->Surname = 'User';
191
192	7		return $instance;
193			}
194
195			/**
196			* @param Member $instance
197			*/
198	1	View Code Duplication	private function addMapPinToInstance(&$instance)
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
199			{
200			// Create a pin
201	1		$copied = copy('mappable/tests/images/mapicontest.png', 'assets/mapicontest.png');
202	1		$this->assertTrue($copied);
			0 ignored issues – show Bug introduced 2015-12-25 09:45 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertTrue()` does not seem to exist on `object<MappableDataTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
203	1		$imageFile = new Image(array('Name' => 'mapicontest.png', 'Filename' => 'assets/mapicontest.png'));
204	1		$imageFile->write();
205	1		$instance->MapPinIconID = $imageFile->ID;
206	1		$instance->write();
207	1		}
208			}
209

gordonbanderson / Mappable

Issues (125)

Security Analysis not enabled

tests/MappableDataTest.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like