Issues in MapExtensionTest.php (3.1) - Issues in 3.1 - gordonbanderson/Mappable - Measure and Improve Code Quality continuously with Scrutinizer

Issues (125)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

tests/MapExtensionTest.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

class MapExtensionTest extends SapphireTest
{
    protected static $fixture_file = 'mappable/tests/mapextensions.yml';

    public function setUpOnce()
    {
        $this->requiredExtensions = array(
            'Member' => array('MapExtension', 'MapLayerExtension'),
        );
        parent::setupOnce();
    }

    public function testUpdateCMSFields()
    {
    }

    public function testGetMappableLatitude()
    {
        $instance = $this->getInstance();
        $instance->Lat = 42.1;
        $instance->write();
        $this->assertEquals(
            42.1,
            $instance->getMappableLatitude()
        );
    }

    public function testGetMappableLongitude()
    {
        $instance = $this->getInstance();
        $instance->Lon = 42.1;
        $this->assertEquals(
            42.1,
            $instance->getMappableLongitude()
        );
    }

    public function testgetMappableMapContent()
    {
    }

    public function testonBeforeWriteMapPinNotEdited()
    {
        $instance = $this->getInstance();
        $this->Lat = 0;
        $this->Lon = 0;
        $instance->write();
        $this->assertFalse($instance->MapPinEdited);
    }

    public function testonBeforeWriteMapPinEdited()
    {
        $instance = $this->getInstance();

        // north
        $this->showMapPinEdited($instance, 10, 0);

        // north west
        $this->showMapPinEdited($instance, 10, -10);

        // west
        $this->showMapPinEdited($instance, 0, -10);

        // south west
        $this->showMapPinEdited($instance, -10, -10);

        // south
        $this->showMapPinEdited($instance, -10, 0);

        // south east
        $this->showMapPinEdited($instance, -10, 10);

        // east
        $this->showMapPinEdited($instance, 0, 10);

        // north east
        $this->showMapPinEdited($instance, 10, 10);
    }

    // FIXME - use an actual file here
    public function testGetMappableMapPin()
    {
        $instance = $this->getInstance();

        // no icon, so return false
        $this->assertFalse($instance->getMappableMapPin());

        // add a default map icon
        $this->addMapPinToInstance($instance);

        $pin1 = $instance->getMappableMapPin();
        $this->assertStringEndsWith('assets/mapicontest.png', $pin1);


        // Test the cached pin - this is the case of a layer providing a cached pin
        // so that repeated calls are not made to load the same icon
        $iconURL =
            'https://cdn3.iconfinder.com/data/icons/iconic-1/32/map_pin_fill-512.png';

        // Set mappable as having no icon, use the cached one instead
        // This simulates using a common icon to avoid DB queries
        $instance->MapPinIconID = 0;
        $instance->write();
        $instance->CachedMapPinURL = $iconURL;
        $pin2 = $instance->getMappableMapPin();
        $this->assertEquals($iconURL, $pin2);
    }

    public function testHasGeoWest()
    {
        $instance = $this->getInstance();
        $instance->Lon = -20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoEast()
    {
        $instance = $this->getInstance();
        $instance->Lon = 20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoNorth()
    {
        $instance = $this->getInstance();
        $instance->Lat = 20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoNorthWest()

    {
        $instance = $this->getInstance();
        $instance->Lat = 20;
        $instance->Lon = -20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoNortEast()

    {
        $instance = $this->getInstance();
        $instance->Lat = 20;
        $instance->Lon = 20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoSouth()
    {
        $instance = $this->getInstance();
        $instance->Lat = -20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoSouthWest()

    {
        $instance = $this->getInstance();
        $instance->Lat = -20;
        $instance->Lon = -20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoSouthEast()

    {
        $instance = $this->getInstance();
        $instance->Lat = -20;
        $instance->Lon = 20;
        $this->assertTrue($instance->HasGeo());
    }

    public function testHasGeoOrigin()
    {
        $instance = $this->getInstance();
        $instance->Lat = 0;
        $instance->Lon = 0;
        $this->assertFalse($instance->HasGeo());
    }

    public function testHasGeoOriginMapLayerExtension()
    {
        $instance = $this->getInstance();

        // assert that origin has no geo (until layers added)
        $instance->Lat = 0;
        $instance->Lon = 0;
        $this->assertFalse($instance->HasGeo());

        $this->addLayerToInstance($instance);

        // assert has geo even when at the origin of 0,0
        $this->assertTrue($instance->HasGeo());
    }

    public function testBasicMap()

    {
        $instance = $this->getInstance();
        $instance->Lat = 37.1;
        $instance->Lon = 28;
        $instance->Zoom = 12;
        $instance->MapPinEdited = true;
        $html = $instance->BasicMap()->forTemplate();

        $expected = "data-centre='{\"lat\":37.1,\"lng\":28}'";
        $this->assertContains($expected, $html);
        $expected = "data-mapmarkers='[{\"latitude\":37.1,\"longitude\":28,\"html\":\"MEMBER: \",\"category\":\"default\",\"icon\":false}]'";
        $this->assertContains($expected, $html);

        // This is only set automatically with layers
        $expected = 'data-enableautocentrezoom=false';
        $this->assertContains($expected, $html);
    }

    public function testBasicMapWithLayer()

    {
        $instance = $this->getInstance();
        $instance->Lat = 37.1;
        $instance->Lon = 28;
        $instance->Zoom = 12;
        $instance->MapPinEdited = true;
        $instance->write();
        $this->addLayerToInstance($instance);
        $html = $instance->BasicMap()->forTemplate();

        $expected = "data-centre='{\"lat\":37.1,\"lng\":28}'";
        $this->assertContains($expected, $html);
        $expected = "data-mapmarkers='[{\"latitude\":37.1,\"longitude\":28,\"html\":\"MEMBER: \",\"category\":\"default\",\"icon\":false}]'";
        $this->assertContains($expected, $html);

        // This is only set automatically with layers
        $expected = 'data-enableautocentrezoom=1';
        $this->assertContains($expected, $html);
    }

    public function testGetMapField()
    {
        $instance = $this->getInstance();
        $this->Lat = 37.1;
        $this->Lon = 28;
        $this->Zoom = 12;
        $mapField = $instance->getMapField();
        $this->assertInstanceOf('LatLongField', $mapField);
    }

    public function testUseCompressedAssets()
    {
        $original = Config::inst()->get('Mappable', 'use_compressed_assets');

        $instance = $this->getInstance();
        Config::inst()->update('Mappable', 'use_compressed_assets', false);
        $this->assertFalse($instance->UseCompressedAssets());

        $instance = $this->getInstance();
        Config::inst()->update('Mappable', 'use_compressed_assets', true);
        $this->assertTrue($instance->UseCompressedAssets());

        Config::inst()->update('Mappable', 'use_compressed_assets', $original);
    }

    private function getInstance()
    {
        $instance = new Member();

        return $instance;
    }

    /*
    Add a map layer to an existing instance
     */
    private function addLayerToInstance(&$instance)
    {
        // Create a layer
        $kmlFile = new File(array('Name' => 'example.kml', 'Filename' => 'mappable/tests/kml/example.kml'));
        $layer = new MapLayer();
        $layer->Title = 'Example KML Layer';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $layer->KmlFile = $kmlFile;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
        $layer->write();

        // add the layer to the Member object
        $layers = $instance->MapLayers();
        $layers->add($layer);
    }

    private function addMapPinToInstance(&$instance)

    {
        // Create a pin
        $copied = copy('mappable/tests/images/mapicontest.png', 'assets/mapicontest.png');
        $this->assertTrue($copied);
        $imageFile = new Image(array('Name' => 'mapicontest.png', 'Filename' => 'assets/mapicontest.png'));
        $imageFile->write();
        $instance->MapPinIconID = $imageFile->ID;
        $instance->write();
    }

    /**
     * @param int $lat
     * @param int $lon
     */
    private function showMapPinEdited(&$instance, $lat, $lon)
    {
        $instance->Lat = $lat;
        $instance->Long = $lon;
        $instance->write();
        $this->assertTrue($instance->MapPinEdited);
    }
}


1			<?php
2
3			class MapExtensionTest extends SapphireTest
4			{
5			protected static $fixture_file = 'mappable/tests/mapextensions.yml';
6
7			public function setUpOnce()
8			{
9			$this->requiredExtensions = array(
10			'Member' => array('MapExtension', 'MapLayerExtension'),
11			);
12			parent::setupOnce();
13			}
14
15	1		public function testUpdateCMSFields()
16			{
17	1		}
18
19	1		public function testGetMappableLatitude()
20			{
21	1		$instance = $this->getInstance();
22	1		$instance->Lat = 42.1;
23	1		$instance->write();
24	1		$this->assertEquals(
25	1		42.1,
26	1		$instance->getMappableLatitude()
27	1		);
28	1		}
29
30	1		public function testGetMappableLongitude()
31			{
32	1		$instance = $this->getInstance();
33	1		$instance->Lon = 42.1;
34	1		$this->assertEquals(
35	1		42.1,
36	1		$instance->getMappableLongitude()
37	1		);
38	1		}
39
40	1		public function testgetMappableMapContent()
41			{
42	1		}
43
44	1		public function testonBeforeWriteMapPinNotEdited()
45			{
46	1		$instance = $this->getInstance();
47	1		$this->Lat = 0;
48	1		$this->Lon = 0;
49	1		$instance->write();
50	1		$this->assertFalse($instance->MapPinEdited);
51	1		}
52
53	1		public function testonBeforeWriteMapPinEdited()
54			{
55	1		$instance = $this->getInstance();
56
57			// north
58	1		$this->showMapPinEdited($instance, 10, 0);
59
60			// north west
61	1		$this->showMapPinEdited($instance, 10, -10);
62
63			// west
64	1		$this->showMapPinEdited($instance, 0, -10);
65
66			// south west
67	1		$this->showMapPinEdited($instance, -10, -10);
68
69			// south
70	1		$this->showMapPinEdited($instance, -10, 0);
71
72			// south east
73	1		$this->showMapPinEdited($instance, -10, 10);
74
75			// east
76	1		$this->showMapPinEdited($instance, 0, 10);
77
78			// north east
79	1		$this->showMapPinEdited($instance, 10, 10);
80	1		}
81
82			// FIXME - use an actual file here
83	1		public function testGetMappableMapPin()
84			{
85	1		$instance = $this->getInstance();
86
87			// no icon, so return false
88	1		$this->assertFalse($instance->getMappableMapPin());
89
90			// add a default map icon
91	1		$this->addMapPinToInstance($instance);
92
93	1		$pin1 = $instance->getMappableMapPin();
94	1		$this->assertStringEndsWith('assets/mapicontest.png', $pin1);
			0 ignored issues – show Bug introduced 2015-12-22 11:55 UTC by Report Bug Copy Issue Report Show Similar Issues like this The method `assertStringEndsWith()` does not seem to exist on `object<MapExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
95
96			// Test the cached pin - this is the case of a layer providing a cached pin
97			// so that repeated calls are not made to load the same icon
98			$iconURL =
99	1		'https://cdn3.iconfinder.com/data/icons/iconic-1/32/map_pin_fill-512.png';
100
101			// Set mappable as having no icon, use the cached one instead
102			// This simulates using a common icon to avoid DB queries
103	1		$instance->MapPinIconID = 0;
104	1		$instance->write();
105	1		$instance->CachedMapPinURL = $iconURL;
106	1		$pin2 = $instance->getMappableMapPin();
107	1		$this->assertEquals($iconURL, $pin2);
108	1		}
109
110	1		public function testHasGeoWest()
111			{
112	1		$instance = $this->getInstance();
113	1		$instance->Lon = -20;
114	1		$this->assertTrue($instance->HasGeo());
115	1		}
116
117	1		public function testHasGeoEast()
118			{
119	1		$instance = $this->getInstance();
120	1		$instance->Lon = 20;
121	1		$this->assertTrue($instance->HasGeo());
122	1		}
123
124	1		public function testHasGeoNorth()
125			{
126	1		$instance = $this->getInstance();
127	1		$instance->Lat = 20;
128	1		$this->assertTrue($instance->HasGeo());
129	1		}
130
131	1	View Code Duplication	public function testHasGeoNorthWest()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
132			{
133	1		$instance = $this->getInstance();
134	1		$instance->Lat = 20;
135	1		$instance->Lon = -20;
136	1		$this->assertTrue($instance->HasGeo());
137	1		}
138
139	1	View Code Duplication	public function testHasGeoNortEast()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
140			{
141	1		$instance = $this->getInstance();
142	1		$instance->Lat = 20;
143	1		$instance->Lon = 20;
144	1		$this->assertTrue($instance->HasGeo());
145	1		}
146
147	1		public function testHasGeoSouth()
148			{
149	1		$instance = $this->getInstance();
150	1		$instance->Lat = -20;
151	1		$this->assertTrue($instance->HasGeo());
152	1		}
153
154	1	View Code Duplication	public function testHasGeoSouthWest()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
155			{
156	1		$instance = $this->getInstance();
157	1		$instance->Lat = -20;
158	1		$instance->Lon = -20;
159	1		$this->assertTrue($instance->HasGeo());
160	1		}
161
162	1	View Code Duplication	public function testHasGeoSouthEast()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
163			{
164	1		$instance = $this->getInstance();
165	1		$instance->Lat = -20;
166	1		$instance->Lon = 20;
167	1		$this->assertTrue($instance->HasGeo());
168	1		}
169
170	1		public function testHasGeoOrigin()
171			{
172	1		$instance = $this->getInstance();
173	1		$instance->Lat = 0;
174	1		$instance->Lon = 0;
175	1		$this->assertFalse($instance->HasGeo());
176	1		}
177
178	2		public function testHasGeoOriginMapLayerExtension()
179			{
180	1		$instance = $this->getInstance();
181
182			// assert that origin has no geo (until layers added)
183	1		$instance->Lat = 0;
184	1		$instance->Lon = 0;
185	1		$this->assertFalse($instance->HasGeo());
186
187	1		$this->addLayerToInstance($instance);
188
189			// assert has geo even when at the origin of 0,0
190	1		$this->assertTrue($instance->HasGeo());
191	2		}
192
193	1	View Code Duplication	public function testBasicMap()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
194			{
195	1		$instance = $this->getInstance();
196	1		$instance->Lat = 37.1;
197	1		$instance->Lon = 28;
198	1		$instance->Zoom = 12;
199	1		$instance->MapPinEdited = true;
200	1		$html = $instance->BasicMap()->forTemplate();
201
202	1		$expected = "data-centre='{\"lat\":37.1,\"lng\":28}'";
203	1		$this->assertContains($expected, $html);
204	1		$expected = "data-mapmarkers='[{\"latitude\":37.1,\"longitude\":28,\"html\":\"MEMBER: \",\"category\":\"default\",\"icon\":false}]'";
205	1		$this->assertContains($expected, $html);
206
207			// This is only set automatically with layers
208	1		$expected = 'data-enableautocentrezoom=false';
209	1		$this->assertContains($expected, $html);
210	1		}
211
212	1	View Code Duplication	public function testBasicMapWithLayer()
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
213			{
214	1		$instance = $this->getInstance();
215	1		$instance->Lat = 37.1;
216	1		$instance->Lon = 28;
217	1		$instance->Zoom = 12;
218	1		$instance->MapPinEdited = true;
219	1		$instance->write();
220	1		$this->addLayerToInstance($instance);
221	1		$html = $instance->BasicMap()->forTemplate();
222
223	1		$expected = "data-centre='{\"lat\":37.1,\"lng\":28}'";
224	1		$this->assertContains($expected, $html);
225	1		$expected = "data-mapmarkers='[{\"latitude\":37.1,\"longitude\":28,\"html\":\"MEMBER: \",\"category\":\"default\",\"icon\":false}]'";
226	1		$this->assertContains($expected, $html);
227
228			// This is only set automatically with layers
229	1		$expected = 'data-enableautocentrezoom=1';
230	1		$this->assertContains($expected, $html);
231	1		}
232
233	1		public function testGetMapField()
234			{
235	1		$instance = $this->getInstance();
236	1		$this->Lat = 37.1;
237	1		$this->Lon = 28;
238	1		$this->Zoom = 12;
239	1		$mapField = $instance->getMapField();
240	1		$this->assertInstanceOf('LatLongField', $mapField);
241	1		}
242
243	1		public function testUseCompressedAssets()
244			{
245	1		$original = Config::inst()->get('Mappable', 'use_compressed_assets');
246
247	1		$instance = $this->getInstance();
248	1		Config::inst()->update('Mappable', 'use_compressed_assets', false);
249	1		$this->assertFalse($instance->UseCompressedAssets());
250
251	1		$instance = $this->getInstance();
252	1		Config::inst()->update('Mappable', 'use_compressed_assets', true);
253	1		$this->assertTrue($instance->UseCompressedAssets());
254
255	1		Config::inst()->update('Mappable', 'use_compressed_assets', $original);
256	1		}
257
258	19		private function getInstance()
259			{
260	19		$instance = new Member();
261
262	19		return $instance;
263			}
264
265			/*
266			Add a map layer to an existing instance
267			*/
268	2		private function addLayerToInstance(&$instance)
269			{
270			// Create a layer
271	2		$kmlFile = new File(array('Name' => 'example.kml', 'Filename' => 'mappable/tests/kml/example.kml'));
272	2		$layer = new MapLayer();
273	2		$layer->Title = 'Example KML Layer';
			0 ignored issues – show Documentation introduced 2015-12-23 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `Title` does not exist on `object<MapLayer>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
274	2		$layer->KmlFile = $kmlFile;
			0 ignored issues – show Documentation introduced 2015-12-23 08:30 UTC by Report Bug Copy Issue Report Show Similar Issues like this The property `KmlFile` does not exist on `object<MapLayer>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
275	2		$layer->write();
276
277			// add the layer to the Member object
278	2		$layers = $instance->MapLayers();
279	2		$layers->add($layer);
280	2		}
281
282	1	View Code Duplication	private function addMapPinToInstance(&$instance)
			0 ignored issues – show Duplication introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
283			{
284			// Create a pin
285	1		$copied = copy('mappable/tests/images/mapicontest.png', 'assets/mapicontest.png');
286	1		$this->assertTrue($copied);
287	1		$imageFile = new Image(array('Name' => 'mapicontest.png', 'Filename' => 'assets/mapicontest.png'));
288	1		$imageFile->write();
289	1		$instance->MapPinIconID = $imageFile->ID;
290	1		$instance->write();
291	1		}
292
293			/**
294			* @param int $lat
295			* @param int $lon
296			*/
297	1		private function showMapPinEdited(&$instance, $lat, $lon)
298			{
299	1		$instance->Lat = $lat;
300	1		$instance->Long = $lon;
301	1		$instance->write();
302	1		$this->assertTrue($instance->MapPinEdited);
303	1		}
304			}
305

gordonbanderson / Mappable

Issues (125)

Security Analysis not enabled

tests/MapExtensionTest.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like