MapExtensionTest::testHasGeoMapLayers() - Code Metrics - Inspection of "WIP: Added a currently failing test for checking H..." - gordonbanderson/Mappable - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — AUTOMATED_TESTING ( d8ef29...38d0da )

by Gordon

created 2015-12-21 20:19 UTC

MapExtensionTest::testHasGeoMapLayers() A

↳ Parent: MapExtensionTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	12
rs	9.4286
cc	1
eloc	10
nc	1
nop	0

<?php

class MapExtensionTest extends SapphireTest {
	protected static $fixture_file = 'mappable/tests/mapextensions.yml';

	public function setUpOnce() {
		$this->requiredExtensions = array(
			'Member' => array('MapExtension')
		);
		parent::setupOnce();
	}


	public function testupdateCMSFields() {

	}


	public function testGetMappableLatitude() {
		$instance = $this->getInstance();
		$instance->Lat = 42.1;
		$instance->write();
		$this->assertEquals(
			42.1,
			$instance->getMappableLatitude()
		);
	}


	public function testGetMappableLongitude() {
		$instance = $this->getInstance();
		$instance->Lon = 42.1;
		$this->assertEquals(
			42.1,
			$instance->getMappableLongitude()
		);
	}


	public function testgetMappableMapContent() {

	}


	public function testonBeforeWriteMapPinNotEdited() {
		$instance = $this->getInstance();
		$this->Lat = 0;
		$this->Lon = 0;
		$instance->write();
		$this->assertFalse($instance->MapPinEdited);
	}

	public function testonBeforeWriteMapPinEdited() {
		$instance = $this->getInstance();

		// north
		$this->showMapPinEdited($instance, 10, 0);

		// north west
		$this->showMapPinEdited($instance, 10, -10);

		// west
		$this->showMapPinEdited($instance, 0, -10);

		// south west
		$this->showMapPinEdited($instance, -10, -10);

		// south
		$this->showMapPinEdited($instance, -10, 0);

		// south east
		$this->showMapPinEdited($instance, -10, 10);

		// east
		$this->showMapPinEdited($instance, 0, 10);

		// north east
		$this->showMapPinEdited($instance, 10, 10);

	}


	public function testgetMappableMapPin() {

	}


	public function testHasGeoMapLayers() {
		Member::add_extension('MapLayerExtension');
		$instance = $this->getInstance();
		$layer = new MapLayer();
		$layer->Title = 'Ari Administrative Boundary';
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		$layers = new ArrayList();
		$layers->push($layer);
		$member->MapLayers = $layers;

		$this->assertTrue($instance->HasGeo());
		Member::remove_extension('MapLayerExtension');

	}


	public function testHasGeoWest() {
		$instance = $this->getInstance();
		$instance->Lon = -20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoEast() {
		$instance = $this->getInstance();
		$instance->Lon = 20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoNorth() {
		$instance = $this->getInstance();
		$instance->Lat = 20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoNorthWest() {
		$instance = $this->getInstance();
		$instance->Lat = 20;
		$instance->Lon = -20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoNortEast() {
		$instance = $this->getInstance();
		$instance->Lat = 20;
		$instance->Lon = 20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoSouth() {
		$instance = $this->getInstance();
		$instance->Lat = -20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoSouthWest() {
		$instance = $this->getInstance();
		$instance->Lat = -20;
		$instance->Lon = -20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoSouthEast() {
		$instance = $this->getInstance();
		$instance->Lat = -20;
		$instance->Lon = 20;
		$this->assertTrue($instance->HasGeo());
	}

	public function testHasGeoOrigin() {
		$instance = $this->getInstance();
		$instance->Lat = 0;
		$instance->Lon = 0;
		$this->assertFalse($instance->HasGeo());
	}

	public function testHasGeoOriginMapLayerExtension() {
		$instance = $this->getInstance();
		$instance->Lat = 0;
		$instance->Lon = 0;
		$this->assertFalse($instance->HasGeo());
		Page::add_extension('MapLayerExtension');
		Page::remove_extension('MapLayerExtension');
		$this->markTestSkipped('TODO');

	}

	public function testHasGeoOriginPointsOfInterestLayers() {
		$instance = $this->getInstance();
		$instance->Lat = 0;
		$instance->Lon = 0;
		$this->assertFalse($instance->HasGeo());
		$this->markTestSkipped('TODO');

	}

	public function testBasicMap() {

	}


	public function testGetMapField() {
		$instance = $this->getInstance();
		$this->Lat = 37.1;
		$this->Lon = 28;
		$this->Zoom = 12;
		$mapField  = $instance->getMapField();
		$this->assertInstanceOf('LatLongField', $mapField);
	}


	public function testUseCompressedAssets() {

	}


	private function getInstance() {
		$instance = new Member();
		return $instance;
	}

	/**
	 * @param integer $lat
	 * @param integer $lon
	 */
	private function showMapPinEdited(&$instance, $lat, $lon) {
		$instance->Lat = $lat;
		$instance->Long = $lon;
		$instance->write();
		$this->assertTrue($instance->MapPinEdited);
	}



}


1			<?php
2
3			class MapExtensionTest extends SapphireTest {
4			protected static $fixture_file = 'mappable/tests/mapextensions.yml';
5
6			public function setUpOnce() {
7			$this->requiredExtensions = array(
8			'Member' => array('MapExtension')
9			);
10			parent::setupOnce();
11			}
12
13
14			public function testupdateCMSFields() {
15
16			}
17
18
19			public function testGetMappableLatitude() {
20			$instance = $this->getInstance();
21			$instance->Lat = 42.1;
22			$instance->write();
23			$this->assertEquals(
24			42.1,
25			$instance->getMappableLatitude()
26			);
27			}
28
29
30			public function testGetMappableLongitude() {
31			$instance = $this->getInstance();
32			$instance->Lon = 42.1;
33			$this->assertEquals(
34			42.1,
35			$instance->getMappableLongitude()
36			);
37			}
38
39
40			public function testgetMappableMapContent() {
41
42			}
43
44
45			public function testonBeforeWriteMapPinNotEdited() {
46			$instance = $this->getInstance();
47			$this->Lat = 0;
48			$this->Lon = 0;
49			$instance->write();
50			$this->assertFalse($instance->MapPinEdited);
51			}
52
53			public function testonBeforeWriteMapPinEdited() {
54			$instance = $this->getInstance();
55
56			// north
57			$this->showMapPinEdited($instance, 10, 0);
58
59			// north west
60			$this->showMapPinEdited($instance, 10, -10);
61
62			// west
63			$this->showMapPinEdited($instance, 0, -10);
64
65			// south west
66			$this->showMapPinEdited($instance, -10, -10);
67
68			// south
69			$this->showMapPinEdited($instance, -10, 0);
70
71			// south east
72			$this->showMapPinEdited($instance, -10, 10);
73
74			// east
75			$this->showMapPinEdited($instance, 0, 10);
76
77			// north east
78			$this->showMapPinEdited($instance, 10, 10);
79
80			}
81
82
83			public function testgetMappableMapPin() {
84
85			}
86
87
88			public function testHasGeoMapLayers() {
89			Member::add_extension('MapLayerExtension');
90			$instance = $this->getInstance();
91			$layer = new MapLayer();
92			$layer->Title = 'Ari Administrative Boundary';
			0 ignored issues – show Documentation introduced 2015-12-21 20:30 UTC by Report Bug Copy Issue Report The property `Title` does not exist on `object<MapLayer>`. Since you implemented `__set`, maybe consider adding a @property annotation. Since your code implements the magic setter `_set`, this function will be called for any write access on an undefined variable. You can add the `@property` annotation to your class or interface to document the existence of this variable. <?php /** * @property int $x * @property int $y * @property string $text */ class MyLabel { private $properties; private $allowedProperties = array('x', 'y', 'text'); public function __get($name) { if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) { return $properties[$name]; } else { return null; } } public function __set($name, $value) { if (in_array($name, $this->allowedProperties)) { $properties[$name] = $value; } else { throw new \LogicException("Property $name is not defined."); } } } Since the property has write access only, you can use the @property-write annotation instead. Of course, you may also just have mistyped another name, in which case you should fix the error. See also the PhpDoc documentation for @property. Loading history...
93			$layers = new ArrayList();
94			$layers->push($layer);
95			$member->MapLayers = $layers;
			0 ignored issues – show Bug introduced 2015-12-21 20:30 UTC by Report Bug Copy Issue Report The variable `$member` does not exist. Did you forget to declare it? This check marks access to variables or properties that have not been declared yet. While PHP has no explicit notion of declaring a variable, accessing it before a value is assigned to it is most likely a bug. Loading history...
96			$this->assertTrue($instance->HasGeo());
97			Member::remove_extension('MapLayerExtension');
98
99			}
100
101
102			public function testHasGeoWest() {
103			$instance = $this->getInstance();
104			$instance->Lon = -20;
105			$this->assertTrue($instance->HasGeo());
106			}
107
108			public function testHasGeoEast() {
109			$instance = $this->getInstance();
110			$instance->Lon = 20;
111			$this->assertTrue($instance->HasGeo());
112			}
113
114			public function testHasGeoNorth() {
115			$instance = $this->getInstance();
116			$instance->Lat = 20;
117			$this->assertTrue($instance->HasGeo());
118			}
119
120			public function testHasGeoNorthWest() {
121			$instance = $this->getInstance();
122			$instance->Lat = 20;
123			$instance->Lon = -20;
124			$this->assertTrue($instance->HasGeo());
125			}
126
127			public function testHasGeoNortEast() {
128			$instance = $this->getInstance();
129			$instance->Lat = 20;
130			$instance->Lon = 20;
131			$this->assertTrue($instance->HasGeo());
132			}
133
134			public function testHasGeoSouth() {
135			$instance = $this->getInstance();
136			$instance->Lat = -20;
137			$this->assertTrue($instance->HasGeo());
138			}
139
140			public function testHasGeoSouthWest() {
141			$instance = $this->getInstance();
142			$instance->Lat = -20;
143			$instance->Lon = -20;
144			$this->assertTrue($instance->HasGeo());
145			}
146
147			public function testHasGeoSouthEast() {
148			$instance = $this->getInstance();
149			$instance->Lat = -20;
150			$instance->Lon = 20;
151			$this->assertTrue($instance->HasGeo());
152			}
153
154			public function testHasGeoOrigin() {
155			$instance = $this->getInstance();
156			$instance->Lat = 0;
157			$instance->Lon = 0;
158			$this->assertFalse($instance->HasGeo());
159			}
160
161			public function testHasGeoOriginMapLayerExtension() {
162			$instance = $this->getInstance();
163			$instance->Lat = 0;
164			$instance->Lon = 0;
165			$this->assertFalse($instance->HasGeo());
166			Page::add_extension('MapLayerExtension');
167			Page::remove_extension('MapLayerExtension');
168			$this->markTestSkipped('TODO');
			0 ignored issues – show Bug introduced 2015-12-21 14:15 UTC by Report Bug Copy Issue Report The method `markTestSkipped()` does not seem to exist on `object<MapExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
169			}
170
171			public function testHasGeoOriginPointsOfInterestLayers() {
172			$instance = $this->getInstance();
173			$instance->Lat = 0;
174			$instance->Lon = 0;
175			$this->assertFalse($instance->HasGeo());
176			$this->markTestSkipped('TODO');
			0 ignored issues – show Bug introduced 2015-12-21 14:15 UTC by Report Bug Copy Issue Report The method `markTestSkipped()` does not seem to exist on `object<MapExtensionTest>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
177			}
178
179			public function testBasicMap() {
180
181			}
182
183
184			public function testGetMapField() {
185			$instance = $this->getInstance();
186			$this->Lat = 37.1;
187			$this->Lon = 28;
188			$this->Zoom = 12;
189			$mapField = $instance->getMapField();
190			$this->assertInstanceOf('LatLongField', $mapField);
191			}
192
193
194			public function testUseCompressedAssets() {
195
196			}
197
198
199			private function getInstance() {
200			$instance = new Member();
201			return $instance;
202			}
203
204			/**
205			* @param integer $lat
206			* @param integer $lon
207			*/
208			private function showMapPinEdited(&$instance, $lat, $lon) {
209			$instance->Lat = $lat;
210			$instance->Long = $lon;
211			$instance->write();
212			$this->assertTrue($instance->MapPinEdited);
213			}
214
215
216
217			}
218

gordonbanderson / Mappable

Push — AUTOMATED_TESTING ( d8ef29...38d0da )

MapExtensionTest::testHasGeoMapLayers() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like