MappableDataObjectSet::getRenderableMap() - Code Metrics - gordonbanderson/Mappable - Measure and Improve Code Quality continuously with Scrutinizer

MappableDataObjectSet::getRenderableMap() A
last analyzed 2018-10-01 19:38 UTC

↳ Parent: MappableDataObjectSet

Complexity

Conditions	3
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	3

Importance

Changes

Metric	Value
dl	0
loc	9
ccs	6
cts	6
cp	1
rs	9.9666
c	0
b	0
f	0
cc	3
nc	4
nop	2
crap	3

<?php

/*
 * Provides a GoogleMap() function to DataObject objects.
 *
 * @author Uncle Cheese
 * @package mappable
 */
class MappableDataObjectSet extends Extension
{
    /**
     * Optional template values for the map info windows.
     */
    private $MarkerTemplateValues = null;

    /**
     * Pass through values to the markers so that when rendering the map info windows, these
     * parameters are available to the template.  This is of course optional.
     *
     * @param array $values hash array of template key to template value
     */
    public function setMarkerTemplateValues($values)
    {
        $this->MarkerTemplateValues = $values;
    }

    public function getRenderableMap($width = null, $height = null)
    {
        $gmap = MapUtil::get_map($this->owner, $this->MarkerTemplateValues);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $w = $width ? $width : MapUtil::$map_width;
        $h = $height ? $height : MapUtil::$map_height;
        $gmap->setSize($w, $h);

        return $gmap;
    }
}


1		<?php
2
3		/*
4		* Provides a GoogleMap() function to DataObject objects.
5		*
6		* @author Uncle Cheese
7		* @package mappable
8		*/
9		class MappableDataObjectSet extends Extension
10		{
11		/**
12		* Optional template values for the map info windows.
13		*/
14		private $MarkerTemplateValues = null;
15
16		/**
17		* Pass through values to the markers so that when rendering the map info windows, these
18		* parameters are available to the template. This is of course optional.
19		*
20		* @param array $values hash array of template key to template value
21		*/
22	1	public function setMarkerTemplateValues($values)
23		{
24	1	$this->MarkerTemplateValues = $values;
25	1	}
26
27	3	public function getRenderableMap($width = null, $height = null)
28		{
29	3	$gmap = MapUtil::get_map($this->owner, $this->MarkerTemplateValues);
		0 ignored issues – show Documentation introduced 2018-10-01 19:38 UTC by Report Bug Copy Issue Report `$this->owner` is of type `object<SS_Object>`, but the function expects a `object<SS_List>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
30	3	$w = $width ? $width : MapUtil::$map_width;
31	3	$h = $height ? $height : MapUtil::$map_height;
32	3	$gmap->setSize($w, $h);
33
34	3	return $gmap;
35		}
36		}
37

gordonbanderson / Mappable

MappableDataObjectSet::getRenderableMap() A last analyzed 2018-10-01 19:38 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MappableDataObjectSet::getRenderableMap() A
last analyzed 2018-10-01 19:38 UTC