MapField::Field() - Code Metrics - gordonbanderson/Mappable - Measure and Improve Code Quality continuously with Scrutinizer

MapField::Field() A
last analyzed 2018-10-01 19:38 UTC

↳ Parent: MapField

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	11
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	17
ccs	11
cts	11
cp	1
rs	9.7
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php
/**
 * Map field to point for pois langitude and longitude positioning.
 */
class MapField extends DatalessField
{
    /**
         * @var int The level of the <h1> to <h6> HTML tag. Default: 2
         */
    protected $headingLevel = 2;
    private $divId;

    /**
     * @param string $name
     * @param string $title
     */
    public function __construct($name, $title = null, $headingLevel = 2, $allowHTML = false, $form = null)
    {
        $this->divId = $name;
        // legacy handling for old parameters: $title, $heading, ...
        // instead of new handling: $name, $title, $heading, ...
        $args = func_get_args();
        if (!isset($args[1]) || is_numeric($args[1])) {
            $title = (isset($args[0])) ? $args[0] : null;
            // Use "HeaderField(title)" as the default field name for a HeaderField;
            // if it's just set to title then we risk causing accidental duplicate-field creation.

            // this means i18nized fields won't be easily accessible through fieldByName()
            $name = 'MapField'.$title;
            $headingLevel = (isset($args[1])) ? $args[1] : null;
            $allowHTML = (isset($args[2])) ? $args[2] : null;
            $form = (isset($args[3])) ? $args[3] : null;
        }

        if ($headingLevel) {
            $this->headingLevel = $headingLevel;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }
        $this->allowHTML = $allowHTML;
        parent::__construct($name, $title, null, $allowHTML, $form);

    }

    public function Field($properties = array())

    {
        Requirements::javascript('framework/thirdparty/jquery/jquery.js');
        Requirements::javascript('framework/thirdparty/jquery-livequery/jquery.livequery.js');
        $attributes = array(
                        'class' => 'middleColumn',
                        'id' => $this->divId,
                        'style' => 'width:100%;height:300px;margin:5px 0px 5px 5px;position:relative;',
                );

        Requirements::css('mappable/css/mapField.css');

        return '<div class="editableMap">'.$this->createTag(

                        'div',
                        $attributes
                ).'</div>';
    }
}


1		<?php
2		/**
3		* Map field to point for pois langitude and longitude positioning.
4		*/
5		class MapField extends DatalessField
6		{
7		/**
8		* @var int The level of the <h1> to <h6> HTML tag. Default: 2
9		*/
10		protected $headingLevel = 2;
11		private $divId;
12
13		/**
14		* @param string $name
15		* @param string $title
16		*/
17	2	public function __construct($name, $title = null, $headingLevel = 2, $allowHTML = false, $form = null)
18		{
19	2	$this->divId = $name;
20		// legacy handling for old parameters: $title, $heading, ...
21		// instead of new handling: $name, $title, $heading, ...
22	2	$args = func_get_args();
23	2	if (!isset($args[1]) \|\| is_numeric($args[1])) {
24	1	$title = (isset($args[0])) ? $args[0] : null;
25		// Use "HeaderField(title)" as the default field name for a HeaderField;
26		// if it's just set to title then we risk causing accidental duplicate-field creation.
27
28		// this means i18nized fields won't be easily accessible through fieldByName()
29	1	$name = 'MapField'.$title;
30	1	$headingLevel = (isset($args[1])) ? $args[1] : null;
31	1	$allowHTML = (isset($args[2])) ? $args[2] : null;
32	1	$form = (isset($args[3])) ? $args[3] : null;
33	1	}
34
35	2	if ($headingLevel) {
36	1	$this->headingLevel = $headingLevel;
		0 ignored issues – show Documentation Bug introduced 2016-01-05 06:25 UTC by Report Bug Copy Issue Report It seems like `$headingLevel` can also be of type `double` or `string`. However, the property `$headingLevel` is declared as type `integer`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
37	1	}
38	2	$this->allowHTML = $allowHTML;
39	2	parent::__construct($name, $title, null, $allowHTML, $form);
		0 ignored issues – show Unused Code introduced 2015-12-18 15:00 UTC by Report Bug Copy Issue Report The call to `DatalessField::__construct()` has too many arguments starting with `$allowHTML`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
40	2	}
41
42	2	public function Field($properties = array())
		0 ignored issues – show Coding Style introduced 2016-01-05 06:05 UTC by Report Bug Copy Issue Report Method name "MapField::Field" is not in camel caps format Loading history...
43		{
44	2	Requirements::javascript('framework/thirdparty/jquery/jquery.js');
45	2	Requirements::javascript('framework/thirdparty/jquery-livequery/jquery.livequery.js');
46		$attributes = array(
47	2	'class' => 'middleColumn',
48	2	'id' => $this->divId,
49	2	'style' => 'width:100%;height:300px;margin:5px 0px 5px 5px;position:relative;',
50	2	);
51
52	2	Requirements::css('mappable/css/mapField.css');
53
54	2	return '<div class="editableMap">'.$this->createTag(
		0 ignored issues – show Deprecated Code introduced 2015-12-18 15:00 UTC by Report Bug Copy Issue Report The method `FormField::createTag()` has been deprecated with message: 4.0 Use FormField::create_tag() This method has been deprecated. The supplier of the class has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the method will be removed from the class and what other method or class to use instead. Loading history...
55	2	'div',
56		$attributes
57	2	).'</div>';
58		}
59		}
60

gordonbanderson / Mappable

MapField::Field() A last analyzed 2018-10-01 19:38 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

MapField::Field() A
last analyzed 2018-10-01 19:38 UTC