Issues (14)

src/Command/ApcuKeyStoreCommand.php (1 issue)

Labels
Severity
1
<?php
2
3
/*
4
 * This file is part of CacheTool.
5
 *
6
 * (c) Samuel Gordalina <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
namespace CacheTool\Command;
13
14
use Symfony\Component\Console\Input\InputArgument;
15
use Symfony\Component\Console\Input\InputInterface;
16
use Symfony\Component\Console\Output\OutputInterface;
17
18
class ApcuKeyStoreCommand extends AbstractCommand
19
{
20
    /**
21
     * {@inheritdoc}
22
     */
23 24
    protected function configure()
24
    {
25
        $this
26 24
            ->setName('apcu:key:store')
27 24
            ->setDescription('Store an APCu key with given value')
28 24
            ->addArgument('key', InputArgument::REQUIRED)
29 24
            ->addArgument('value', InputArgument::REQUIRED)
30 24
            ->addArgument('ttl', InputArgument::OPTIONAL, 0)
31 24
            ->setHelp('');
32 24
    }
33
34
    /**
35
     * {@inheritdoc}
36
     */
37 1
    protected function execute(InputInterface $input, OutputInterface $output): int
38
    {
39 1
        $this->ensureExtensionLoaded('apcu');
40
41 1
        $key = $input->getArgument('key');
42 1
        $value = $input->getArgument('value');
43 1
        $ttl = $input->getArgument('ttl');
44
45 1
        $success = $this->getCacheTool()->apcu_store($key, $value, $ttl);
46
47 1
        if ($output->isVerbose()) {
48 1
            if ($success) {
49 1
                $output->writeln(sprintf("<comment>APCu key <info>{$key}</info> was stored with value=<info>%1\$s</info> and ttl=<info>{$ttl}</info></comment>", var_export($value, 1)));
0 ignored issues
show
Are you sure the usage of var_export($value, 1) is correct as it seems to always return null.

This check looks for function or method calls that always return null and whose return value is used.

class A
{
    function getObject()
    {
        return null;
    }

}

$a = new A();
if ($a->getObject()) {

The method getObject() can return nothing but null, so it makes no sense to use the return value.

The reason is most likely that a function or method is imcomplete or has been reduced for debug purposes.

Loading history...
50
            } else {
51
                $output->writeln("<comment>APCu key <info>{$key}</info> could not be stored.</comment>");
52
            }
53
        }
54
55 1
        return $success ? 0 : 1;
56
    }
57
}
58