ApcuRegexpDeleteCommand::execute() - Code Metrics - Inspection of "Merge APCu" - gordalina/cachetool - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( 2f995a...fa8c59 )

by Samuel

created 2016-06-15 17:02 UTC

ApcuRegexpDeleteCommand::execute() C

↳ Parent: ApcuRegexpDeleteCommand

Complexity

Conditions	7
Paths	24

Size

Total Lines	36
Code Lines	25

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	36
rs	6.7272
cc	7
eloc	25
nc	24
nop	2

<?php

/*
 * This file is part of CacheTool.
 *
 * (c) Samuel Gordalina <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace CacheTool\Command;

use Symfony\Component\Console\Helper\Table;
use Symfony\Component\Console\Input\InputArgument;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Output\OutputInterface;

class ApcuRegexpDeleteCommand extends AbstractCommand
{
    /**
     * {@inheritdoc}
     */
    protected function configure()
    {
        $this
            ->setName('apcu:regexp:delete')
            ->setDescription('Deletes all APCu key matching a regexp')
            ->addArgument('regexp', InputArgument::REQUIRED)
            ->setHelp('');
    }

    /**
     * {@inheritdoc}
     */
    protected function execute(InputInterface $input, OutputInterface $output)
    {
        $this->ensureExtensionLoaded('apcu');

        $regexp = $input->getArgument('regexp');

        $user = $this->getCacheTool()->apcu_cache_info('user');

        $keys = array();
        foreach ($user['cache_list'] as $key) {
            $string = $key['info'];
            if (preg_match('|' . $regexp . '|', $string)) {
                $keys[] = $key;
            }
        }
        $cpt = 0;
        $table = new Table($output);
        $table->setHeaders(array('Key', 'TTL', ));
        $table->setRows($keys);
        $table->render($output);

        foreach ($keys as $key) {
            $success = $this->getCacheTool()->apcu_delete($key['info']);
            if ($output->isVerbose()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
                if ($success) {
                    $output->writeln("<comment>APCu key <info>{$key['info']}</info> was deleted</comment>");
                } else {
                    $output->writeln("<comment>APCu key <info>{$key['info']}</info> could not be deleted.</comment>");
                }
            }
            $cpt ++;
        }
        if ($output->isVerbose()) {
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $output->writeln("<comment>APCu key <info>{$cpt}</info> keys treated.</comment>");
        }
        return 1;
    }
}


Push — 1.x ( 2f995a...fa8c59 )

ApcuRegexpDeleteCommand::execute() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

1			<?php
2
3			/*
4			* This file is part of CacheTool.
5			*
6			* (c) Samuel Gordalina <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace CacheTool\Command;
13
14			use Symfony\Component\Console\Helper\Table;
15			use Symfony\Component\Console\Input\InputArgument;
16			use Symfony\Component\Console\Input\InputInterface;
17			use Symfony\Component\Console\Output\OutputInterface;
18
19			class ApcuRegexpDeleteCommand extends AbstractCommand
20			{
21			/**
22			* {@inheritdoc}
23			*/
24			protected function configure()
25			{
26			$this
27			->setName('apcu:regexp:delete')
28			->setDescription('Deletes all APCu key matching a regexp')
29			->addArgument('regexp', InputArgument::REQUIRED)
30			->setHelp('');
31			}
32
33			/**
34			* {@inheritdoc}
35			*/
36			protected function execute(InputInterface $input, OutputInterface $output)
37			{
38			$this->ensureExtensionLoaded('apcu');
39
40			$regexp = $input->getArgument('regexp');
41
42			$user = $this->getCacheTool()->apcu_cache_info('user');
43
44			$keys = array();
45			foreach ($user['cache_list'] as $key) {
46			$string = $key['info'];
47			if (preg_match('\|' . $regexp . '\|', $string)) {
48			$keys[] = $key;
49			}
50			}
51			$cpt = 0;
52			$table = new Table($output);
53			$table->setHeaders(array('Key', 'TTL', ));
54			$table->setRows($keys);
55			$table->render($output);
			0 ignored issues – show Unused Code introduced 2016-05-31 17:33 UTC by Report Bug Copy Issue Report The call to `Table::render()` has too many arguments starting with `$output`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
56			foreach ($keys as $key) {
57			$success = $this->getCacheTool()->apcu_delete($key['info']);
58			if ($output->isVerbose()) {
			0 ignored issues – show Bug introduced 2016-06-15 17:20 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `isVerbose()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Output\BufferedOutput`, `Symfony\Component\Console\Output\ConsoleOutput`, `Symfony\Component\Console\Output\NullOutput`, `Symfony\Component\Console\Output\Output`, `Symfony\Component\Console\Output\StreamOutput`, `Symfony\Component\Consol...ts\Fixtures\DummyOutput`, `Symfony\Component\Console\Tests\Output\TestOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
59			if ($success) {
60			$output->writeln("<comment>APCu key <info>{$key['info']}</info> was deleted</comment>");
61			} else {
62			$output->writeln("<comment>APCu key <info>{$key['info']}</info> could not be deleted.</comment>");
63			}
64			}
65			$cpt ++;
66			}
67			if ($output->isVerbose()) {
			0 ignored issues – show Bug introduced 2016-06-15 17:20 UTC by Report Bug Copy Issue Report It seems like you code against a concrete implementation and not the interface `Symfony\Component\Console\Output\OutputInterface` as the method `isVerbose()` does only exist in the following implementations of said interface: `Symfony\Component\Console\Output\BufferedOutput`, `Symfony\Component\Console\Output\ConsoleOutput`, `Symfony\Component\Console\Output\NullOutput`, `Symfony\Component\Console\Output\Output`, `Symfony\Component\Console\Output\StreamOutput`, `Symfony\Component\Consol...ts\Fixtures\DummyOutput`, `Symfony\Component\Console\Tests\Output\TestOutput`. Let’s take a look at an example: interface User { /** @return string / public function getPassword(); } class MyUser implements User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different implementation of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the interface: interface User { /** @return string / public function getPassword(); /* @return string */ public function getDisplayName(); } Loading history...
68			$output->writeln("<comment>APCu key <info>{$cpt}</info> keys treated.</comment>");
69			}
70			return 1;
71			}
72			}
73

gordalina / cachetool

Push — 1.x ( 2f995a...fa8c59 )

ApcuRegexpDeleteCommand::execute() C

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like