FastCGI::request() - Code Metrics - Inspection of "Merge pull request #35 from fyrye/patch-2" - gordalina/cachetool - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 1.x ( 8c31f4...5f4811 )

by Samuel

created 2016-05-27 10:19 UTC

FastCGI::request() B

↳ Parent: FastCGI

Complexity

Conditions	2
Paths	5

Size

Total Lines	30
Code Lines	19

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	0	Features	1

Metric	Value
c	6
b	0
f	1
dl	0
loc	30
rs	8.8571
cc	2
eloc	19
nc	5
nop	1

<?php

/*
 * This file is part of CacheTool.
 *
 * (c) Samuel Gordalina <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace CacheTool\Adapter;

use CacheTool\Code;
use Adoy\FastCGI\Client;

class FastCGI extends AbstractAdapter
{
    /**
     * @var Client
     */
    protected $client;

    /**
     * @var string
     */
    protected $host;

    /**
     * @param string $host 127.0.0.1:9000 or /var/run/php5-fpm.sock
     * @param string $tempDir
     */
    public function __construct($host = null, $tempDir = null)

    {
        // try to guess where it is
        if ($host === null) {
            if (file_exists('/var/run/php5-fpm.sock')) {
                $host = '/var/run/php5-fpm.sock';
            } else {
                $host = '127.0.0.1:9000';
            }
        }

        $this->host = $host;

        if (false !== strpos($host, ':')) {
            list($host, $port) = explode(':', $host);
            $this->client = new Client($host, $port);
        } else {
            // socket
            $this->client = new Client('unix://' . $host, -1);
        }

        $this->client->setReadWriteTimeout(60 * 1000);
        $this->client->setPersistentSocket(false);
        $this->client->setKeepAlive(true);
    }

    /**
     * {@inheritdoc}
     */
    protected function doRun(Code $code)
    {
        $response = $this->request($code);
        $parts = explode("\r\n\r\n", $response);

        // remove headers
        array_shift($parts);
        $body = implode("\r\n\r\n", $parts);

        if (@unserialize($body) === false) {
            throw new \RuntimeException(sprintf("Error: %s", $response));
        }

        return $body;
    }

    protected function request(Code $code)
    {
        $file = $this->createTemporaryFile();

        $this->logger->info(sprintf('FastCGI: Dumped code to file: %s', $file));

        try {
            $code->writeTo($file);

            $environment = array(
                'REQUEST_METHOD'  => 'POST',
                'REQUEST_URI'     => '/',
                'SCRIPT_FILENAME' => $file,
            );

            $response = $this->client->request($environment, '');
            $this->logger->debug(sprintf('FastCGI: Response: %s', json_encode($response)));

            @unlink($file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            return $response;
        } catch (\Exception $e) {
            @unlink($file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            throw new \RuntimeException(
                sprintf('FastCGI error: %s (%s)', $e->getMessage(), $this->host),
                $e->getCode(),
                $e
            );
        }
    }
}


1			<?php
2
3			/*
4			* This file is part of CacheTool.
5			*
6			* (c) Samuel Gordalina <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace CacheTool\Adapter;
13
14			use CacheTool\Code;
15			use Adoy\FastCGI\Client;
16
17			class FastCGI extends AbstractAdapter
18			{
19			/**
20			* @var Client
21			*/
22			protected $client;
23
24			/**
25			* @var string
26			*/
27			protected $host;
28
29			/**
30			* @param string $host 127.0.0.1:9000 or /var/run/php5-fpm.sock
31			* @param string $tempDir
32			*/
33			public function __construct($host = null, $tempDir = null)
			0 ignored issues – show Unused Code introduced 2016-03-18 15:50 UTC by Report Bug Copy Issue Report The parameter `$tempDir` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
34			{
35			// try to guess where it is
36			if ($host === null) {
37			if (file_exists('/var/run/php5-fpm.sock')) {
38			$host = '/var/run/php5-fpm.sock';
39			} else {
40			$host = '127.0.0.1:9000';
41			}
42			}
43
44			$this->host = $host;
45
46			if (false !== strpos($host, ':')) {
47			list($host, $port) = explode(':', $host);
48			$this->client = new Client($host, $port);
49			} else {
50			// socket
51			$this->client = new Client('unix://' . $host, -1);
52			}
53
54			$this->client->setReadWriteTimeout(60 * 1000);
55			$this->client->setPersistentSocket(false);
56			$this->client->setKeepAlive(true);
57			}
58
59			/**
60			* {@inheritdoc}
61			*/
62			protected function doRun(Code $code)
63			{
64			$response = $this->request($code);
65			$parts = explode("\r\n\r\n", $response);
66
67			// remove headers
68			array_shift($parts);
69			$body = implode("\r\n\r\n", $parts);
70
71			if (@unserialize($body) === false) {
72			throw new \RuntimeException(sprintf("Error: %s", $response));
73			}
74
75			return $body;
76			}
77
78			protected function request(Code $code)
79			{
80			$file = $this->createTemporaryFile();
81
82			$this->logger->info(sprintf('FastCGI: Dumped code to file: %s', $file));
83
84			try {
85			$code->writeTo($file);
86
87			$environment = array(
88			'REQUEST_METHOD' => 'POST',
89			'REQUEST_URI' => '/',
90			'SCRIPT_FILENAME' => $file,
91			);
92
93			$response = $this->client->request($environment, '');
94			$this->logger->debug(sprintf('FastCGI: Response: %s', json_encode($response)));
95
96			@unlink($file);
			0 ignored issues – show Security Best Practice introduced 2016-03-18 15:50 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
97			return $response;
98			} catch (\Exception $e) {
99			@unlink($file);
			0 ignored issues – show Security Best Practice introduced 2016-03-18 15:50 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
100
101			throw new \RuntimeException(
102			sprintf('FastCGI error: %s (%s)', $e->getMessage(), $this->host),
103			$e->getCode(),
104			$e
105			);
106			}
107			}
108			}
109

gordalina / cachetool

Push — 1.x ( 8c31f4...5f4811 )

FastCGI::request() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like