FastCGI::__construct() - Code Metrics - Inspection of "Merge pull request #57 from scuben/web-adapter" - gordalina/cachetool - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 17f397...dedab2 )

by Samuel

created 2017-10-01 16:42 UTC

FastCGI::__construct() B

↳ Parent: FastCGI

Complexity

Conditions	6
Paths	14

Size

Total Lines	30
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	19
CRAP Score	6.0913

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
c	2
b	0
f	0
dl	0
loc	30
ccs	19
cts	22
cp	0.8636
rs	8.439
cc	6
eloc	18
nc	14
nop	2
crap	6.0913

<?php

/*
 * This file is part of CacheTool.
 *
 * (c) Samuel Gordalina <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace CacheTool\Adapter;

use CacheTool\Code;
use Adoy\FastCGI\Client;

class FastCGI extends AbstractAdapter
{
    /**
     * @var Client
     */
    protected $client;

    /**
     * @var Array of patterns matching php socket files
     */
    protected $possibleSocketFilePatterns = [
        '/var/run/php*.sock',
        '/var/run/php/*.sock'
    ];

    /**
     * @var string
     */
    protected $host;

    /**
     * @param string $host 127.0.0.1:9000 or /var/run/php5-fpm.sock
     * @param string $tempDir
     */
    public function __construct($host = null, $tempDir = null)

    {
        // try to guess where it is
        if ($host === null) {
            foreach ($this->possibleSocketFilePatterns as $possibleSocketFilePattern) {
                $possibleSocketFile = current(glob($possibleSocketFilePattern));
                if (file_exists($possibleSocketFile)) {
                    $host = $possibleSocketFile;
                    break;
                }
            }
            if ($host === null) {
                $host = '127.0.0.1:9000';
            }
        }

        $this->host = $host;

        if (false !== strpos($host, ':')) {
            list($host, $port) = explode(':', $host);
            $this->client = new Client($host, $port);
        } else {
            // socket
            $this->client = new Client('unix://' . $host, -1);
        }

        $this->client->setReadWriteTimeout(60 * 1000);
        $this->client->setPersistentSocket(false);
        $this->client->setKeepAlive(true);
    }

    /**
     * {@inheritdoc}
     */
    protected function doRun(Code $code)
    {
        $response = $this->request($code);
        $parts = explode("\r\n\r\n", $response);

        // remove headers
        array_shift($parts);
        $body = implode("\r\n\r\n", $parts);

        if (@unserialize($body) === false) {
            throw new \RuntimeException(sprintf("Error: %s", $response));
        }

        return $body;
    }

    protected function request(Code $code)
    {
        $file = $this->createTemporaryFile();

        $this->logger->info(sprintf('FastCGI: Dumped code to file: %s', $file));

        try {
            $code->writeTo($file);

            $environment = array(
                'REQUEST_METHOD'  => 'POST',
                'REQUEST_URI'     => '/',
                'SCRIPT_FILENAME' => $file,
            );

            $response = $this->client->request($environment, '');
            $this->logger->debug(sprintf('FastCGI: Response: %s', json_encode($response)));

            @unlink($file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}
            return $response;
        } catch (\Exception $e) {
            @unlink($file);
// For example instead of
@mkdir($dir);

// Better use
if (@mkdir($dir) === false) {
    throw new \RuntimeException('The directory '.$dir.' could not be created.');
}

            throw new \RuntimeException(
                sprintf('FastCGI error: %s (%s)', $e->getMessage(), $this->host),
                $e->getCode(),
                $e
            );
        }
    }
}


1		<?php
2
3		/*
4		* This file is part of CacheTool.
5		*
6		* (c) Samuel Gordalina <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		namespace CacheTool\Adapter;
13
14		use CacheTool\Code;
15		use Adoy\FastCGI\Client;
16
17		class FastCGI extends AbstractAdapter
18		{
19		/**
20		* @var Client
21		*/
22		protected $client;
23
24		/**
25		* @var Array of patterns matching php socket files
26		*/
27		protected $possibleSocketFilePatterns = [
28		'/var/run/php*.sock',
29		'/var/run/php/*.sock'
30		];
31
32		/**
33		* @var string
34		*/
35		protected $host;
36
37		/**
38		* @param string $host 127.0.0.1:9000 or /var/run/php5-fpm.sock
39		* @param string $tempDir
40		*/
41	3	public function __construct($host = null, $tempDir = null)
		0 ignored issues – show Unused Code introduced 2017-10-01 16:34 UTC by Report Bug Copy Issue Report The parameter `$tempDir` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
42		{
43		// try to guess where it is
44	3	if ($host === null) {
45	2	foreach ($this->possibleSocketFilePatterns as $possibleSocketFilePattern) {
46	2	$possibleSocketFile = current(glob($possibleSocketFilePattern));
47	2	if (file_exists($possibleSocketFile)) {
48		$host = $possibleSocketFile;
49		break;
50		}
51	2	}
52	2	if ($host === null) {
53	2	$host = '127.0.0.1:9000';
54	2	}
55	2	}
56
57	3	$this->host = $host;
58
59	3	if (false !== strpos($host, ':')) {
60	3	list($host, $port) = explode(':', $host);
61	3	$this->client = new Client($host, $port);
62	3	} else {
63		// socket
64		$this->client = new Client('unix://' . $host, -1);
65		}
66
67	3	$this->client->setReadWriteTimeout(60 * 1000);
68	3	$this->client->setPersistentSocket(false);
69	3	$this->client->setKeepAlive(true);
70	3	}
71
72		/**
73		* {@inheritdoc}
74		*/
75		protected function doRun(Code $code)
76		{
77		$response = $this->request($code);
78		$parts = explode("\r\n\r\n", $response);
79
80		// remove headers
81		array_shift($parts);
82		$body = implode("\r\n\r\n", $parts);
83
84		if (@unserialize($body) === false) {
85		throw new \RuntimeException(sprintf("Error: %s", $response));
86		}
87
88		return $body;
89		}
90
91		protected function request(Code $code)
92		{
93		$file = $this->createTemporaryFile();
94
95		$this->logger->info(sprintf('FastCGI: Dumped code to file: %s', $file));
96
97		try {
98		$code->writeTo($file);
99
100		$environment = array(
101		'REQUEST_METHOD' => 'POST',
102		'REQUEST_URI' => '/',
103		'SCRIPT_FILENAME' => $file,
104		);
105
106		$response = $this->client->request($environment, '');
107		$this->logger->debug(sprintf('FastCGI: Response: %s', json_encode($response)));
108
109		@unlink($file);
		0 ignored issues – show Security Best Practice introduced 2017-03-07 15:58 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
110		return $response;
111		} catch (\Exception $e) {
112		@unlink($file);
		0 ignored issues – show Security Best Practice introduced 2017-03-07 16:10 UTC by Report Bug Copy Issue Report It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended. If you suppress an error, we recommend checking for the error condition explicitly: // For example instead of @mkdir($dir); // Better use if (@mkdir($dir) === false) { throw new \RuntimeException('The directory '.$dir.' could not be created.'); } Loading history...
113
114		throw new \RuntimeException(
115		sprintf('FastCGI error: %s (%s)', $e->getMessage(), $this->host),
116		$e->getCode(),
117		$e
118		);
119		}
120		}
121		}
122

gordalina / cachetool

Push — master ( 17f397...dedab2 )

FastCGI::__construct() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like