TrackingStatus::toArray() - Code Metrics - Inspection of "Merge pull request #9 from gong023/enable_tracking..." - gong023/shippo-http-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d2378f...d01cde )

by Sho

created 2016-02-10 00:32 UTC

TrackingStatus::toArray() A

↳ Parent: TrackingStatus

Complexity

Conditions	1
Paths	1

Size

Total Lines	12
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	4
Bugs	1	Features	1

Metric	Value
c	4
b	1
f	1
dl	0
loc	12
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php

namespace ShippoClient\Entity;

use TurmericSpice\ReadableAttributes;

class TrackingStatus
{
    use ReadableAttributes {
        mayHaveAsString as public getStatusDetails;
        mayHaveAsString as public getStatusDate;
        toArray as __toArray;
    }

    /**
     * Date and time of object creation.
     *
     * @return \DateTime
     */
    public function getObjectCreated()
    {
        return $this->attributes->mayHave('object_created')->asInstanceOf('\\DateTime');
class MyClass { }

$x = new MyClass();
$x->foo = true;
    }

    /**
     * Date and time of last object update.
     *
     * @return \DateTime
     */
    public function getObjectUpdated()
    {
        return $this->attributes->mayHave('object_updated')->asInstanceOf('\\DateTime');
    }

    /**
     * Unique identifier of the given object.
     *
     * @return string
     */
    public function getObjectId()
    {
        return $this->attributes->mayHave('object_id')->asString();
    }

    /**
     * Package status.
     *  - "UNKNOWN"   The package has not been found via the carrier's tracking system,
     *                or it has been found but not yet scanned by the carrier.
     *  - "TRANSIT"   The package has been scanned by the carrier and is in transit.
     *  - "DELIVERED" The package has been successfully delivered.
     *  - "RETURNED"  The package is en route to be returned to the sender, or has been returned successfully.
     *  - "FAILURE"   The carrier indicated that there has been an issue with the delivery.
     *                This can happen for various reasons and depends on the carrier.
     *                This status does not indicate a technical error, but rather a delivery issue.
     *
     * @return string
     */
    public function getStatus()
    {
        return $this->attributes->mayHave('status')->asString();
    }

    /**
     * @return Location
     */
    public function getLocation()
    {
        $attributes = $this->attributes->mayHave('location')->asArray();
        return new Location($attributes);
    }

    public function toArray()
    {
        return [
            'object_created' => $this->getObjectCreated(),
            'object_updated' => $this->getObjectUpdated(),
            'object_id'      => $this->getObjectId(),
            'status'         => $this->getStatus(),
            'status_date'    => $this->getStatusDate(),
            'status_details' => $this->getStatusDetails(),

            'location'       => $this->getLocation()->toArray(),
        ];
    }
}


1			<?php
2
3			namespace ShippoClient\Entity;
4
5			use TurmericSpice\ReadableAttributes;
6
7			class TrackingStatus
8			{
9			use ReadableAttributes {
10			mayHaveAsString as public getStatusDetails;
11			mayHaveAsString as public getStatusDate;
12			toArray as __toArray;
13			}
14
15			/**
16			* Date and time of object creation.
17			*
18			* @return \DateTime
19			*/
20			public function getObjectCreated()
21			{
22			return $this->attributes->mayHave('object_created')->asInstanceOf('\\DateTime');
			0 ignored issues – show Bug introduced 2015-12-17 08:34 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
23			}
24
25			/**
26			* Date and time of last object update.
27			*
28			* @return \DateTime
29			*/
30			public function getObjectUpdated()
31			{
32			return $this->attributes->mayHave('object_updated')->asInstanceOf('\\DateTime');
33			}
34
35			/**
36			* Unique identifier of the given object.
37			*
38			* @return string
39			*/
40			public function getObjectId()
41			{
42			return $this->attributes->mayHave('object_id')->asString();
43			}
44
45			/**
46			* Package status.
47			* - "UNKNOWN" The package has not been found via the carrier's tracking system,
48			* or it has been found but not yet scanned by the carrier.
49			* - "TRANSIT" The package has been scanned by the carrier and is in transit.
50			* - "DELIVERED" The package has been successfully delivered.
51			* - "RETURNED" The package is en route to be returned to the sender, or has been returned successfully.
52			* - "FAILURE" The carrier indicated that there has been an issue with the delivery.
53			* This can happen for various reasons and depends on the carrier.
54			* This status does not indicate a technical error, but rather a delivery issue.
55			*
56			* @return string
57			*/
58			public function getStatus()
59			{
60			return $this->attributes->mayHave('status')->asString();
61			}
62
63			/**
64			* @return Location
65			*/
66			public function getLocation()
67			{
68			$attributes = $this->attributes->mayHave('location')->asArray();
69			return new Location($attributes);
70			}
71
72			public function toArray()
73			{
74			return [
75			'object_created' => $this->getObjectCreated(),
76			'object_updated' => $this->getObjectUpdated(),
77			'object_id' => $this->getObjectId(),
78			'status' => $this->getStatus(),
79			'status_date' => $this->getStatusDate(),
80			'status_details' => $this->getStatusDetails(),
			0 ignored issues – show Bug introduced 2016-01-28 23:03 UTC by Report Bug Copy Issue Report The method `getStatusDetails()` does not exist on `ShippoClient\Entity\TrackingStatus`. Did you maybe mean `getStatus()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
81			'location' => $this->getLocation()->toArray(),
82			];
83			}
84			}
85

gong023 / shippo-http-client

GitHub Access Token became invalid

Push — master ( d2378f...d01cde )

TrackingStatus::toArray() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like