Address::mustHaveAsAsciiString() - Code Metrics - Inspection of "Only ascii characters are used in addresses" - gong023/shippo-http-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#12)

unknown

created 2016-05-03 03:24 UTC

Address::mustHaveAsAsciiString() A

↳ Parent: Address

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	2

<?php

namespace ShippoClient\Entity;

use TurmericSpice\Container;
use TurmericSpice\ReadableAttributes;

class Address extends ObjectInformation
{
    use ReadableAttributes {
        mayHaveAsString as public getZip;
        mayHaveAsString as public getCountry;
        mayHaveAsString as public getPhone;
        mayHaveAsString as public getEmail;
        mayHaveAsString as public getIp;
        mayHaveAsString as public getMetadata;
        mayHaveAsArray  as public getMessages;
    }

    public function getName()
    {
        return $this->mayHaveAsAsciiString('name');
    }

    public function getCompany()
    {
        return $this->mayHaveAsAsciiString('company');
    }

    public function getStreet1()
    {
        return $this->mayHaveAsAsciiString('street1');
    }

    public function getStreet2()
    {
        return $this->mayHaveAsAsciiString('street2');
    }

    public function getStreetNo()
    {
        return $this->mayHaveAsAsciiString('street_no');
    }

    public function getCity()
    {
        return $this->mayHaveAsAsciiString('city');
    }

    public function getState()
    {
        return $this->mayHaveAsAsciiString('state');
    }

    public function getIsResidential()

    {
        $is_residential = $this->attributes->mayHave('is_residential')->value();
class MyClass { }

$x = new MyClass();
$x->foo = true;
        if ($is_residential === null) {
            return null;
        }

        return (bool)$is_residential;
    }

    private function mayHaveAsAsciiString($propertyName, callable $validate = null)
    {
        return $this->transliterateToAscii(
            $this->attributes->mayHave($propertyName)->asString($validate)
        );
    }

    private function mustHaveAsAsciiString($propertyName, callable $validate = null)
    {
        return $this->transliterateToAscii(
            $this->attributes->mustHave($propertyName)->asString($validate)
        );
    }

    private function transliterateToAscii($str)
    {
        $ret = '';
        foreach (preg_split('//u', $str) as $ch) {
            $ch = @iconv('UTF-8', 'ASCII//TRANSLIT//IGNORE', $ch);
            if (strlen($ch) > 1) {
                $ch = preg_replace('/[^0-9A-Za-z]/', '', $ch);
            }
            $ret .= $ch;
        }
        return $ret;
    }
}


1		<?php
2
3		namespace ShippoClient\Entity;
4
5		use TurmericSpice\Container;
6		use TurmericSpice\ReadableAttributes;
7
8		class Address extends ObjectInformation
9		{
10		use ReadableAttributes {
11		mayHaveAsString as public getZip;
12		mayHaveAsString as public getCountry;
13		mayHaveAsString as public getPhone;
14		mayHaveAsString as public getEmail;
15		mayHaveAsString as public getIp;
16		mayHaveAsString as public getMetadata;
17		mayHaveAsArray as public getMessages;
18		}
19
20		public function getName()
21		{
22		return $this->mayHaveAsAsciiString('name');
23		}
24
25		public function getCompany()
26		{
27		return $this->mayHaveAsAsciiString('company');
28		}
29
30		public function getStreet1()
31		{
32		return $this->mayHaveAsAsciiString('street1');
33		}
34
35		public function getStreet2()
36		{
37		return $this->mayHaveAsAsciiString('street2');
38		}
39
40		public function getStreetNo()
41		{
42		return $this->mayHaveAsAsciiString('street_no');
43		}
44
45		public function getCity()
46		{
47		return $this->mayHaveAsAsciiString('city');
48		}
49
50		public function getState()
51		{
52		return $this->mayHaveAsAsciiString('state');
53		}
54
55	View Code Duplication	public function getIsResidential()
		0 ignored issues – show Duplication introduced 2015-12-17 08:34 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
56		{
57		$is_residential = $this->attributes->mayHave('is_residential')->value();
		0 ignored issues – show Bug introduced 2015-12-17 08:34 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
58		if ($is_residential === null) {
59		return null;
60		}
61
62		return (bool)$is_residential;
63		}
64
65		private function mayHaveAsAsciiString($propertyName, callable $validate = null)
66		{
67		return $this->transliterateToAscii(
68		$this->attributes->mayHave($propertyName)->asString($validate)
69		);
70		}
71
72		private function mustHaveAsAsciiString($propertyName, callable $validate = null)
73		{
74		return $this->transliterateToAscii(
75		$this->attributes->mustHave($propertyName)->asString($validate)
76		);
77		}
78
79		private function transliterateToAscii($str)
80		{
81		$ret = '';
82		foreach (preg_split('//u', $str) as $ch) {
83		$ch = @iconv('UTF-8', 'ASCII//TRANSLIT//IGNORE', $ch);
84		if (strlen($ch) > 1) {
85		$ch = preg_replace('/[^0-9A-Za-z]/', '', $ch);
86		}
87		$ret .= $ch;
88		}
89		return $ret;
90		}
91		}
92

gong023 / shippo-http-client

GitHub Access Token became invalid

Pull Request — master (#12)

Address::mustHaveAsAsciiString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like