Tracks::getAddressTo() - Code Metrics - Inspection of "organize tracks object" - gong023/shippo-http-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#14)

by Sho

created 2016-08-04 23:38 UTC

Tracks::getAddressTo() A

↳ Parent: Tracks

Complexity

Conditions	1
Paths	1

Size

Total Lines	6
Code Lines	3

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	6
rs	9.4285
cc	1
eloc	3
nc	1
nop	0

<?php

namespace ShippoClient\Entity;

use TurmericSpice\ReadableAttributes;

class Tracks
{
    use ReadableAttributes {
        mayHaveAsString as public getCarrier;
        mayHaveAsString as public getTrackingNumber;
        mayHaveAsString as public getEta;
        toArray as public __toArray;
    }

    /**
     * @return \ShippoClient\Entity\TrackingStatus
     */
    public function getTrackingStatus()
    {
        return $this->attributes->mayHave('tracking_status')
class MyClass { }

$x = new MyClass();
$x->foo = true;
            ->asInstanceOf('\\ShippoClient\\Entity\\TrackingStatus');
    }

    /**
     * @return \ShippoClient\Entity\TrackingHistory
     */
    public function getTrackingHistory()
    {
        $entities = $this->attributes->mayHave('tracking_history')
            ->asInstanceArray('ShippoClient\\Entity\\TrackingStatus');

        return new TrackingHistory($entities);
    }

    /**
     * @return \ShippoClient\Entity\Location
     */
    public function getAddressFrom()
    {
        $addressFrom = $this->attributes->mayHave('address_from')->asArray();

        return new Location($addressFrom);
    }

    /**
     * @return \ShippoClient\Entity\Location
     */
    public function getAddressTo()
    {
        $addressTo = $this->attributes->mayHave('address_to')->asArray();

        return new Location($addressTo);
    }

    /**
     * @return \ShippoClient\Entity\ServiceLevel
     */
    public function getServiceLevel()
    {
        return $this->attributes->mayHave('servicelevel')->asInstanceOf('\\ShippoClient\\Entity\\ServiceLevel');
    }

    public function toArray()
    {
        return [
            'carrier'          => $this->getCarrier(),

            'tracking_number'  => $this->getTrackingNumber(),

            'tracking_status'  => $this->getTrackingStatus()->toArray(),
            'tracking_history' => $this->getTrackingHistory()->toArray(),
            'eta'              => $this->getEta(),
            'address_from'     => $this->getAddressFrom()->toArray(),
            'address_to'       => $this->getAddressTo()->toArray(),
            'servicelevel'     => $this->getServiceLevel()->toArray(),
        ];
    }
}


1			<?php
2
3			namespace ShippoClient\Entity;
4
5			use TurmericSpice\ReadableAttributes;
6
7			class Tracks
8			{
9			use ReadableAttributes {
10			mayHaveAsString as public getCarrier;
11			mayHaveAsString as public getTrackingNumber;
12			mayHaveAsString as public getEta;
13			toArray as public __toArray;
14			}
15
16			/**
17			* @return \ShippoClient\Entity\TrackingStatus
18			*/
19			public function getTrackingStatus()
20			{
21			return $this->attributes->mayHave('tracking_status')
			0 ignored issues – show Bug introduced 2016-08-04 20:03 UTC by Report Bug Copy Issue Report The property `attributes` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
22			->asInstanceOf('\\ShippoClient\\Entity\\TrackingStatus');
23			}
24
25			/**
26			* @return \ShippoClient\Entity\TrackingHistory
27			*/
28			public function getTrackingHistory()
29			{
30			$entities = $this->attributes->mayHave('tracking_history')
31			->asInstanceArray('ShippoClient\\Entity\\TrackingStatus');
32
33			return new TrackingHistory($entities);
34			}
35
36			/**
37			* @return \ShippoClient\Entity\Location
38			*/
39			public function getAddressFrom()
40			{
41			$addressFrom = $this->attributes->mayHave('address_from')->asArray();
42
43			return new Location($addressFrom);
44			}
45
46			/**
47			* @return \ShippoClient\Entity\Location
48			*/
49			public function getAddressTo()
50			{
51			$addressTo = $this->attributes->mayHave('address_to')->asArray();
52
53			return new Location($addressTo);
54			}
55
56			/**
57			* @return \ShippoClient\Entity\ServiceLevel
58			*/
59			public function getServiceLevel()
60			{
61			return $this->attributes->mayHave('servicelevel')->asInstanceOf('\\ShippoClient\\Entity\\ServiceLevel');
62			}
63
64			public function toArray()
65			{
66			return [
67			'carrier' => $this->getCarrier(),
			0 ignored issues – show Bug introduced 2016-08-04 20:03 UTC by Report Bug Copy Issue Report The method `getCarrier()` does not seem to exist on `object<ShippoClient\Entity\Tracks>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
68			'tracking_number' => $this->getTrackingNumber(),
			0 ignored issues – show Bug introduced 2016-08-04 20:18 UTC by Report Bug Copy Issue Report The method `getTrackingNumber()` does not seem to exist on `object<ShippoClient\Entity\Tracks>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
69			'tracking_status' => $this->getTrackingStatus()->toArray(),
70			'tracking_history' => $this->getTrackingHistory()->toArray(),
71			'eta' => $this->getEta(),
72			'address_from' => $this->getAddressFrom()->toArray(),
73			'address_to' => $this->getAddressTo()->toArray(),
74			'servicelevel' => $this->getServiceLevel()->toArray(),
75			];
76			}
77			}
78

gong023 / shippo-http-client

GitHub Access Token became invalid

Pull Request — master (#14)

Tracks::getAddressTo() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like