ShippoClientV2::rates() - Code Metrics - Inspection of "Supporting new Shippo API versioning." - gong023/shippo-http-client - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#17)

unknown

created 2017-03-28 01:42 UTC

ShippoClientV2::rates() A

↳ Parent: ShippoClientV2

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	0

<?php

namespace ShippoClient;

use ShippoClient\Http\Request\MockCollection;
use ShippoClient\Http\RequestV2;

class ShippoClientV2

{
    /**
     * @var RequestV2
     */
    private $request;

    /**
     * @var string
     */
    private $accessToken;

    /**
     * @var static|null
     */
    private static $instance = null;

    private function __construct(RequestV2 $request)
    {
        $this->request = $request;
    }

    public function addresses()
    {
        return new Addresses($this->request);
    }

    public function parcels()
    {
        return new Parcels($this->request);
    }

    public function shipments()
    {
        return new Shipments($this->request);
    }

    public function rates()
    {
        return new Rates($this->request);
    }

    public function transactions()
    {
        return new Transactions($this->request);
    }

    public function refunds()
    {
        return new Refunds($this->request);
    }

    public function tracks()
    {
        return new Tracks($this->request);
    }

    public function getAccessToken()
    {
        return $this->accessToken;
    }

    public function setRequestOption($keyOrPath, $value)
    {
        $this->request->setDefaultOption($keyOrPath, $value);

        return $this;
    }

    /**
     * @param string $accessToken
     * @param null|string $apiVersion
     * @return static
     */
    public static function provider($accessToken, $apiVersion = null)
    {
        if (static::$instance !== null && static::$instance->getAccessToken() === $accessToken) {
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
            return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
        }

        static::$instance = new static(new RequestV2($accessToken, $apiVersion));
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}

        return static::$instance;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    public static function mock()
    {
        return MockCollection::getInstance();
    }
}


1		<?php
2
3		namespace ShippoClient;
4
5		use ShippoClient\Http\Request\MockCollection;
6		use ShippoClient\Http\RequestV2;
7
8	View Code Duplication	class ShippoClientV2
		0 ignored issues – show Duplication introduced 2017-03-27 13:09 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
9		{
10		/**
11		* @var RequestV2
12		*/
13		private $request;
14
15		/**
16		* @var string
17		*/
18		private $accessToken;
19
20		/**
21		* @var static\|null
22		*/
23		private static $instance = null;
24
25		private function __construct(RequestV2 $request)
26		{
27		$this->request = $request;
28		}
29
30		public function addresses()
31		{
32		return new Addresses($this->request);
33		}
34
35		public function parcels()
36		{
37		return new Parcels($this->request);
38		}
39
40		public function shipments()
41		{
42		return new Shipments($this->request);
43		}
44
45		public function rates()
46		{
47		return new Rates($this->request);
48		}
49
50		public function transactions()
51		{
52		return new Transactions($this->request);
53		}
54
55		public function refunds()
56		{
57		return new Refunds($this->request);
58		}
59
60		public function tracks()
61		{
62		return new Tracks($this->request);
63		}
64
65		public function getAccessToken()
66		{
67		return $this->accessToken;
68		}
69
70		public function setRequestOption($keyOrPath, $value)
71		{
72		$this->request->setDefaultOption($keyOrPath, $value);
73
74		return $this;
75		}
76
77		/**
78		* @param string $accessToken
79		* @param null\|string $apiVersion
80		* @return static
81		*/
82		public static function provider($accessToken, $apiVersion = null)
83		{
84		if (static::$instance !== null && static::$instance->getAccessToken() === $accessToken) {
		0 ignored issues – show Bug introduced 2017-03-27 13:09 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
85		return static::$instance;
		0 ignored issues – show Bug introduced 2017-03-27 13:09 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
86		}
87
88		static::$instance = new static(new RequestV2($accessToken, $apiVersion));
		0 ignored issues – show Bug introduced 2017-03-27 13:09 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history... Bug introduced 2017-03-27 13:09 UTC by Report Bug Copy Issue Report It seems like `$apiVersion` defined by parameter `$apiVersion` on line 82 can also be of type `string`; however, `ShippoClient\Http\RequestV2::__construct()` does only seem to accept `null`, maybe add an additional type check? This check looks at variables that have been passed in as parameters and are passed out again to other methods. If the outgoing method call has stricter type requirements than the method itself, an issue is raised. An additional type check may prevent trouble. Loading history...
89
90		return static::$instance;
		0 ignored issues – show Bug introduced 2017-03-27 13:09 UTC by Report Bug Copy Issue Report Since `$instance` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$instance` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
91		}
92
93		public static function mock()
94		{
95		return MockCollection::getInstance();
96		}
97		}
98

gong023 / shippo-http-client

GitHub Access Token became invalid

Pull Request — master (#17)

ShippoClientV2::rates() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like