CreateObjectByNested::getAddressTo() - Code Metrics - gong023/shippo-http-client - Measure and Improve Code Quality continuously with Scrutinizer

CreateObjectByNested::getAddressTo() A
last analyzed 2017-03-28 01:51 UTC

↳ Parent: CreateObjectByNested

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	1

Metric	Value
dl	0
loc	7
rs	9.4285
c	1
b	0
f	1
cc	1
eloc	4
nc	1
nop	0

<?php

namespace ShippoClient\Http\Request\Shipments;

use ShippoClient\Http\Request\Addresses\CreateObject as AddressCreate;
use ShippoClient\Http\Request\Parcels\CreateObject as ParcelCreate;

class CreateObjectByNested extends CreateObject
{
    public function getAddressFrom()
    {
        $addressFrom = $this->attributes->mustHave('address_from')->asArray();
        $addressFromObj = new AddressCreate($addressFrom);

        return $addressFromObj->toArray();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getAddressTo()
    {
        $addressTo = $this->attributes->mustHave('address_to')->asArray();
        $addressToObj = new AddressCreate($addressTo);

        return $addressToObj->toArray();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }

    public function getParcel()
    {
        $parcel = $this->attributes->mustHave('parcel')->asArray();
        $parcelObj = new ParcelCreate($parcel);

        return $parcelObj->toArray();
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
    }
}


1			<?php
2
3			namespace ShippoClient\Http\Request\Shipments;
4
5			use ShippoClient\Http\Request\Addresses\CreateObject as AddressCreate;
6			use ShippoClient\Http\Request\Parcels\CreateObject as ParcelCreate;
7
8			class CreateObjectByNested extends CreateObject
9			{
10			public function getAddressFrom()
11			{
12			$addressFrom = $this->attributes->mustHave('address_from')->asArray();
13			$addressFromObj = new AddressCreate($addressFrom);
14
15			return $addressFromObj->toArray();
			0 ignored issues – show Bug Best Practice introduced 2015-12-17 09:19 UTC by Report Bug Copy Issue Report The return type of `return $addressFromObj->toArray();` (`array`) is incompatible with the return type of the parent method `ShippoClient\Http\Reques...eObject::getAddressFrom` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
16			}
17
18			public function getAddressTo()
19			{
20			$addressTo = $this->attributes->mustHave('address_to')->asArray();
21			$addressToObj = new AddressCreate($addressTo);
22
23			return $addressToObj->toArray();
			0 ignored issues – show Bug Best Practice introduced 2015-12-17 09:19 UTC by Report Bug Copy Issue Report The return type of `return $addressToObj->toArray();` (`array`) is incompatible with the return type of the parent method `ShippoClient\Http\Reques...ateObject::getAddressTo` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
24			}
25
26			public function getParcel()
27			{
28			$parcel = $this->attributes->mustHave('parcel')->asArray();
29			$parcelObj = new ParcelCreate($parcel);
30
31			return $parcelObj->toArray();
			0 ignored issues – show Bug Best Practice introduced 2015-12-17 09:19 UTC by Report Bug Copy Issue Report The return type of `return $parcelObj->toArray();` (`array`) is incompatible with the return type of the parent method `ShippoClient\Http\Reques...CreateObject::getParcel` of type `string`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return 'Johannes'; } } class BlogPost extends Post { public function getAuthor() { return new Author('Johannes'); } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
32			}
33			}
34

gong023 / shippo-http-client

GitHub Access Token became invalid

CreateObjectByNested::getAddressTo() A last analyzed 2017-03-28 01:51 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

CreateObjectByNested::getAddressTo() A
last analyzed 2017-03-28 01:51 UTC