Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
7 | class Address extends ObjectInformation |
||
8 | { |
||
9 | use ReadableAttributes { |
||
10 | mayHaveAsString as public getName; |
||
11 | mayHaveAsString as public getCompany; |
||
12 | mayHaveAsString as public getStreet1; |
||
13 | mayHaveAsString as public getStreet2; |
||
14 | mayHaveAsString as public getStreetNo; |
||
15 | mayHaveAsString as public getCity; |
||
16 | mayHaveAsString as public getState; |
||
17 | mayHaveAsString as public getZip; |
||
18 | mayHaveAsString as public getCountry; |
||
19 | mayHaveAsString as public getPhone; |
||
20 | mayHaveAsString as public getEmail; |
||
21 | mayHaveAsString as public getIp; |
||
22 | mayHaveAsString as public getMetadata; |
||
23 | mayHaveAsArray as public getMessages; |
||
24 | } |
||
25 | |||
26 | View Code Duplication | public function getIsResidential() |
|
35 | } |
||
36 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.