Issues in ClassGenerator.php (master) - Issues in master - goetas/xsd2php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (100)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

lib/Php/ClassGenerator.php (10 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
namespace Goetas\Xsd\XsdToPhp\Php;

use Doctrine\Common\Inflector\Inflector;
use Goetas\Xsd\XsdToPhp\Php\Structure\PHPClass;
use Goetas\Xsd\XsdToPhp\Php\Structure\PHPClassOf;
use Goetas\Xsd\XsdToPhp\Php\Structure\PHPProperty;
use Zend\Code\Generator;
use Zend\Code\Generator\DocBlock\Tag\ParamTag;
use Zend\Code\Generator\DocBlock\Tag\PropertyTag;
use Zend\Code\Generator\DocBlock\Tag\ReturnTag;
use Zend\Code\Generator\DocBlockGenerator;
use Zend\Code\Generator\MethodGenerator;
use Zend\Code\Generator\ParameterGenerator;
use Zend\Code\Generator\PropertyGenerator;

class ClassGenerator
{

    private function handleBody(Generator\ClassGenerator $class, PHPClass $type)
    {
        foreach ($type->getProperties() as $prop) {
            if ($prop->getName() !== '__value') {
                $this->handleProperty($class, $prop);
            }
        }
        foreach ($type->getProperties() as $prop) {
            if ($prop->getName() !== '__value') {
                $this->handleMethod($class, $prop, $type);
            }
        }

        if (count($type->getProperties()) === 1 && $type->hasProperty('__value')) {
            return false;
        }

        return true;
    }

    private function isNativeType(PHPClass $class)
    {
        return !$class->getNamespace() && in_array($class->getName(), [
            'string',
            'int',
            'float',
            'integer',
            'boolean',
            'array',
            'mixed',
            'callable'
        ]);
    }

    private function getPhpType(PHPClass $class)
    {
        if (!$class->getNamespace()) {
            if ($this->isNativeType($class)) {
                return $class->getName();
            }
            return "\\" . $class->getName();
        }
        return "\\" . $class->getFullName();
    }

    private function handleValueMethod(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class, $all = true)

    {
        $type = $prop->getType();

        $docblock = new DocBlockGenerator('Construct');
        $paramTag = new ParamTag("value", "mixed");
        $paramTag->setTypes(($type ? $this->getPhpType($type) : "mixed"));

        $docblock->setTag($paramTag);

        $param = new ParameterGenerator("value");
        if ($type && !$this->isNativeType($type)) {
            $param->setType($this->getPhpType($type));
        }
        $method = new MethodGenerator("__construct", [
            $param
        ]);
        $method->setDocBlock($docblock);
        $method->setBody("\$this->value(\$value);");

        $generator->addMethodFromGenerator($method);

        $docblock = new DocBlockGenerator('Gets or sets the inner value');
        $paramTag = new ParamTag("value", "mixed");
        if ($type && $type instanceof PHPClassOf) {

            $paramTag->setTypes($this->getPhpType($type->getArg()
                    ->getType()) . "[]");
        } elseif ($type) {
            $paramTag->setTypes($this->getPhpType($prop->getType()));
        }
        $docblock->setTag($paramTag);

        $returnTag = new ReturnTag("mixed");

        if ($type && $type instanceof PHPClassOf) {

            $returnTag->setTypes($this->getPhpType($type->getArg()
                    ->getType()) . "[]");
        } elseif ($type) {
            $returnTag->setTypes($this->getPhpType($type));
        }
        $docblock->setTag($returnTag);

        $param = new ParameterGenerator("value");
        $param->setDefaultValue(null);

        if ($type && !$this->isNativeType($type)) {
            $param->setType($this->getPhpType($type));
        }
        $method = new MethodGenerator("value", []);
        $method->setDocBlock($docblock);

        $methodBody = "if (\$args = func_get_args()) {" . PHP_EOL;
        $methodBody .= "    \$this->" . $prop->getName() . " = \$args[0];" . PHP_EOL;
        $methodBody .= "}" . PHP_EOL;
        $methodBody .= "return \$this->" . $prop->getName() . ";" . PHP_EOL;
        $method->setBody($methodBody);

        $generator->addMethodFromGenerator($method);

        $docblock = new DocBlockGenerator('Gets a string value');
        $docblock->setTag(new ReturnTag("string"));
        $method = new MethodGenerator("__toString");
        $method->setDocBlock($docblock);
        $method->setBody("return strval(\$this->" . $prop->getName() . ");");
        $generator->addMethodFromGenerator($method);
    }

    private function handleSetter(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)

    {
        $methodBody = '';
        $docblock = new DocBlockGenerator();

        $docblock->setShortDescription("Sets a new " . $prop->getName());

        if ($prop->getDoc()) {
            $docblock->setLongDescription($prop->getDoc());
        }

        $patramTag = new ParamTag($prop->getName());
        $docblock->setTag($patramTag);

        $return = new ReturnTag("self");
        $docblock->setTag($return);

        $type = $prop->getType();

        $method = new MethodGenerator("set" . Inflector::classify($prop->getName()));

        $parameter = new ParameterGenerator($prop->getName(), "mixed");

        if ($type && $type instanceof PHPClassOf) {
            $patramTag->setTypes($this->getPhpType($type->getArg()
                    ->getType()) . "[]");
            $parameter->setType("array");

            if ($p = $this->isOneType($type->getArg()
                ->getType())
            ) {
                if (($t = $p->getType())) {
                    $patramTag->setTypes($this->getPhpType($t));
                }
            }
        } elseif ($type) {
            if ($this->isNativeType($type)) {
                $patramTag->setTypes($this->getPhpType($type));
            } elseif ($p = $this->isOneType($type)) {
                if (($t = $p->getType()) && !$this->isNativeType($t)) {
                    $patramTag->setTypes($this->getPhpType($t));
                    $parameter->setType($this->getPhpType($t));
                } elseif ($t && !$this->isNativeType($t)) {
                    $patramTag->setTypes($this->getPhpType($t));
                    $parameter->setType($this->getPhpType($t));
                } elseif ($t) {
                    $patramTag->setTypes($this->getPhpType($t));
                }
            } else {
                $patramTag->setTypes($this->getPhpType($type));
                $parameter->setType($this->getPhpType($type));
            }
        }

        $methodBody .= "\$this->" . $prop->getName() . " = \$" . $prop->getName() . ";" . PHP_EOL;
        $methodBody .= "return \$this;";
        $method->setBody($methodBody);
        $method->setDocBlock($docblock);
        $method->setParameter($parameter);

        $generator->addMethodFromGenerator($method);
    }

    private function handleGetter(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)

    {

        if ($prop->getType() instanceof PHPClassOf) {
            $docblock = new DocBlockGenerator();
            $docblock->setShortDescription("isset " . $prop->getName());
            if ($prop->getDoc()) {
                $docblock->setLongDescription($prop->getDoc());
            }

            $patramTag = new ParamTag("index", "scalar");
            $docblock->setTag($patramTag);

            $docblock->setTag(new ReturnTag("boolean"));

            $paramIndex = new ParameterGenerator("index", "mixed");

            $method = new MethodGenerator("isset" . Inflector::classify($prop->getName()), [$paramIndex]);
            $method->setDocBlock($docblock);
            $method->setBody("return isset(\$this->" . $prop->getName() . "[\$index]);");
            $generator->addMethodFromGenerator($method);

            $docblock = new DocBlockGenerator();
            $docblock->setShortDescription("unset " . $prop->getName());
            if ($prop->getDoc()) {
                $docblock->setLongDescription($prop->getDoc());
            }

            $patramTag = new ParamTag("index", "scalar");
            $docblock->setTag($patramTag);
            $paramIndex = new ParameterGenerator("index", "mixed");

            $docblock->setTag(new ReturnTag("void"));


            $method = new MethodGenerator("unset" . Inflector::classify($prop->getName()), [$paramIndex]);
            $method->setDocBlock($docblock);
            $method->setBody("unset(\$this->" . $prop->getName() . "[\$index]);");
            $generator->addMethodFromGenerator($method);
        }
        // ////

        $docblock = new DocBlockGenerator();

        $docblock->setShortDescription("Gets as " . $prop->getName());

        if ($prop->getDoc()) {
            $docblock->setLongDescription($prop->getDoc());
        }

        $tag = new ReturnTag("mixed");
        $type = $prop->getType();
        if ($type && $type instanceof PHPClassOf) {
            $tt = $type->getArg()->getType();
            $tag->setTypes($this->getPhpType($tt) . "[]");
            if ($p = $this->isOneType($tt)) {

                if (($t = $p->getType())) {
                    $tag->setTypes($this->getPhpType($t) . "[]");
                }
            }
        } elseif ($type) {

            if ($p = $this->isOneType($type)) {
                if ($t = $p->getType()) {
                    $tag->setTypes($this->getPhpType($t));
                }
            } else {
                $tag->setTypes($this->getPhpType($type));
            }
        }

        $docblock->setTag($tag);

        $method = new MethodGenerator("get" . Inflector::classify($prop->getName()));
        $method->setDocBlock($docblock);
        $method->setBody("return \$this->" . $prop->getName() . ";");

        $generator->addMethodFromGenerator($method);
    }

    private function isOneType(PHPClass $type, $onlyParent = false)
    {
        if ($onlyParent) {
            $e = $type->getExtends();
            if ($e) {
                if ($e->hasProperty('__value')) {
                    return $e->getProperty('__value');
                }
            }
        } else {
            if ($type->hasPropertyInHierarchy('__value') && count($type->getPropertiesInHierarchy()) === 1) {
                return $type->getPropertyInHierarchy("__value");
            }
        }
    }

    private function handleAdder(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)

    {
        $type = $prop->getType();
        $propName = $type->getArg()->getName();

        $docblock = new DocBlockGenerator();
        $docblock->setShortDescription("Adds as $propName");

        if ($prop->getDoc()) {
            $docblock->setLongDescription($prop->getDoc());
        }

        $return = new ReturnTag();
        $return->setTypes("self");
        $docblock->setTag($return);

        $patramTag = new ParamTag($propName, $this->getPhpType($type->getArg()
            ->getType()));
        $docblock->setTag($patramTag);

        $method = new MethodGenerator("addTo" . Inflector::classify($prop->getName()));

        $parameter = new ParameterGenerator($propName);
        $tt = $type->getArg()->getType();

        if (!$this->isNativeType($tt)) {

            if ($p = $this->isOneType($tt)) {
                if (($t = $p->getType())) {
                    $patramTag->setTypes($this->getPhpType($t));

                    if (!$this->isNativeType($t)) {
                        $parameter->setType($this->getPhpType($t));
                    }
                }
            } elseif (!$this->isNativeType($tt)) {
                $parameter->setType($this->getPhpType($tt));
            }
        }

        $methodBody = "\$this->" . $prop->getName() . "[] = \$" . $propName . ";" . PHP_EOL;
        $methodBody .= "return \$this;";
        $method->setBody($methodBody);
        $method->setDocBlock($docblock);
        $method->setParameter($parameter);

        $generator->addMethodFromGenerator($method);
    }

    private function handleMethod(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)
    {
        if ($prop->getType() instanceof PHPClassOf) {
            $this->handleAdder($generator, $prop, $class);
        }

        $this->handleGetter($generator, $prop, $class);
        $this->handleSetter($generator, $prop, $class);
    }

    private function handleProperty(Generator\ClassGenerator $class, PHPProperty $prop)
    {
        $generatedProp = new PropertyGenerator($prop->getName());
        $generatedProp->setVisibility(PropertyGenerator::VISIBILITY_PRIVATE);

        $class->addPropertyFromGenerator($generatedProp);

        if ($prop->getType() && (!$prop->getType()->getNamespace() && $prop->getType()->getName() == "array")) {
            // $generatedProp->setDefaultValue(array(), PropertyValueGenerator::TYPE_AUTO, PropertyValueGenerator::OUTPUT_SINGLE_LINE);
        }

        $docBlock = new DocBlockGenerator();
        $generatedProp->setDocBlock($docBlock);

        if ($prop->getDoc()) {
            $docBlock->setLongDescription($prop->getDoc());
        }
        $tag = new PropertyTag($prop->getName(), 'mixed');

        $type = $prop->getType();

        if ($type && $type instanceof PHPClassOf) {
            $tt = $type->getArg()->getType();
            $tag->setTypes($this->getPhpType($tt) . "[]");
            if ($p = $this->isOneType($tt)) {

                if (($t = $p->getType())) {
                    $tag->setTypes($this->getPhpType($t) . "[]");
                }
            }
        } elseif ($type) {

            if ($this->isNativeType($type)) {
                $tag->setTypes($this->getPhpType($type));
            } elseif (($p = $this->isOneType($type)) && ($t = $p->getType())) {

                $tag->setTypes($this->getPhpType($t));
            } else {
                $tag->setTypes($this->getPhpType($prop->getType()));
            }
        }
        $docBlock->setTag($tag);
    }

    public function generate(Generator\ClassGenerator $class, PHPClass $type)
    {
        $docblock = new DocBlockGenerator("Class representing " . $type->getName());
        if ($type->getDoc()) {
            $docblock->setLongDescription($type->getDoc());
        }
        $class->setNamespaceName($type->getNamespace() ?: NULL);
        $class->setName($type->getName());
        $class->setDocblock($docblock);

        if ($extends = $type->getExtends()) {

            if ($p = $this->isOneType($extends)) {
                $this->handleProperty($class, $p);
                $this->handleValueMethod($class, $p, $extends);
            } else {

                $class->setExtendedClass($extends->getName());

                if ($extends->getNamespace() != $type->getNamespace()) {
                    if ($extends->getName() == $type->getName()) {
                        $class->addUse($type->getExtends()
                            ->getFullName(), $extends->getName() . "Base");
                        $class->setExtendedClass($extends->getName() . "Base");
                    } else {
                        $class->addUse($extends->getFullName());
                    }
                }
            }
        }

        if ($this->handleBody($class, $type)) {
            return true;
        }
    }
}


1			<?php
2			namespace Goetas\Xsd\XsdToPhp\Php;
3
4			use Doctrine\Common\Inflector\Inflector;
5			use Goetas\Xsd\XsdToPhp\Php\Structure\PHPClass;
6			use Goetas\Xsd\XsdToPhp\Php\Structure\PHPClassOf;
7			use Goetas\Xsd\XsdToPhp\Php\Structure\PHPProperty;
8			use Zend\Code\Generator;
9			use Zend\Code\Generator\DocBlock\Tag\ParamTag;
10			use Zend\Code\Generator\DocBlock\Tag\PropertyTag;
11			use Zend\Code\Generator\DocBlock\Tag\ReturnTag;
12			use Zend\Code\Generator\DocBlockGenerator;
13			use Zend\Code\Generator\MethodGenerator;
14			use Zend\Code\Generator\ParameterGenerator;
15			use Zend\Code\Generator\PropertyGenerator;
16
17			class ClassGenerator
18			{
19
20	8		private function handleBody(Generator\ClassGenerator $class, PHPClass $type)
21			{
22	8		foreach ($type->getProperties() as $prop) {
23	7		if ($prop->getName() !== '__value') {
24	7		$this->handleProperty($class, $prop);
25	7		}
26	8		}
27	8		foreach ($type->getProperties() as $prop) {
28	7		if ($prop->getName() !== '__value') {
29	7		$this->handleMethod($class, $prop, $type);
30	7		}
31	8		}
32
33	8		if (count($type->getProperties()) === 1 && $type->hasProperty('__value')) {
34			return false;
35			}
36
37	8		return true;
38			}
39
40	8		private function isNativeType(PHPClass $class)
41			{
42	8		return !$class->getNamespace() && in_array($class->getName(), [
43	8		'string',
44	8		'int',
45	8		'float',
46	8		'integer',
47	8		'boolean',
48	8		'array',
49	8		'mixed',
50			'callable'
51	8		]);
52			}
53
54	8		private function getPhpType(PHPClass $class)
55			{
56	8		if (!$class->getNamespace()) {
57	8		if ($this->isNativeType($class)) {
58	8		return $class->getName();
59			}
60			return "\\" . $class->getName();
61			}
62	1		return "\\" . $class->getFullName();
63			}
64
65	2		private function handleValueMethod(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class, $all = true)
			0 ignored issues – show Unused Code introduced 2017-10-23 07:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$class` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history... Unused Code introduced 2017-10-23 07:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$all` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
66			{
67	2		$type = $prop->getType();
68
69	2		$docblock = new DocBlockGenerator('Construct');
70	2		$paramTag = new ParamTag("value", "mixed");
71	2		$paramTag->setTypes(($type ? $this->getPhpType($type) : "mixed"));
72
73	2		$docblock->setTag($paramTag);
74
75	2		$param = new ParameterGenerator("value");
76	2		if ($type && !$this->isNativeType($type)) {
77			$param->setType($this->getPhpType($type));
78			}
79	2		$method = new MethodGenerator("__construct", [
80			$param
81	2		]);
82	2		$method->setDocBlock($docblock);
83	2		$method->setBody("\$this->value(\$value);");
84
85	2		$generator->addMethodFromGenerator($method);
86
87	2		$docblock = new DocBlockGenerator('Gets or sets the inner value');
88	2		$paramTag = new ParamTag("value", "mixed");
89	2	View Code Duplication	if ($type && $type instanceof PHPClassOf) {
			0 ignored issues – show Duplication introduced 2016-05-21 21:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
90			$paramTag->setTypes($this->getPhpType($type->getArg()
91			->getType()) . "[]");
92	2		} elseif ($type) {
93	2		$paramTag->setTypes($this->getPhpType($prop->getType()));
94	2		}
95	2		$docblock->setTag($paramTag);
96
97	2		$returnTag = new ReturnTag("mixed");
98
99	2	View Code Duplication	if ($type && $type instanceof PHPClassOf) {
			0 ignored issues – show Duplication introduced 2016-05-21 21:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
100			$returnTag->setTypes($this->getPhpType($type->getArg()
101			->getType()) . "[]");
102	2		} elseif ($type) {
103	2		$returnTag->setTypes($this->getPhpType($type));
104	2		}
105	2		$docblock->setTag($returnTag);
106
107	2		$param = new ParameterGenerator("value");
108	2		$param->setDefaultValue(null);
109
110	2		if ($type && !$this->isNativeType($type)) {
111			$param->setType($this->getPhpType($type));
112			}
113	2		$method = new MethodGenerator("value", []);
114	2		$method->setDocBlock($docblock);
115
116	2		$methodBody = "if (\$args = func_get_args()) {" . PHP_EOL;
117	2		$methodBody .= " \$this->" . $prop->getName() . " = \$args[0];" . PHP_EOL;
118	2		$methodBody .= "}" . PHP_EOL;
119	2		$methodBody .= "return \$this->" . $prop->getName() . ";" . PHP_EOL;
120	2		$method->setBody($methodBody);
121
122	2		$generator->addMethodFromGenerator($method);
123
124	2		$docblock = new DocBlockGenerator('Gets a string value');
125	2		$docblock->setTag(new ReturnTag("string"));
126	2		$method = new MethodGenerator("__toString");
127	2		$method->setDocBlock($docblock);
128	2		$method->setBody("return strval(\$this->" . $prop->getName() . ");");
129	2		$generator->addMethodFromGenerator($method);
130	2		}
131
132	7		private function handleSetter(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)
			0 ignored issues – show Unused Code introduced 2017-10-23 07:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$class` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
133			{
134	7		$methodBody = '';
135	7		$docblock = new DocBlockGenerator();
136
137	7		$docblock->setShortDescription("Sets a new " . $prop->getName());
138
139	7		if ($prop->getDoc()) {
140			$docblock->setLongDescription($prop->getDoc());
141			}
142
143	7		$patramTag = new ParamTag($prop->getName());
144	7		$docblock->setTag($patramTag);
145
146	7		$return = new ReturnTag("self");
147	7		$docblock->setTag($return);
148
149	7		$type = $prop->getType();
150
151	7		$method = new MethodGenerator("set" . Inflector::classify($prop->getName()));
152
153	7		$parameter = new ParameterGenerator($prop->getName(), "mixed");
154
155	7		if ($type && $type instanceof PHPClassOf) {
156	4		$patramTag->setTypes($this->getPhpType($type->getArg()
157	4		->getType()) . "[]");
158	4		$parameter->setType("array");
159
160	4		if ($p = $this->isOneType($type->getArg()
161	4		->getType())
162	4		) {
163			if (($t = $p->getType())) {
164			$patramTag->setTypes($this->getPhpType($t));
165			}
166			}
167	7		} elseif ($type) {
168	3		if ($this->isNativeType($type)) {
169	3		$patramTag->setTypes($this->getPhpType($type));
170	3		} elseif ($p = $this->isOneType($type)) {
171			if (($t = $p->getType()) && !$this->isNativeType($t)) {
172			$patramTag->setTypes($this->getPhpType($t));
173			$parameter->setType($this->getPhpType($t));
174			} elseif ($t && !$this->isNativeType($t)) {
175			$patramTag->setTypes($this->getPhpType($t));
176			$parameter->setType($this->getPhpType($t));
177			} elseif ($t) {
178			$patramTag->setTypes($this->getPhpType($t));
179			}
180			} else {
181			$patramTag->setTypes($this->getPhpType($type));
182			$parameter->setType($this->getPhpType($type));
183			}
184	3		}
185
186	7		$methodBody .= "\$this->" . $prop->getName() . " = \$" . $prop->getName() . ";" . PHP_EOL;
187	7		$methodBody .= "return \$this;";
188	7		$method->setBody($methodBody);
189	7		$method->setDocBlock($docblock);
190	7		$method->setParameter($parameter);
191
192	7		$generator->addMethodFromGenerator($method);
193	7		}
194
195	7		private function handleGetter(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)
			0 ignored issues – show Unused Code introduced 2017-10-23 07:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$class` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
196			{
197
198	7		if ($prop->getType() instanceof PHPClassOf) {
199	4		$docblock = new DocBlockGenerator();
200	4		$docblock->setShortDescription("isset " . $prop->getName());
201	4		if ($prop->getDoc()) {
202			$docblock->setLongDescription($prop->getDoc());
203			}
204
205	4		$patramTag = new ParamTag("index", "scalar");
206	4		$docblock->setTag($patramTag);
207
208	4		$docblock->setTag(new ReturnTag("boolean"));
209
210	4		$paramIndex = new ParameterGenerator("index", "mixed");
211
212	4		$method = new MethodGenerator("isset" . Inflector::classify($prop->getName()), [$paramIndex]);
213	4		$method->setDocBlock($docblock);
214	4		$method->setBody("return isset(\$this->" . $prop->getName() . "[\$index]);");
215	4		$generator->addMethodFromGenerator($method);
216
217	4		$docblock = new DocBlockGenerator();
218	4		$docblock->setShortDescription("unset " . $prop->getName());
219	4		if ($prop->getDoc()) {
220			$docblock->setLongDescription($prop->getDoc());
221			}
222
223	4		$patramTag = new ParamTag("index", "scalar");
224	4		$docblock->setTag($patramTag);
225	4		$paramIndex = new ParameterGenerator("index", "mixed");
226
227	4		$docblock->setTag(new ReturnTag("void"));
228
229
230	4		$method = new MethodGenerator("unset" . Inflector::classify($prop->getName()), [$paramIndex]);
231	4		$method->setDocBlock($docblock);
232	4		$method->setBody("unset(\$this->" . $prop->getName() . "[\$index]);");
233	4		$generator->addMethodFromGenerator($method);
234	4		}
235			// ////
236
237	7		$docblock = new DocBlockGenerator();
238
239	7		$docblock->setShortDescription("Gets as " . $prop->getName());
240
241	7		if ($prop->getDoc()) {
242			$docblock->setLongDescription($prop->getDoc());
243			}
244
245	7		$tag = new ReturnTag("mixed");
246	7		$type = $prop->getType();
247	7		if ($type && $type instanceof PHPClassOf) {
248	4		$tt = $type->getArg()->getType();
249	4		$tag->setTypes($this->getPhpType($tt) . "[]");
250	4	View Code Duplication	if ($p = $this->isOneType($tt)) {
			0 ignored issues – show Duplication introduced 2016-05-21 21:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
251			if (($t = $p->getType())) {
252			$tag->setTypes($this->getPhpType($t) . "[]");
253			}
254			}
255	7		} elseif ($type) {
256
257	3		if ($p = $this->isOneType($type)) {
258			if ($t = $p->getType()) {
259			$tag->setTypes($this->getPhpType($t));
260			}
261			} else {
262	3		$tag->setTypes($this->getPhpType($type));
263			}
264	3		}
265
266	7		$docblock->setTag($tag);
267
268	7		$method = new MethodGenerator("get" . Inflector::classify($prop->getName()));
269	7		$method->setDocBlock($docblock);
270	7		$method->setBody("return \$this->" . $prop->getName() . ";");
271
272	7		$generator->addMethodFromGenerator($method);
273	7		}
274
275	8		private function isOneType(PHPClass $type, $onlyParent = false)
276			{
277	8		if ($onlyParent) {
278			$e = $type->getExtends();
279			if ($e) {
280			if ($e->hasProperty('__value')) {
281			return $e->getProperty('__value');
282			}
283			}
284			} else {
285	8		if ($type->hasPropertyInHierarchy('__value') && count($type->getPropertiesInHierarchy()) === 1) {
286	2		return $type->getPropertyInHierarchy("__value");
287			}
288			}
289	7		}
290
291	4		private function handleAdder(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)
			0 ignored issues – show Unused Code introduced 2017-10-23 07:32 UTC by Report Bug Copy Issue Report Show Similar Issues like this The parameter `$class` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
292			{
293	4		$type = $prop->getType();
294	4		$propName = $type->getArg()->getName();
295
296	4		$docblock = new DocBlockGenerator();
297	4		$docblock->setShortDescription("Adds as $propName");
298
299	4		if ($prop->getDoc()) {
300			$docblock->setLongDescription($prop->getDoc());
301			}
302
303	4		$return = new ReturnTag();
304	4		$return->setTypes("self");
305	4		$docblock->setTag($return);
306
307	4		$patramTag = new ParamTag($propName, $this->getPhpType($type->getArg()
308	4		->getType()));
309	4		$docblock->setTag($patramTag);
310
311	4		$method = new MethodGenerator("addTo" . Inflector::classify($prop->getName()));
312
313	4		$parameter = new ParameterGenerator($propName);
314	4		$tt = $type->getArg()->getType();
315
316	4		if (!$this->isNativeType($tt)) {
317
318	1		if ($p = $this->isOneType($tt)) {
319			if (($t = $p->getType())) {
320			$patramTag->setTypes($this->getPhpType($t));
321
322			if (!$this->isNativeType($t)) {
323			$parameter->setType($this->getPhpType($t));
324			}
325			}
326	1		} elseif (!$this->isNativeType($tt)) {
327	1		$parameter->setType($this->getPhpType($tt));
328	1		}
329	1		}
330
331	4		$methodBody = "\$this->" . $prop->getName() . "[] = \$" . $propName . ";" . PHP_EOL;
332	4		$methodBody .= "return \$this;";
333	4		$method->setBody($methodBody);
334	4		$method->setDocBlock($docblock);
335	4		$method->setParameter($parameter);
336
337	4		$generator->addMethodFromGenerator($method);
338	4		}
339
340	7		private function handleMethod(Generator\ClassGenerator $generator, PHPProperty $prop, PHPClass $class)
341			{
342	7		if ($prop->getType() instanceof PHPClassOf) {
343	4		$this->handleAdder($generator, $prop, $class);
344	4		}
345
346	7		$this->handleGetter($generator, $prop, $class);
347	7		$this->handleSetter($generator, $prop, $class);
348	7		}
349
350	8		private function handleProperty(Generator\ClassGenerator $class, PHPProperty $prop)
351			{
352	8		$generatedProp = new PropertyGenerator($prop->getName());
353	8		$generatedProp->setVisibility(PropertyGenerator::VISIBILITY_PRIVATE);
354
355	8		$class->addPropertyFromGenerator($generatedProp);
356
357	8		if ($prop->getType() && (!$prop->getType()->getNamespace() && $prop->getType()->getName() == "array")) {
358			// $generatedProp->setDefaultValue(array(), PropertyValueGenerator::TYPE_AUTO, PropertyValueGenerator::OUTPUT_SINGLE_LINE);
359	4		}
360
361	8		$docBlock = new DocBlockGenerator();
362	8		$generatedProp->setDocBlock($docBlock);
363
364	8		if ($prop->getDoc()) {
365			$docBlock->setLongDescription($prop->getDoc());
366			}
367	8		$tag = new PropertyTag($prop->getName(), 'mixed');
368
369	8		$type = $prop->getType();
370
371	8		if ($type && $type instanceof PHPClassOf) {
372	4		$tt = $type->getArg()->getType();
373	4		$tag->setTypes($this->getPhpType($tt) . "[]");
374	4	View Code Duplication	if ($p = $this->isOneType($tt)) {
			0 ignored issues – show Duplication introduced 2016-05-21 21:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
375			if (($t = $p->getType())) {
376			$tag->setTypes($this->getPhpType($t) . "[]");
377			}
378			}
379	8		} elseif ($type) {
380
381	4		if ($this->isNativeType($type)) {
382	4		$tag->setTypes($this->getPhpType($type));
383	4	View Code Duplication	} elseif (($p = $this->isOneType($type)) && ($t = $p->getType())) {
			0 ignored issues – show Duplication introduced 2016-05-21 21:41 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
384			$tag->setTypes($this->getPhpType($t));
385			} else {
386			$tag->setTypes($this->getPhpType($prop->getType()));
387			}
388	4		}
389	8		$docBlock->setTag($tag);
390	8		}
391
392	8		public function generate(Generator\ClassGenerator $class, PHPClass $type)
393			{
394	8		$docblock = new DocBlockGenerator("Class representing " . $type->getName());
395	8		if ($type->getDoc()) {
396	8		$docblock->setLongDescription($type->getDoc());
397	8		}
398	8		$class->setNamespaceName($type->getNamespace() ?: NULL);
399	8		$class->setName($type->getName());
400	8		$class->setDocblock($docblock);
401
402	8		if ($extends = $type->getExtends()) {
403
404	2		if ($p = $this->isOneType($extends)) {
405	2		$this->handleProperty($class, $p);
406	2		$this->handleValueMethod($class, $p, $extends);
407	2		} else {
408
409			$class->setExtendedClass($extends->getName());
410
411			if ($extends->getNamespace() != $type->getNamespace()) {
412			if ($extends->getName() == $type->getName()) {
413			$class->addUse($type->getExtends()
414			->getFullName(), $extends->getName() . "Base");
415			$class->setExtendedClass($extends->getName() . "Base");
416			} else {
417			$class->addUse($extends->getFullName());
418			}
419			}
420			}
421	2		}
422
423	8		if ($this->handleBody($class, $type)) {
424	8		return true;
425			}
426			}
427			}
428

goetas / xsd2php

Issues (100)

Security Analysis no request data

lib/Php/ClassGenerator.php (10 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like