Goetas\TwitalBundle\EventSubscriber\WhiteSpaceRemovalSubscriber

Complexity

Total Complexity

19

Size/Duplication

Total Lines	71
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Test Coverage

Coverage

95%

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	performXpathQuery()	0	8	2
A	__construct()	0	5	1
A	getSubscribedEvents()	0	6	1
D	removeWhitespace()	0	27	10
B	isAllowedNode()	0	13	5

<?php
namespace Goetas\TwitalBundle\EventSubscriber;

use Symfony\Component\EventDispatcher\EventSubscriberInterface;
use Goetas\Twital\EventDispatcher\TemplateEvent;
use Goetas\Twital\Twital;

/**
 *
 * @author Asmir Mustafic <goetas@gmail.com>
 *
 */
class WhiteSpaceRemovalSubscriber implements EventSubscriberInterface
{

    protected $allowedTags = array();

    protected $allowedNamespaces = array();

    public function __construct(array $allowedTags = array(), array $allowedNamespaces = array())
    {
        $this->allowedTags = $allowedTags;
        $this->allowedNamespaces = $allowedNamespaces;
    }

    public static function getSubscribedEvents()
    {
        return array(
            'compiler.post_load' => array('removeWhitespace', -10)
        );
    }

    private function performXpathQuery(\DOMXPath $xp, $query, \DOMNode $ref)
    {
        if (defined('HHVM_VERSION')) {
            return $xp->query($query, $ref);
        } else {
            return $xp->query($query, $ref, false);
        }
    }

    public function removeWhitespace(TemplateEvent $event)
    {
        $doc = $event->getTemplate()->getDocument();

        $xp = new \DOMXPath($doc);
        $xp->registerNamespace("t", Twital::NS);

        foreach ($this->performXpathQuery($xp, "//text()[ancestor::*[@t:trans or @t:trans-n]]", $doc) as $text) {
            if ($this->isAllowedNode($text->parentNode)) {
                $text->data = preg_replace('/\s+/', ' ', $text->data);

                if ($text->parentNode->childNodes->length === 1) {
                    $trimmed = trim($text->data);
                    if (!strlen($trimmed) && strlen($text->data)) {
                        $trimmed = " ";
                    }
                    $text->data = $trimmed;
                } elseif ($text->parentNode->hasAttributeNs(Twital::NS, 'trans') || $text->parentNode->hasAttributeNs(Twital::NS, 'trans-n')) {
                    if ($text->parentNode->firstChild === $text) {
                        $text->data = ltrim($text->data);
                    } elseif ($text->parentNode->lastChild === $text) {
                        $text->data = rtrim($text->data);
                    }
                }
            }
        }
    }

    private function isAllowedNode(\DOMElement $element)
    {

        if ($this->allowedTags && !in_array($element->localName, $this->allowedTags)) {

The expression $this->allowedTags of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return false;
        }

        if ($this->allowedNamespaces && !in_array($element->namespaceURI, $this->allowedNamespaces)) {

The expression $this->allowedNamespaces of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            return false;
        }

        return true;
    }
}