GroupRef::getElements() - Code Metrics - Inspection of "Increase coverage and improve groups handling" - goetas-webservices/xsd-reader - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#30)

by Asmir

created 2018-01-21 19:30 UTC

GroupRef::getElements() B

↳ Parent: GroupRef

Complexity

Conditions	6
Paths	5

Size

Total Lines	22
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	10
CRAP Score	6

Importance

Changes

Metric	Value
dl	0
loc	22
ccs	10
cts	10
cp	1
rs	8.6737
c	0
b	0
f	0
cc	6
eloc	10
nc	5
nop	0
crap	6

<?php

declare(strict_types=1);

namespace GoetasWebservices\XML\XSDReader\Schema\Element;

use BadMethodCallException;

class GroupRef extends Group implements InterfaceSetMinMax
{
    /**
     * @var Group
     */
    protected $wrapped;

    /**
     * @var int
     */
    protected $min = 1;

    /**
     * @var int
     */
    protected $max = 1;

    public function __construct(Group $group)
    {
        parent::__construct($group->getSchema(), '');
        $this->wrapped = $group;
    }

    public function getMin(): int
    {
        return $this->min;
    }

    public function setMin(int $min): void
    {
        $this->min = $min;
    }

    public function getMax(): int
    {
        return $this->max;
    }

    public function setMax(int $max): void
    {
        $this->max = $max;
    }

    public function getName(): string
    {
        return $this->wrapped->getName();
    }

    /**
     * @return ElementItem[]
     */
    public function getElements(): array
    {
        $elements = $this->wrapped->getElements();

        foreach ($elements as $k => $element) {
            /**
             * @var Element|ElementRef|ElementSingle|GroupRef $e
             */
            $e = clone $element;
            if ($this->getMax() > 0 || $this->getMax() === -1) {
                $e->setMax($this->getMax());
            }

            if ($this->getMin() > 1 && $e->getMin() === 1) {
                $e->setMin($this->getMin());
            }

            $elements[$k] = $e;
        }

        return $elements;
    }

    public function addElement(ElementItem $element): void
    {
        throw new BadMethodCallException("Can't add an element for a ref group");
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace GoetasWebservices\XML\XSDReader\Schema\Element;
6
7		use BadMethodCallException;
8
9		class GroupRef extends Group implements InterfaceSetMinMax
10		{
11		/**
12		* @var Group
13		*/
14		protected $wrapped;
15
16		/**
17		* @var int
18		*/
19		protected $min = 1;
20
21		/**
22		* @var int
23		*/
24		protected $max = 1;
25
26	58	public function __construct(Group $group)
27		{
28	58	parent::__construct($group->getSchema(), '');
29	58	$this->wrapped = $group;
30	58	}
31
32	58	public function getMin(): int
33		{
34	58	return $this->min;
35		}
36
37	58	public function setMin(int $min): void
38		{
39	58	$this->min = $min;
40	58	}
41
42	58	public function getMax(): int
43		{
44	58	return $this->max;
45		}
46
47	58	public function setMax(int $max): void
48		{
49	58	$this->max = $max;
50	58	}
51
52	8	public function getName(): string
53		{
54	8	return $this->wrapped->getName();
55		}
56
57		/**
58		* @return ElementItem[]
59		*/
60	7	public function getElements(): array
61		{
62	7	$elements = $this->wrapped->getElements();
63
64	7	foreach ($elements as $k => $element) {
65		/**
66		* @var Element\|ElementRef\|ElementSingle\|GroupRef $e
67		*/
68	7	$e = clone $element;
69	7	if ($this->getMax() > 0 \|\| $this->getMax() === -1) {
70	7	$e->setMax($this->getMax());
71		}
72
73	7	if ($this->getMin() > 1 && $e->getMin() === 1) {
74	2	$e->setMin($this->getMin());
75		}
76
77	7	$elements[$k] = $e;
78		}
79
80	7	return $elements;
81		}
82
83		public function addElement(ElementItem $element): void
84		{
85		throw new BadMethodCallException("Can't add an element for a ref group");
86		}
87		}
88

goetas-webservices / xsd-reader

Pull Request — master (#30)

GroupRef::getElements() B

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like