Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
11 | View Code Duplication | class SignaturePropertyType |
|
|
|||
12 | { |
||
13 | |||
14 | /** |
||
15 | * @property string $target |
||
16 | */ |
||
17 | private $target = null; |
||
18 | |||
19 | /** |
||
20 | * @property string $id |
||
21 | */ |
||
22 | private $id = null; |
||
23 | |||
24 | /** |
||
25 | * @property mixed[] $anyElement |
||
26 | */ |
||
27 | private $anyElement = array( |
||
28 | |||
29 | ); |
||
30 | |||
31 | /** |
||
32 | * Gets as target |
||
33 | * |
||
34 | * @return string |
||
35 | */ |
||
36 | public function getTarget() |
||
40 | |||
41 | /** |
||
42 | * Sets a new target |
||
43 | * |
||
44 | * @param string $target |
||
45 | * @return self |
||
46 | */ |
||
47 | public function setTarget($target) |
||
52 | |||
53 | /** |
||
54 | * Gets as id |
||
55 | * |
||
56 | * @return string |
||
57 | */ |
||
58 | public function getId() |
||
62 | |||
63 | /** |
||
64 | * Sets a new id |
||
65 | * |
||
66 | * @param string $id |
||
67 | * @return self |
||
68 | */ |
||
69 | public function setId($id) |
||
74 | |||
75 | /** |
||
76 | * Adds as array |
||
77 | * |
||
78 | * @return self |
||
79 | * @param mixed $array |
||
80 | */ |
||
81 | public function addToAnyElement($array) |
||
86 | |||
87 | /** |
||
88 | * isset anyElement |
||
89 | * |
||
90 | * @param scalar $index |
||
91 | * @return boolean |
||
92 | */ |
||
93 | public function issetAnyElement($index) |
||
97 | |||
98 | /** |
||
99 | * unset anyElement |
||
100 | * |
||
101 | * @param scalar $index |
||
102 | * @return void |
||
103 | */ |
||
104 | public function unsetAnyElement($index) |
||
108 | |||
109 | /** |
||
110 | * Gets as anyElement |
||
111 | * |
||
112 | * @return mixed[] |
||
113 | */ |
||
114 | public function getAnyElement() |
||
118 | |||
119 | /** |
||
120 | * Sets a new anyElement |
||
121 | * |
||
122 | * @param mixed[] $anyElement |
||
123 | * @return self |
||
124 | */ |
||
125 | public function setAnyElement(array $anyElement) |
||
130 | |||
131 | |||
132 | } |
||
133 | |||
134 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.