Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
13 | class Snowflake |
||
14 | { |
||
15 | const MAX_TIMESTAMP_LENGTH = 41; |
||
16 | |||
17 | const MAX_DATACENTER_LENGTH = 5; |
||
18 | |||
19 | const MAX_WORKID_LENGTH = 5; |
||
20 | |||
21 | const MAX_SEQUENCE_LENGTH = 12; |
||
22 | |||
23 | const MAX_FIRST_LENGTH = 1; |
||
24 | |||
25 | /** |
||
26 | * The data center id. |
||
27 | * |
||
28 | * @var int |
||
29 | */ |
||
30 | protected $datacenter; |
||
31 | |||
32 | /** |
||
33 | * The worker id. |
||
34 | * |
||
35 | * @var int |
||
36 | */ |
||
37 | protected $workerid; |
||
38 | |||
39 | /** |
||
40 | * The Sequence Resolver instance. |
||
41 | * |
||
42 | * @var \Godruoyi\Snowflake\SequenceResolver|null |
||
43 | */ |
||
44 | protected $sequence; |
||
45 | |||
46 | /** |
||
47 | * The start timestamp. |
||
48 | * |
||
49 | * @var int |
||
50 | */ |
||
51 | protected $startTime; |
||
52 | |||
53 | /** |
||
54 | * Default sequence resolver. |
||
55 | * |
||
56 | * @var \Godruoyi\Snowflake\SequenceResolver|null |
||
57 | */ |
||
58 | protected $defaultSequenceResolver; |
||
59 | |||
60 | /** |
||
61 | * Build Snowflake Instance. |
||
62 | * |
||
63 | * @param int $datacenter |
||
64 | * @param int $workerid |
||
65 | */ |
||
66 | 13 | public function __construct(int $datacenter = null, int $workerid = null) |
|
75 | |||
76 | /** |
||
77 | * Get snowflake id. |
||
78 | * |
||
79 | * @return string |
||
80 | */ |
||
81 | 6 | public function id() |
|
98 | |||
99 | /** |
||
100 | * Parse snowflake id. |
||
101 | */ |
||
102 | 3 | public function parseId(string $id, $transform = false): array |
|
117 | |||
118 | /** |
||
119 | * Get current microtime timestamp. |
||
120 | * |
||
121 | * @return int |
||
122 | */ |
||
123 | 15 | public function getCurrentMicrotime() |
|
127 | |||
128 | /** |
||
129 | * Set start time (millisecond). |
||
130 | */ |
||
131 | 3 | View Code Duplication | public function setStartTimeStamp(int $startTime) |
|
|||
132 | { |
||
133 | 3 | $missTime = $this->getCurrentMicrotime() - $startTime; |
|
134 | |||
135 | 3 | if ($missTime < 0) { |
|
136 | throw new \Exception('The start time cannot be greater than the current time'); |
||
137 | } |
||
138 | |||
139 | 3 | $maxTimeDiff = -1 ^ (-1 << self::MAX_TIMESTAMP_LENGTH); |
|
140 | |||
141 | 3 | if ($missTime > $maxTimeDiff) { |
|
142 | 2 | throw new \Exception(sprintf('The current microtime - starttime is not allowed to exceed -1 ^ (-1 << %d), You can reset the start time to fix this', self::MAX_TIMESTAMP_LENGTH)); |
|
143 | } |
||
144 | |||
145 | 3 | $this->startTime = $startTime; |
|
146 | |||
147 | 3 | return $this; |
|
148 | } |
||
149 | |||
150 | /** |
||
151 | * Get start timestamp (millisecond), If not set default to 2019-08-08 08:08:08. |
||
152 | * |
||
153 | * @return int |
||
154 | */ |
||
155 | 10 | public function getStartTimeStamp() |
|
166 | |||
167 | /** |
||
168 | * Set Sequence Resolver. |
||
169 | * |
||
170 | * @param SequenceResolver|callable $sequence |
||
171 | */ |
||
172 | 4 | public function setSequenceResolver($sequence) |
|
178 | |||
179 | /** |
||
180 | * Get Sequence Resolver. |
||
181 | * |
||
182 | * @return \Godruoyi\Snowflake\SequenceResolver|callable|null |
||
183 | */ |
||
184 | 10 | public function getSequenceResolver() |
|
188 | |||
189 | /** |
||
190 | * Get Default Sequence Resolver. |
||
191 | * |
||
192 | * @return \Godruoyi\Snowflake\SequenceResolver |
||
193 | */ |
||
194 | 8 | public function getDefaultSequenceResolver(): SequenceResolver |
|
198 | |||
199 | /** |
||
200 | * Call resolver. |
||
201 | * |
||
202 | * @param callable|\Godruoyi\Snowflake\SequenceResolver $resolver |
||
203 | * @param int $maxSequence |
||
204 | * |
||
205 | * @return int |
||
206 | */ |
||
207 | 8 | protected function callResolver($currentTime) |
|
219 | } |
||
220 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.