App\Commands\BaseCommand

Complexity

Total Complexity

5

Size/Duplication

Total Lines	35
Duplicated Lines	0 %

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	isSupported()	0	3	1
A	requestedDocset()	0	5	1
A	requestedAction()	0	3	1
A	handle()	0	16	2

<?php

namespace App\Commands;

use Illuminate\Support\Str;
use App\Services\DocsetBuilder;
use LaravelZero\Framework\Commands\Command;

abstract class BaseCommand extends Command
{
    public function handle()
    {
        $docset = $this->requestedDocset();
        $action = $this->requestedAction();

        if ($this->isSupported($docset)) {

The call to App\Commands\BaseCommand::isSupported() has too many arguments starting with $docset.

            $this->info(Str::ucfirst("$action started"));
            (new DocsetBuilder(new $docset(), $this))->$action();
            $this->info(Str::ucfirst("$action finished"));

            return;
        }

        $this->warn('The doc requested does not seem to be supported.');

        return 1;
    }

    protected function requestedDocset()
    {
        $classBasename = Str::camel($this->argument('doc'));

It seems like $this->argument('doc') can also be of type string[]; however, parameter $value of Illuminate\Support\Str::camel() does only seem to accept string, maybe add an additional type check?

        return "App\\Docsets\\$classBasename";
    }

    protected function requestedAction()
    {
        return $this->getName();
    }

    protected function isSupported()
    {
        return class_exists($this->requestedDocset());
    }
}