| Conditions | 1 |
| Paths | 1 |
| Total Lines | 112 |
| Code Lines | 69 |
| Lines | 0 |
| Ratio | 0 % |
| Changes | 0 | ||
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
| 1 | <?php |
||
| 36 | public static function load() |
||
| 37 | { |
||
| 38 | $container = new static(); |
||
| 39 | |||
| 40 | $container['zip.inflator'] = null; |
||
| 41 | $container['zip.deflator'] = null; |
||
| 42 | |||
| 43 | $container['resource-manager'] = function($container) { |
||
| 44 | return new ResourceManager( |
||
| 45 | $container['request-mapper'], |
||
| 46 | $container['resource-teleporter'], |
||
| 47 | $container['filesystem'] |
||
| 48 | ); |
||
| 49 | }; |
||
| 50 | |||
| 51 | $container['executable-finder'] = function() { |
||
| 52 | return new ExecutableFinder(); |
||
| 53 | }; |
||
| 54 | |||
| 55 | $container['request-mapper'] = function($container) { |
||
| 56 | return new RequestMapper($container['target-locator']); |
||
| 57 | }; |
||
| 58 | |||
| 59 | $container['target-locator'] = function() { |
||
| 60 | return new TargetLocator(); |
||
| 61 | }; |
||
| 62 | |||
| 63 | $container['teleporter-container'] = function() { |
||
| 64 | return TeleporterContainer::load(); |
||
| 65 | }; |
||
| 66 | |||
| 67 | $container['resource-teleporter'] = function($container) { |
||
| 68 | return new ResourceTeleporter($container['teleporter-container']); |
||
| 69 | }; |
||
| 70 | |||
| 71 | $container['filesystem'] = function() { |
||
| 72 | return new Filesystem(); |
||
| 73 | }; |
||
| 74 | |||
| 75 | $container[ZipAdapter::class] = function($container) { |
||
| 76 | return ZipAdapter::newInstance( |
||
| 77 | $container['executable-finder'], |
||
| 78 | $container['resource-manager'], |
||
| 79 | $container['zip.inflator'], |
||
| 80 | $container['zip.deflator'] |
||
| 81 | ); |
||
| 82 | }; |
||
| 83 | |||
| 84 | $container['gnu-tar.inflator'] = null; |
||
| 85 | $container['gnu-tar.deflator'] = null; |
||
| 86 | |||
| 87 | $container[TarGNUTarAdapter::class] = function($container) { |
||
| 88 | return TarGNUTarAdapter::newInstance( |
||
| 89 | $container['executable-finder'], |
||
| 90 | $container['resource-manager'], |
||
| 91 | $container['gnu-tar.inflator'], |
||
| 92 | $container['gnu-tar.deflator'] |
||
| 93 | ); |
||
| 94 | }; |
||
| 95 | |||
| 96 | $container[TarGzGNUTarAdapter::class] = function($container) { |
||
| 97 | return TarGzGNUTarAdapter::newInstance( |
||
| 98 | $container['executable-finder'], |
||
| 99 | $container['resource-manager'], |
||
| 100 | $container['gnu-tar.inflator'], |
||
| 101 | $container['gnu-tar.deflator'] |
||
| 102 | ); |
||
| 103 | }; |
||
| 104 | |||
| 105 | $container[TarBz2GNUTarAdapter::class] = function($container) { |
||
| 106 | return TarBz2GNUTarAdapter::newInstance( |
||
| 107 | $container['executable-finder'], |
||
| 108 | $container['resource-manager'], |
||
| 109 | $container['gnu-tar.inflator'], |
||
| 110 | $container['gnu-tar.deflator'] |
||
| 111 | ); |
||
| 112 | }; |
||
| 113 | |||
| 114 | $container['bsd-tar.inflator'] = null; |
||
| 115 | $container['bsd-tar.deflator'] = null; |
||
| 116 | |||
| 117 | $container[TarBSDTarAdapter::class] = function($container) { |
||
| 118 | return TarBSDTarAdapter::newInstance( |
||
| 119 | $container['executable-finder'], |
||
| 120 | $container['resource-manager'], |
||
| 121 | $container['bsd-tar.inflator'], |
||
| 122 | $container['bsd-tar.deflator'] |
||
| 123 | ); |
||
| 124 | }; |
||
| 125 | |||
| 126 | $container[TarGzBSDTarAdapter::class] = function($container) { |
||
| 127 | return TarGzBSDTarAdapter::newInstance( |
||
| 128 | $container['executable-finder'], |
||
| 129 | $container['resource-manager'], |
||
| 130 | $container['bsd-tar.inflator'], |
||
| 131 | $container['bsd-tar.deflator'] |
||
| 132 | ); |
||
| 133 | }; |
||
| 134 | |||
| 135 | $container[TarBz2BSDTarAdapter::class] = function($container) { |
||
| 136 | return TarBz2BSDTarAdapter::newInstance( |
||
| 137 | $container['executable-finder'], |
||
| 138 | $container['resource-manager'], |
||
| 139 | $container['bsd-tar.inflator'], |
||
| 140 | $container['bsd-tar.deflator']); |
||
| 141 | }; |
||
| 142 | |||
| 143 | $container[ZipExtensionAdapter::class] = function() { |
||
| 144 | return ZipExtensionAdapter::newInstance(); |
||
| 145 | }; |
||
| 146 | |||
| 147 | return $container; |
||
| 148 | } |
||
| 221 |