| Total Complexity | 49 |
| Total Lines | 337 |
| Duplicated Lines | 0 % |
| Changes | 0 | ||
Complex classes like ZipExtensionAdapter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ZipExtensionAdapter, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 31 | class ZipExtensionAdapter extends AbstractAdapter |
||
| 32 | { |
||
| 33 | private $errorCodesMapping = [ |
||
| 34 | \ZipArchive::ER_EXISTS => "File already exists", |
||
| 35 | \ZipArchive::ER_INCONS => "Zip archive inconsistent", |
||
| 36 | \ZipArchive::ER_INVAL => "Invalid argument", |
||
| 37 | \ZipArchive::ER_MEMORY => "Malloc failure", |
||
| 38 | \ZipArchive::ER_NOENT => "No such file", |
||
| 39 | \ZipArchive::ER_NOZIP => "Not a zip archive", |
||
| 40 | \ZipArchive::ER_OPEN => "Can't open file", |
||
| 41 | \ZipArchive::ER_READ => "Read error", |
||
| 42 | \ZipArchive::ER_SEEK => "Seek error", |
||
| 43 | ]; |
||
| 44 | |||
| 45 | public function __construct(ResourceManager $manager) |
||
| 49 | } |
||
| 50 | |||
| 51 | /** |
||
| 52 | * @inheritdoc |
||
| 53 | */ |
||
| 54 | protected function doListMembers(ResourceInterface $resource) |
||
| 55 | { |
||
| 56 | $members = array(); |
||
| 57 | for ($i = 0; $i < $resource->getResource()->numFiles; $i++) { |
||
| 58 | $stat = $resource->getResource()->statIndex($i); |
||
| 59 | $members[] = new Member( |
||
| 60 | $resource, |
||
| 61 | $this, |
||
| 62 | $stat['name'], |
||
| 63 | $stat['size'], |
||
| 64 | new \DateTime('@' . $stat['mtime']), |
||
| 65 | 0 === strlen($resource->getResource()->getFromIndex($i, 1)) |
||
| 66 | ); |
||
| 67 | } |
||
| 68 | |||
| 69 | return $members; |
||
| 70 | } |
||
| 71 | |||
| 72 | /** |
||
| 73 | * @inheritdoc |
||
| 74 | */ |
||
| 75 | public static function getName() |
||
| 76 | { |
||
| 77 | return 'zip-extension'; |
||
| 78 | } |
||
| 79 | |||
| 80 | /** |
||
| 81 | * @inheritdoc |
||
| 82 | */ |
||
| 83 | protected function doExtract(ResourceInterface $resource, $to) |
||
| 84 | { |
||
| 85 | return $this->extractMembers($resource, null, $to); |
||
| 86 | } |
||
| 87 | |||
| 88 | /** |
||
| 89 | * @inheritdoc |
||
| 90 | */ |
||
| 91 | protected function doExtractMembers(ResourceInterface $resource, $members, $to, $overwrite = false) |
||
| 92 | { |
||
| 93 | if (null === $to) { |
||
| 94 | // if no destination is given, will extract to zip current folder |
||
| 95 | $to = dirname(realpath($resource->getResource()->filename)); |
||
| 96 | } |
||
| 97 | |||
| 98 | if (!is_dir($to)) { |
||
| 99 | $resource->getResource()->close(); |
||
| 100 | throw new InvalidArgumentException(sprintf("%s is not a directory", $to)); |
||
| 101 | } |
||
| 102 | |||
| 103 | if (!is_writable($to)) { |
||
| 104 | $resource->getResource()->close(); |
||
| 105 | throw new InvalidArgumentException(sprintf("%s is not writable", $to)); |
||
| 106 | } |
||
| 107 | |||
| 108 | if (null !== $members) { |
||
| 109 | $membersTemp = (array) $members; |
||
| 110 | if (empty($membersTemp)) { |
||
| 111 | $resource->getResource()->close(); |
||
| 112 | |||
| 113 | throw new InvalidArgumentException("no members provided"); |
||
| 114 | } |
||
| 115 | $members = array(); |
||
| 116 | // allows $members to be an array of strings or array of Members |
||
| 117 | foreach ($membersTemp as $member) { |
||
| 118 | if ($member instanceof Member) { |
||
| 119 | $member = $member->getLocation(); |
||
| 120 | } |
||
| 121 | |||
| 122 | if ($resource->getResource()->locateName($member) === false) { |
||
| 123 | $resource->getResource()->close(); |
||
| 124 | |||
| 125 | throw new InvalidArgumentException(sprintf('%s is not in the zip file', $member)); |
||
| 126 | } |
||
| 127 | |||
| 128 | if ($overwrite == false) { |
||
| 129 | if (file_exists($member)) { |
||
| 130 | $resource->getResource()->close(); |
||
| 131 | |||
| 132 | throw new RuntimeException('Target file ' . $member . ' already exists.'); |
||
| 133 | } |
||
| 134 | } |
||
| 135 | |||
| 136 | $members[] = $member; |
||
| 137 | } |
||
| 138 | } |
||
| 139 | |||
| 140 | if (!$resource->getResource()->extractTo($to, $members)) { |
||
| 141 | $resource->getResource()->close(); |
||
| 142 | |||
| 143 | throw new InvalidArgumentException(sprintf('Unable to extract archive : %s', $resource->getResource()->getStatusString())); |
||
| 144 | } |
||
| 145 | |||
| 146 | return new \SplFileInfo($to); |
||
| 147 | } |
||
| 148 | |||
| 149 | /** |
||
| 150 | * @inheritdoc |
||
| 151 | */ |
||
| 152 | protected function doRemove(ResourceInterface $resource, $files) |
||
| 178 | } |
||
| 179 | |||
| 180 | /** |
||
| 181 | * @inheritdoc |
||
| 182 | */ |
||
| 183 | protected function doAdd(ResourceInterface $resource, $files, $recursive) |
||
| 184 | { |
||
| 185 | $files = (array) $files; |
||
| 186 | if (empty($files)) { |
||
| 187 | $resource->getResource()->close(); |
||
| 188 | throw new InvalidArgumentException("no files provided"); |
||
| 189 | } |
||
| 190 | $this->addEntries($resource, $files, $recursive); |
||
| 191 | |||
| 192 | return $files; |
||
| 193 | } |
||
| 194 | |||
| 195 | /** |
||
| 196 | * @inheritdoc |
||
| 197 | */ |
||
| 198 | protected function doCreate($path, $files, $recursive) |
||
| 199 | { |
||
| 200 | $files = (array) $files; |
||
| 201 | |||
| 202 | if (empty($files)) { |
||
| 203 | throw new NotSupportedException("Cannot create an empty zip"); |
||
| 204 | } |
||
| 205 | |||
| 206 | $resource = $this->getResource($path, \ZipArchive::CREATE); |
||
| 207 | $this->addEntries($resource, $files, $recursive); |
||
| 208 | |||
| 209 | return new Archive($resource, $this, $this->manager); |
||
| 210 | } |
||
| 211 | |||
| 212 | /** |
||
| 213 | * Returns a new instance of the invoked adapter |
||
| 214 | * |
||
| 215 | * @return AbstractAdapter |
||
| 216 | * |
||
| 217 | * @throws RuntimeException In case object could not be instanciated |
||
| 218 | */ |
||
| 219 | public static function newInstance() |
||
| 220 | { |
||
| 221 | return new ZipExtensionAdapter(ResourceManager::create()); |
||
| 222 | } |
||
| 223 | |||
| 224 | protected function createResource($path) |
||
| 225 | { |
||
| 226 | return $this->getResource($path, \ZipArchive::CHECKCONS); |
||
| 227 | } |
||
| 228 | |||
| 229 | private function getResource($path, $mode) |
||
| 230 | { |
||
| 231 | |||
| 232 | $res = \ZipArchive::ER_OPEN; |
||
|
|
|||
| 233 | $zip = new \ZipArchive(); |
||
| 234 | |||
| 235 | try { |
||
| 236 | $res = $zip->open($path, $mode); |
||
| 237 | } catch (\Exception $e) { |
||
| 238 | throw new RuntimeException($e->getMessage(), $e->getCode(), $e); |
||
| 239 | } |
||
| 240 | |||
| 241 | if ($res !== true) { |
||
| 242 | if (!isset($this->errorCodesMapping[$res])) { |
||
| 243 | throw new RuntimeException('Unknown error when opening the zip file'); |
||
| 244 | } |
||
| 245 | |||
| 246 | throw new RuntimeException($this->errorCodesMapping[$res]); |
||
| 247 | } |
||
| 248 | |||
| 249 | return new ZipArchiveResource($zip); |
||
| 250 | } |
||
| 251 | |||
| 252 | private function addEntries(ResourceInterface $zipResource, array $files, $recursive) |
||
| 310 | } |
||
| 311 | } |
||
| 312 | |||
| 313 | /** |
||
| 314 | * |
||
| 315 | * @param \ZipArchive $zip |
||
| 316 | * @param string $file |
||
| 317 | */ |
||
| 318 | private function checkReadability(\ZipArchive $zip, $file) |
||
| 319 | { |
||
| 320 | if (!is_readable($file)) { |
||
| 321 | $zip->unchangeAll(); |
||
| 322 | $zip->close(); |
||
| 323 | |||
| 324 | throw new InvalidArgumentException(sprintf('could not read %s', $file)); |
||
| 325 | } |
||
| 326 | } |
||
| 327 | |||
| 328 | /** |
||
| 329 | * |
||
| 330 | * @param \ZipArchive $zip |
||
| 331 | * @param string $file |
||
| 332 | */ |
||
| 333 | private function addFileToZip(\ZipArchive $zip, $file) |
||
| 340 | } |
||
| 341 | } |
||
| 342 | |||
| 343 | /** |
||
| 344 | * |
||
| 345 | * @param \ZipArchive $zip |
||
| 346 | * @param string $dir |
||
| 347 | */ |
||
| 348 | private function addEmptyDir(\ZipArchive $zip, $dir) |
||
| 349 | { |
||
| 350 | if (!$zip->addEmptyDir($dir)) { |
||
| 351 | $zip->unchangeAll(); |
||
| 352 | $zip->close(); |
||
| 353 | |||
| 354 | throw new RuntimeException(sprintf('unable to add %s to the zip file', $dir)); |
||
| 355 | } |
||
| 356 | } |
||
| 357 | |||
| 358 | /** |
||
| 359 | * Flushes changes to the archive |
||
| 360 | * |
||
| 361 | * @param \ZipArchive $zip |
||
| 362 | */ |
||
| 363 | private function flush(\ZipArchive $zip) // flush changes by reopening the file |
||
| 368 | } |
||
| 369 | } |
||
| 370 |