Completed
Pull Request — master (#82)
by Loren
04:09
created
src/NodeVisitor/BuiltinTypeFixer.php 1 patch
Spacing   +19 added lines, -19 removed lines patch added patch discarded remove patch
@@ -43,7 +43,7 @@  discard block
 block discarded – undo
43 43
             }
44 44
             $numericIndexCount = count(array_filter(
45 45
                 $options['supportedBuiltinTypeHints'],
46
-                (function ($val) {
46
+                (function($val) {
47 47
                     return preg_match('/^0*(0|[1-9]\\d*)$/', $val);
48 48
                 }),
49 49
                 ARRAY_FILTER_USE_KEY
@@ -53,12 +53,12 @@  discard block
 block discarded – undo
53 53
                 $typeHintName = $key;
54 54
                 $validFor     = $value;
55 55
                 if (preg_match('/^0*(0|[1-9]\\d*)$/', $key) &&
56
-                    (intval($key) >= 0)                     &&
57
-                    (intval($key) <  $numericIndexCount)
56
+                    (intval($key) >= 0) &&
57
+                    (intval($key) < $numericIndexCount)
58 58
                 ) {
59 59
                     $numericIndex = true;
60 60
                     $typeHintName = $value;
61
-                    $validFor     = self::PARAMETER_TYPES|self::RETURN_TYPES;
61
+                    $validFor     = self::PARAMETER_TYPES | self::RETURN_TYPES;
62 62
                 }
63 63
                 if (!is_string($typeHintName) || !preg_match('/^\\w(?<!\\d)\\w*$/', $typeHintName)) {
64 64
                     throw new \InvalidArgumentException(
@@ -67,9 +67,9 @@  discard block
 block discarded – undo
67 67
                             var_export($typeHintName, true)
68 68
                         )
69 69
                     );
70
-                } elseif (!is_scalar($validFor)                                                             ||
71
-                    (strval($validFor) != strval(intval($validFor)))                                        ||
72
-                    (intval($validFor) != (intval($validFor) & (self::PARAMETER_TYPES|self::RETURN_TYPES))) ||
70
+                } elseif (!is_scalar($validFor) ||
71
+                    (strval($validFor) != strval(intval($validFor))) ||
72
+                    (intval($validFor) != (intval($validFor) & (self::PARAMETER_TYPES | self::RETURN_TYPES))) ||
73 73
                     (intval($validFor) == 0)
74 74
                 ) {
75 75
                     throw new \InvalidArgumentException(
@@ -87,7 +87,7 @@  discard block
 block discarded – undo
87 87
                         )
88 88
                     );
89 89
                 } else {
90
-                    $this->supportedBuiltinTypeHints[$typeHintName] = intval($validFor) & (self::PARAMETER_TYPES|self::RETURN_TYPES);
90
+                    $this->supportedBuiltinTypeHints[$typeHintName] = intval($validFor) & (self::PARAMETER_TYPES | self::RETURN_TYPES);
91 91
                 }
92 92
             }
93 93
         } else {
@@ -125,31 +125,31 @@  discard block
 block discarded – undo
125 125
             $builtInTypeNames = [
126 126
                 'array'    => [
127 127
                     'introduced_version' => 50100,
128
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
128
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
129 129
                 ],
130 130
                 'callable' => [
131 131
                     'introduced_version' => 50400,
132
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
132
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
133 133
                 ],
134 134
                 'bool'     => [
135 135
                     'introduced_version' => 70000,
136
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
136
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
137 137
                 ],
138 138
                 'float'    => [
139 139
                     'introduced_version' => 70000,
140
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
140
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
141 141
                 ],
142 142
                 'int'      => [
143 143
                     'introduced_version' => 70000,
144
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
144
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
145 145
                 ],
146 146
                 'string'   => [
147 147
                     'introduced_version' => 70000,
148
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
148
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
149 149
                 ],
150 150
                 'iterable' => [
151 151
                     'introduced_version' => 70100,
152
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
152
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
153 153
                 ],
154 154
                 'void'     => [
155 155
                     'introduced_version' => 70100,
@@ -157,7 +157,7 @@  discard block
 block discarded – undo
157 157
                 ],
158 158
                 'object'   => [
159 159
                     'introduced_version' => 70200,
160
-                    'valid_for'          => self::PARAMETER_TYPES|self::RETURN_TYPES,
160
+                    'valid_for'          => self::PARAMETER_TYPES | self::RETURN_TYPES,
161 161
                 ],
162 162
             ];
163 163
             foreach ($builtInTypeNames as $typeHintName => $valid) {
@@ -170,7 +170,7 @@  discard block
 block discarded – undo
170 170
 
171 171
     public function enterNode(Node $node)
172 172
     {
173
-        if (($node instanceof Stmt\Function_)   ||
173
+        if (($node instanceof Stmt\Function_) ||
174 174
             ($node instanceof Stmt\ClassMethod) ||
175 175
             ($node instanceof Expr\Closure)
176 176
         ) {
@@ -222,10 +222,10 @@  discard block
 block discarded – undo
222 222
         }
223 223
         if ($node instanceof Node\NullableType) {
224 224
             // This *SHOULD* never be called, but correct behavior shorter than Exception.
225
-            return '?' . $this->getTypeAsString($node->type);
225
+            return '?'.$this->getTypeAsString($node->type);
226 226
         }
227 227
         if ($node instanceof Name) {
228
-            return ($node->isFullyQualified() ? '\\' : '') . $node->toString();
228
+            return ($node->isFullyQualified() ? '\\' : '').$node->toString();
229 229
         }
230 230
         return strval($node);
231 231
     }
Please login to merge, or discard this patch.