Complex classes like NodeExpressionResolver often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NodeExpressionResolver, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 24 | class NodeExpressionResolver |
||
| 25 | { |
||
| 26 | |||
| 27 | /** |
||
| 28 | * List of exception for constant fetch |
||
| 29 | * |
||
| 30 | * @var array |
||
| 31 | */ |
||
| 32 | private static $notConstants = [ |
||
| 33 | 'true' => true, |
||
| 34 | 'false' => true, |
||
| 35 | 'null' => true, |
||
| 36 | ]; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Name of the constant (if present) |
||
| 40 | * |
||
| 41 | * @var null|string |
||
| 42 | */ |
||
| 43 | private $constantName = null; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * Current reflection context for parsing |
||
| 47 | * |
||
| 48 | * @var mixed |
||
| 49 | */ |
||
| 50 | private $context; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Flag if expression is constant |
||
| 54 | * |
||
| 55 | * @var bool |
||
| 56 | */ |
||
| 57 | private $isConstant = false; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * Node resolving level, 1 = top-level |
||
| 61 | * |
||
| 62 | * @var int |
||
| 63 | */ |
||
| 64 | private $nodeLevel = 0; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * @var mixed Value of expression/constant |
||
| 68 | */ |
||
| 69 | private $value; |
||
| 70 | |||
| 71 | 36 | public function __construct($context) |
|
| 75 | |||
| 76 | 10 | public function getConstantName() |
|
| 80 | |||
| 81 | 22 | public function getValue() |
|
| 85 | |||
| 86 | 10 | public function isConstant() |
|
| 90 | |||
| 91 | /** |
||
| 92 | * {@inheritDoc} |
||
| 93 | */ |
||
| 94 | 22 | public function process(Node $node) |
|
| 101 | |||
| 102 | /** |
||
| 103 | * Resolves node into valid value |
||
| 104 | * |
||
| 105 | * @param Node $node |
||
| 106 | * |
||
| 107 | * @return mixed |
||
| 108 | */ |
||
| 109 | 22 | protected function resolve(Node $node) |
|
| 128 | |||
| 129 | 4 | protected function resolveScalarDNumber(Scalar\DNumber $node) |
|
| 133 | |||
| 134 | 13 | protected function resolveScalarLNumber(Scalar\LNumber $node) |
|
| 138 | |||
| 139 | 9 | protected function resolveScalarString(Scalar\String_ $node) |
|
| 143 | |||
| 144 | protected function resolveScalarMagicConstMethod() |
||
| 154 | |||
| 155 | protected function resolveScalarMagicConstFunction() |
||
| 163 | |||
| 164 | 10 | protected function resolveScalarMagicConstNamespace() |
|
| 176 | |||
| 177 | 8 | protected function resolveScalarMagicConstClass() |
|
| 191 | |||
| 192 | 1 | protected function resolveScalarMagicConstDir() |
|
| 200 | |||
| 201 | 3 | protected function resolveScalarMagicConstFile() |
|
| 209 | |||
| 210 | 3 | protected function resolveScalarMagicConstLine(MagicConst\Line $node) |
|
| 214 | |||
| 215 | 1 | protected function resolveScalarMagicConstTrait() |
|
| 223 | |||
| 224 | 13 | protected function resolveExprConstFetch(Expr\ConstFetch $node) |
|
| 258 | |||
| 259 | 4 | protected function resolveExprClassConstFetch(Expr\ClassConstFetch $node) |
|
| 271 | |||
| 272 | 9 | protected function resolveExprArray(Expr\Array_ $node) |
|
| 283 | |||
| 284 | /** |
||
| 285 | * Utility method to fetch reflection class instance by name |
||
| 286 | * |
||
| 287 | * Supports: |
||
| 288 | * 'self' keyword |
||
| 289 | * 'parent' keyword |
||
| 290 | * not-FQN class names |
||
| 291 | * |
||
| 292 | * @param Node\Name $node Class name node |
||
| 293 | * |
||
| 294 | * @return bool|\ReflectionClass |
||
| 295 | * |
||
| 296 | * @throws ReflectionException |
||
| 297 | */ |
||
| 298 | 4 | private function fetchReflectionClass(Node\Name $node) |
|
| 333 | } |
||
| 334 |
This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.
Both the
$myVarassignment in line 1 and the$higherassignment in line 2 are dead. The first because$myVaris never used and the second because$higheris always overwritten for every possible time line.