goaop /
parser-reflection
Complex classes like ReflectionClassLikeTrait often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ReflectionClassLikeTrait, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 29 | trait ReflectionClassLikeTrait |
||
| 30 | { |
||
| 31 | use InitializationTrait; |
||
| 32 | |||
| 33 | /** |
||
| 34 | * @var ClassLike |
||
| 35 | */ |
||
| 36 | protected $classLikeNode; |
||
| 37 | |||
| 38 | /** |
||
| 39 | * Short name of the class, without namespace |
||
| 40 | * |
||
| 41 | * @var string |
||
| 42 | */ |
||
| 43 | protected $className; |
||
| 44 | |||
| 45 | /** |
||
| 46 | * List of all constants from the class |
||
| 47 | * |
||
| 48 | * @var array |
||
| 49 | */ |
||
| 50 | protected $constants; |
||
| 51 | |||
| 52 | /** |
||
| 53 | * Interfaces, empty array or null if not initialized yet |
||
| 54 | * |
||
| 55 | * @var \ReflectionClass[]|array|null |
||
| 56 | */ |
||
| 57 | protected $interfaceClasses; |
||
| 58 | |||
| 59 | /** |
||
| 60 | * List of traits, empty array or null if not initialized yet |
||
| 61 | * |
||
| 62 | * @var \ReflectionClass[]|array|null |
||
| 63 | */ |
||
| 64 | protected $traits; |
||
| 65 | |||
| 66 | /** |
||
| 67 | * Additional list of trait adaptations |
||
| 68 | * |
||
| 69 | * @var TraitUseAdaptation[]|array |
||
| 70 | */ |
||
| 71 | protected $traitAdaptations; |
||
| 72 | |||
| 73 | /** |
||
| 74 | * @var array|ReflectionMethod[] |
||
| 75 | */ |
||
| 76 | protected $methods; |
||
| 77 | |||
| 78 | /** |
||
| 79 | * Namespace name |
||
| 80 | * |
||
| 81 | * @var string |
||
| 82 | */ |
||
| 83 | protected $namespaceName = ''; |
||
| 84 | |||
| 85 | /** |
||
| 86 | * Parent class, or false if not present, null if uninitialized yet |
||
| 87 | * |
||
| 88 | * @var \ReflectionClass|false|null |
||
| 89 | */ |
||
| 90 | protected $parentClass; |
||
| 91 | |||
| 92 | /** |
||
| 93 | * @var array|ReflectionProperty[] |
||
| 94 | */ |
||
| 95 | protected $properties; |
||
| 96 | |||
| 97 | /** |
||
| 98 | * Returns the string representation of the ReflectionClass object. |
||
| 99 | * |
||
| 100 | * @return string |
||
| 101 | */ |
||
| 102 | public function __toString() |
||
| 191 | |||
| 192 | |||
| 193 | /** |
||
| 194 | * {@inheritDoc} |
||
| 195 | */ |
||
| 196 | 4 | public function getConstant($name) |
|
| 204 | |||
| 205 | /** |
||
| 206 | * {@inheritDoc} |
||
| 207 | */ |
||
| 208 | 23 | public function getConstants() |
|
| 222 | |||
| 223 | /** |
||
| 224 | * {@inheritDoc} |
||
| 225 | */ |
||
| 226 | 13 | public function getConstructor() |
|
| 235 | |||
| 236 | /** |
||
| 237 | * Gets default properties from a class (including inherited properties). |
||
| 238 | * |
||
| 239 | * @link http://php.net/manual/en/reflectionclass.getdefaultproperties.php |
||
| 240 | * |
||
| 241 | * @return array An array of default properties, with the key being the name of the property and the value being |
||
| 242 | * the default value of the property or NULL if the property doesn't have a default value |
||
| 243 | */ |
||
| 244 | 22 | public function getDefaultProperties() |
|
| 270 | |||
| 271 | /** |
||
| 272 | * {@inheritDoc} |
||
| 273 | */ |
||
| 274 | 22 | public function getDocComment() |
|
| 280 | |||
| 281 | 22 | public function getEndLine() |
|
| 285 | |||
| 286 | 22 | public function getExtension() |
|
| 290 | |||
| 291 | 22 | public function getExtensionName() |
|
| 295 | |||
| 296 | 7 | public function getFileName() |
|
| 300 | |||
| 301 | /** |
||
| 302 | * {@inheritDoc} |
||
| 303 | */ |
||
| 304 | 22 | public function getInterfaceNames() |
|
| 308 | |||
| 309 | /** |
||
| 310 | * {@inheritDoc} |
||
| 311 | */ |
||
| 312 | 22 | public function getInterfaces() |
|
| 325 | |||
| 326 | /** |
||
| 327 | * {@inheritdoc} |
||
| 328 | */ |
||
| 329 | 16 | public function getMethod($name) |
|
| 340 | |||
| 341 | /** |
||
| 342 | * Returns list of reflection methods |
||
| 343 | * |
||
| 344 | * @param null|integer $filter Optional filter |
||
| 345 | * |
||
| 346 | * @return array|\ReflectionMethod[] |
||
| 347 | */ |
||
| 348 | 61 | public function getMethods($filter = null) |
|
| 379 | |||
| 380 | /** |
||
| 381 | * Returns a bitfield of the access modifiers for this class. |
||
| 382 | * |
||
| 383 | * @link http://php.net/manual/en/reflectionclass.getmodifiers.php |
||
| 384 | * |
||
| 385 | * NB: this method is not fully compatible with original value because of hidden internal constants |
||
| 386 | * |
||
| 387 | * @return int |
||
| 388 | */ |
||
| 389 | 21 | public function getModifiers() |
|
| 416 | |||
| 417 | /** |
||
| 418 | * {@inheritDoc} |
||
| 419 | */ |
||
| 420 | 96 | public function getName() |
|
| 426 | |||
| 427 | /** |
||
| 428 | * {@inheritDoc} |
||
| 429 | */ |
||
| 430 | 25 | public function getNamespaceName() |
|
| 434 | |||
| 435 | /** |
||
| 436 | * {@inheritDoc} |
||
| 437 | */ |
||
| 438 | 91 | public function getParentClass() |
|
| 455 | |||
| 456 | /** |
||
| 457 | * Retrieves reflected properties. |
||
| 458 | * |
||
| 459 | * @param int $filter The optional filter, for filtering desired property types. |
||
| 460 | * It's configured using the ReflectionProperty constants, and defaults to all property types. |
||
| 461 | * |
||
| 462 | * @return array|\Go\ParserReflection\ReflectionProperty[] |
||
| 463 | */ |
||
| 464 | 46 | public function getProperties($filter = null) |
|
| 497 | |||
| 498 | /** |
||
| 499 | * {@inheritdoc} |
||
| 500 | */ |
||
| 501 | 3 | public function getProperty($name) |
|
| 512 | |||
| 513 | /** |
||
| 514 | * {@inheritDoc} |
||
| 515 | */ |
||
| 516 | 96 | public function getShortName() |
|
| 520 | |||
| 521 | 22 | public function getStartLine() |
|
| 525 | |||
| 526 | /** |
||
| 527 | * Returns an array of trait aliases |
||
| 528 | * |
||
| 529 | * @link http://php.net/manual/en/reflectionclass.gettraitaliases.php |
||
| 530 | * |
||
| 531 | * @return array|null an array with new method names in keys and original names (in the format "TraitName::original") in |
||
| 532 | * values. |
||
| 533 | */ |
||
| 534 | 41 | public function getTraitAliases() |
|
| 554 | |||
| 555 | /** |
||
| 556 | * Returns an array of names of traits used by this class |
||
| 557 | * |
||
| 558 | * @link http://php.net/manual/en/reflectionclass.gettraitnames.php |
||
| 559 | * |
||
| 560 | * @return array |
||
| 561 | */ |
||
| 562 | 22 | public function getTraitNames() |
|
| 566 | |||
| 567 | /** |
||
| 568 | * Returns an array of traits used by this class |
||
| 569 | * |
||
| 570 | * @link http://php.net/manual/en/reflectionclass.gettraits.php |
||
| 571 | * |
||
| 572 | * @return array|\ReflectionClass[] |
||
| 573 | */ |
||
| 574 | 91 | public function getTraits() |
|
| 584 | |||
| 585 | /** |
||
| 586 | * {@inheritDoc} |
||
| 587 | */ |
||
| 588 | 4 | public function hasConstant($name) |
|
| 595 | |||
| 596 | /** |
||
| 597 | * {@inheritdoc} |
||
| 598 | */ |
||
| 599 | 15 | public function hasMethod($name) |
|
| 610 | |||
| 611 | /** |
||
| 612 | * {@inheritdoc} |
||
| 613 | */ |
||
| 614 | public function hasProperty($name) |
||
| 625 | |||
| 626 | /** |
||
| 627 | * {@inheritDoc} |
||
| 628 | */ |
||
| 629 | 22 | public function implementsInterface($interfaceName) |
|
| 635 | |||
| 636 | /** |
||
| 637 | * {@inheritDoc} |
||
| 638 | */ |
||
| 639 | 22 | public function inNamespace() |
|
| 643 | |||
| 644 | /** |
||
| 645 | * {@inheritDoc} |
||
| 646 | */ |
||
| 647 | 22 | public function isAbstract() |
|
| 659 | |||
| 660 | /** |
||
| 661 | * Currently, anonymous classes aren't supported for parsed reflection |
||
| 662 | */ |
||
| 663 | public function isAnonymous() |
||
| 667 | |||
| 668 | /** |
||
| 669 | * {@inheritDoc} |
||
| 670 | */ |
||
| 671 | 22 | public function isCloneable() |
|
| 683 | |||
| 684 | /** |
||
| 685 | * {@inheritDoc} |
||
| 686 | */ |
||
| 687 | 43 | public function isFinal() |
|
| 693 | |||
| 694 | /** |
||
| 695 | * {@inheritDoc} |
||
| 696 | */ |
||
| 697 | public function isInstance($object) |
||
| 707 | |||
| 708 | /** |
||
| 709 | * {@inheritDoc} |
||
| 710 | */ |
||
| 711 | 22 | public function isInstantiable() |
|
| 723 | |||
| 724 | /** |
||
| 725 | * {@inheritDoc} |
||
| 726 | */ |
||
| 727 | 43 | public function isInterface() |
|
| 731 | |||
| 732 | /** |
||
| 733 | * {@inheritDoc} |
||
| 734 | */ |
||
| 735 | 22 | public function isInternal() |
|
| 740 | |||
| 741 | /** |
||
| 742 | * {@inheritDoc} |
||
| 743 | */ |
||
| 744 | 22 | public function isIterateable() |
|
| 748 | |||
| 749 | /** |
||
| 750 | * {@inheritDoc} |
||
| 751 | */ |
||
| 752 | public function isSubclassOf($class) |
||
| 775 | |||
| 776 | /** |
||
| 777 | * {@inheritDoc} |
||
| 778 | */ |
||
| 779 | 43 | public function isTrait() |
|
| 783 | |||
| 784 | /** |
||
| 785 | * {@inheritDoc} |
||
| 786 | */ |
||
| 787 | 22 | public function isUserDefined() |
|
| 792 | |||
| 793 | /** |
||
| 794 | * Gets static properties |
||
| 795 | * |
||
| 796 | * @link http://php.net/manual/en/reflectionclass.getstaticproperties.php |
||
| 797 | * |
||
| 798 | * @return array |
||
| 799 | */ |
||
| 800 | 23 | public function getStaticProperties() |
|
| 821 | |||
| 822 | /** |
||
| 823 | * Gets static property value |
||
| 824 | * |
||
| 825 | * @param string $name The name of the static property for which to return a value. |
||
| 826 | * @param mixed $default A default value to return in case the class does not declare |
||
| 827 | * a static property with the given name |
||
| 828 | * |
||
| 829 | * @return mixed |
||
| 830 | * @throws ReflectionException If there is no such property and no default value was given |
||
| 831 | */ |
||
| 832 | 1 | public function getStaticPropertyValue($name, $default = null) |
|
| 843 | |||
| 844 | |||
| 845 | /** |
||
| 846 | * Creates a new class instance from given arguments. |
||
| 847 | * |
||
| 848 | * @link http://php.net/manual/en/reflectionclass.newinstance.php |
||
| 849 | * @param mixed $args Accepts a variable number of arguments which are passed to the class constructor |
||
| 850 | * |
||
| 851 | * @return object |
||
| 852 | */ |
||
| 853 | 1 | public function newInstance($args = null) |
|
| 859 | |||
| 860 | /** |
||
| 861 | * Creates a new class instance from given arguments. |
||
| 862 | * |
||
| 863 | * @link http://php.net/manual/en/reflectionclass.newinstanceargs.php |
||
| 864 | * |
||
| 865 | * @param array $args The parameters to be passed to the class constructor as an array. |
||
| 866 | * |
||
| 867 | * @return object |
||
| 868 | */ |
||
| 869 | 1 | public function newInstanceArgs(array $args = []) |
|
| 876 | |||
| 877 | /** |
||
| 878 | * Creates a new class instance without invoking the constructor. |
||
| 879 | * |
||
| 880 | * @link http://php.net/manual/en/reflectionclass.newinstancewithoutconstructor.php |
||
| 881 | * |
||
| 882 | * @return object |
||
| 883 | */ |
||
| 884 | 1 | public function newInstanceWithoutConstructor($args = null) |
|
| 891 | |||
| 892 | /** |
||
| 893 | * Sets static property value |
||
| 894 | * |
||
| 895 | * @link http://php.net/manual/en/reflectionclass.setstaticpropertyvalue.php |
||
| 896 | * |
||
| 897 | * @param string $name Property name |
||
| 898 | * @param mixed $value New property value |
||
| 899 | */ |
||
| 900 | 1 | public function setStaticPropertyValue($name, $value) |
|
| 906 | |||
| 907 | 91 | private function recursiveCollect(\Closure $collector) |
|
| 928 | |||
| 929 | /** |
||
| 930 | * Returns list of constants from the class |
||
| 931 | * |
||
| 932 | * @return array |
||
| 933 | */ |
||
| 934 | 23 | private function findConstants() |
|
| 954 | } |
||
| 955 |
Loading history...
This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue.
If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress.
In this case you can add the
@ignorePhpDoc annotation to the duplicate definition and it will be ignored.