Complex classes like ReflectionParameter often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use ReflectionParameter, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
22 | class ReflectionParameter extends BaseReflectionParameter |
||
23 | { |
||
24 | use InternalPropertiesEmulationTrait; |
||
25 | |||
26 | /** |
||
27 | * Reflection function or method |
||
28 | * |
||
29 | * @var \ReflectionFunctionAbstract |
||
30 | */ |
||
31 | private $declaringFunction; |
||
32 | |||
33 | /** |
||
34 | * Stores the default value for node (if present) |
||
35 | * |
||
36 | * @var mixed |
||
37 | */ |
||
38 | private $defaultValue = null; |
||
39 | |||
40 | /** |
||
41 | * Whether or not default value is constant |
||
42 | * |
||
43 | * @var bool |
||
44 | */ |
||
45 | private $isDefaultValueConstant = false; |
||
46 | |||
47 | /** |
||
48 | * Name of the constant of default value |
||
49 | * |
||
50 | * @var string |
||
51 | */ |
||
52 | private $defaultValueConstantName; |
||
53 | |||
54 | /** |
||
55 | * Index of parameter in the list |
||
56 | * |
||
57 | * @var int |
||
58 | */ |
||
59 | private $parameterIndex = 0; |
||
60 | |||
61 | /** |
||
62 | * Concrete parameter node |
||
63 | * |
||
64 | * @var Param |
||
65 | */ |
||
66 | private $parameterNode; |
||
67 | |||
68 | /** |
||
69 | * Initializes a reflection for the property |
||
70 | * |
||
71 | * @param string|array $unusedFunctionName Name of the function/method |
||
72 | * @param string $parameterName Name of the parameter to reflect |
||
73 | * @param Param $parameterNode Parameter definition node |
||
74 | * @param int $parameterIndex Index of parameter |
||
75 | * @param \ReflectionFunctionAbstract $declaringFunction |
||
76 | */ |
||
77 | 10 | public function __construct( |
|
105 | |||
106 | /** |
||
107 | * Emulating original behaviour of reflection |
||
108 | */ |
||
109 | 1 | public function ___debugInfo() |
|
110 | { |
||
111 | return array( |
||
112 | 1 | 'name' => $this->parameterNode->name, |
|
113 | ); |
||
114 | } |
||
115 | |||
116 | /** |
||
117 | * Returns string representation of this parameter. |
||
118 | * |
||
119 | * @return string |
||
120 | */ |
||
121 | 3 | public function __toString() |
|
154 | |||
155 | /** |
||
156 | * {@inheritDoc} |
||
157 | */ |
||
158 | 2 | public function allowsNull() |
|
159 | { |
||
160 | 2 | $hasDefaultNull = $this->isDefaultValueAvailable() && $this->getDefaultValue() === null; |
|
161 | 2 | if ($hasDefaultNull) { |
|
162 | 2 | return true; |
|
163 | } |
||
164 | |||
165 | 2 | return !isset($this->parameterNode->type); |
|
166 | } |
||
167 | |||
168 | /** |
||
169 | * {@inheritDoc} |
||
170 | */ |
||
171 | 1 | public function canBePassedByValue() |
|
172 | { |
||
173 | 1 | return !$this->isPassedByReference(); |
|
174 | } |
||
175 | |||
176 | /** |
||
177 | * @inheritDoc |
||
178 | */ |
||
179 | 1 | public function getClass() |
|
180 | { |
||
181 | 1 | $parameterType = $this->parameterNode->type; |
|
182 | 1 | if ($parameterType instanceof Name) { |
|
183 | 1 | if (!$parameterType instanceof Name\FullyQualified) { |
|
184 | throw new ReflectionException("Can not resolve a class name for parameter"); |
||
185 | } |
||
186 | 1 | $className = $parameterType->toString(); |
|
187 | 1 | $classExists = class_exists($className, false); |
|
188 | |||
189 | 1 | return $classExists ? new \ReflectionClass($className) : new ReflectionClass($className); |
|
190 | } |
||
191 | |||
192 | 1 | return null; |
|
193 | } |
||
194 | |||
195 | /** |
||
196 | * {@inheritDoc} |
||
197 | */ |
||
198 | 2 | public function getDeclaringClass() |
|
199 | { |
||
200 | 2 | if ($this->declaringFunction instanceof \ReflectionMethod) { |
|
201 | 1 | return $this->declaringFunction->getDeclaringClass(); |
|
202 | }; |
||
203 | |||
204 | 1 | return null; |
|
205 | } |
||
206 | |||
207 | /** |
||
208 | * {@inheritDoc} |
||
209 | */ |
||
210 | 3 | public function getDeclaringFunction() |
|
211 | { |
||
212 | 3 | return $this->declaringFunction; |
|
213 | } |
||
214 | |||
215 | /** |
||
216 | * {@inheritDoc} |
||
217 | */ |
||
218 | 5 | public function getDefaultValue() |
|
219 | { |
||
220 | 5 | if (!$this->isDefaultValueAvailable()) { |
|
221 | 1 | throw new ReflectionException('Internal error: Failed to retrieve the default value'); |
|
222 | } |
||
223 | |||
224 | 4 | return $this->defaultValue; |
|
225 | } |
||
226 | |||
227 | /** |
||
228 | * {@inheritDoc} |
||
229 | */ |
||
230 | 2 | public function getDefaultValueConstantName() |
|
231 | { |
||
232 | 2 | if (!$this->isDefaultValueAvailable()) { |
|
233 | 1 | throw new ReflectionException('Internal error: Failed to retrieve the default value'); |
|
234 | } |
||
235 | |||
236 | 1 | return $this->defaultValueConstantName; |
|
237 | } |
||
238 | |||
239 | /** |
||
240 | * @inheritDoc |
||
241 | */ |
||
242 | 4 | public function getName() |
|
243 | { |
||
244 | 4 | return $this->parameterNode->name; |
|
245 | } |
||
246 | |||
247 | /** |
||
248 | * {@inheritDoc} |
||
249 | */ |
||
250 | 1 | public function getPosition() |
|
251 | { |
||
252 | 1 | return $this->parameterIndex; |
|
253 | } |
||
254 | |||
255 | /** |
||
256 | * @inheritDoc |
||
257 | */ |
||
258 | 1 | public function getType() |
|
273 | |||
274 | /** |
||
275 | * @inheritDoc |
||
276 | */ |
||
277 | 2 | public function hasType() |
|
283 | |||
284 | /** |
||
285 | * @inheritDoc |
||
286 | */ |
||
287 | 1 | public function isArray() |
|
288 | { |
||
289 | 1 | return 'array' === $this->parameterNode->type; |
|
290 | } |
||
291 | |||
292 | /** |
||
293 | * @inheritDoc |
||
294 | */ |
||
295 | 1 | public function isCallable() |
|
299 | |||
300 | /** |
||
301 | * @inheritDoc |
||
302 | */ |
||
303 | 10 | public function isDefaultValueAvailable() |
|
307 | |||
308 | /** |
||
309 | * {@inheritDoc} |
||
310 | */ |
||
311 | 1 | public function isDefaultValueConstant() |
|
315 | |||
316 | /** |
||
317 | * {@inheritDoc} |
||
318 | */ |
||
319 | 3 | public function isOptional() |
|
323 | |||
324 | /** |
||
325 | * @inheritDoc |
||
326 | */ |
||
327 | 3 | public function isPassedByReference() |
|
331 | |||
332 | /** |
||
333 | * @inheritDoc |
||
334 | */ |
||
335 | 3 | public function isVariadic() |
|
339 | |||
340 | /** |
||
341 | * Returns if all following parameters have a default value definition. |
||
342 | * |
||
343 | * @return bool |
||
344 | * @throws ReflectionException If could not fetch declaring function reflection |
||
345 | */ |
||
346 | 3 | protected function haveSiblingsDefalutValues() |
|
363 | } |
||
364 |