Complex classes like NodeExpressionResolver often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use NodeExpressionResolver, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
24 | class NodeExpressionResolver |
||
25 | { |
||
26 | |||
27 | /** |
||
28 | * List of exception for constant fetch |
||
29 | * |
||
30 | * @var array |
||
31 | */ |
||
32 | private static $notConstants = [ |
||
33 | 'true' => true, |
||
34 | 'false' => true, |
||
35 | 'null' => true, |
||
36 | ]; |
||
37 | |||
38 | /** |
||
39 | * Name of the constant (if present) |
||
40 | * |
||
41 | * @var null|string |
||
42 | */ |
||
43 | private $constantName = null; |
||
44 | |||
45 | /** |
||
46 | * Current reflection context for parsing |
||
47 | * |
||
48 | * @var mixed|\Go\ParserReflection\ReflectionClass |
||
49 | */ |
||
50 | private $context; |
||
51 | |||
52 | /** |
||
53 | * Flag if expression is constant |
||
54 | * |
||
55 | * @var bool |
||
56 | */ |
||
57 | private $isConstant = false; |
||
58 | |||
59 | /** |
||
60 | * Node resolving level, 1 = top-level |
||
61 | * |
||
62 | * @var int |
||
63 | */ |
||
64 | private $nodeLevel = 0; |
||
65 | |||
66 | /** |
||
67 | * @var mixed Value of expression/constant |
||
68 | */ |
||
69 | private $value; |
||
70 | |||
71 | 65 | public function __construct($context) |
|
75 | |||
76 | 18 | public function getConstantName() |
|
80 | |||
81 | 44 | public function getValue() |
|
85 | |||
86 | 18 | public function isConstant() |
|
90 | |||
91 | /** |
||
92 | * {@inheritDoc} |
||
93 | */ |
||
94 | 44 | public function process(Node $node) |
|
101 | |||
102 | /** |
||
103 | * Resolves node into valid value |
||
104 | * |
||
105 | * @param Node $node |
||
106 | * |
||
107 | * @return mixed |
||
108 | */ |
||
109 | 44 | protected function resolve(Node $node) |
|
126 | |||
127 | 9 | protected function resolveScalarDNumber(Scalar\DNumber $node) |
|
131 | |||
132 | 26 | protected function resolveScalarLNumber(Scalar\LNumber $node) |
|
136 | |||
137 | 22 | protected function resolveScalarString(Scalar\String_ $node) |
|
141 | |||
142 | protected function resolveScalarMagicConstMethod() |
||
152 | |||
153 | 1 | protected function resolveScalarMagicConstFunction() |
|
154 | { |
||
155 | 1 | if ($this->context instanceof \ReflectionFunctionAbstract) { |
|
156 | 1 | return $this->context->getName(); |
|
157 | } |
||
158 | |||
159 | return ''; |
||
160 | } |
||
161 | |||
162 | 28 | protected function resolveScalarMagicConstNamespace() |
|
163 | { |
||
164 | 28 | if (method_exists($this->context, 'getNamespaceName')) { |
|
165 | 24 | return $this->context->getNamespaceName(); |
|
166 | } |
||
167 | |||
168 | 4 | if ($this->context instanceof ReflectionFileNamespace) { |
|
169 | 4 | return $this->context->getName(); |
|
170 | } |
||
171 | |||
172 | return ''; |
||
173 | } |
||
174 | |||
175 | 10 | protected function resolveScalarMagicConstClass() |
|
189 | |||
190 | 3 | protected function resolveScalarMagicConstDir() |
|
198 | |||
199 | 6 | protected function resolveScalarMagicConstFile() |
|
207 | |||
208 | 6 | protected function resolveScalarMagicConstLine(MagicConst\Line $node) |
|
212 | |||
213 | 2 | protected function resolveScalarMagicConstTrait() |
|
221 | |||
222 | 25 | protected function resolveExprConstFetch(Expr\ConstFetch $node) |
|
256 | |||
257 | 10 | protected function resolveExprClassConstFetch(Expr\ClassConstFetch $node) |
|
272 | |||
273 | 9 | protected function resolveExprArray(Expr\Array_ $node) |
|
284 | |||
285 | 1 | protected function resolveExprBinaryOpPlus(Expr\BinaryOp\Plus $node) |
|
289 | |||
290 | 1 | protected function resolveExprBinaryOpMinus(Expr\BinaryOp\Minus $node) |
|
294 | |||
295 | 2 | protected function resolveExprBinaryOpMul(Expr\BinaryOp\Mul $node) |
|
299 | |||
300 | 1 | protected function resolveExprBinaryOpPow(Expr\BinaryOp\Pow $node) |
|
304 | |||
305 | 1 | protected function resolveExprBinaryOpDiv(Expr\BinaryOp\Div $node) |
|
309 | |||
310 | 1 | protected function resolveExprBinaryOpMod(Expr\BinaryOp\Mod $node) |
|
314 | |||
315 | 1 | protected function resolveExprBooleanNot(Expr\BooleanNot $node) |
|
319 | |||
320 | 1 | protected function resolveExprBitwiseNot(Expr\BitwiseNot $node) |
|
324 | |||
325 | 1 | protected function resolveExprBinaryOpBitwiseOr(Expr\BinaryOp\BitwiseOr $node) |
|
329 | |||
330 | 1 | protected function resolveExprBinaryOpBitwiseAnd(Expr\BinaryOp\BitwiseAnd $node) |
|
334 | |||
335 | 1 | protected function resolveExprBinaryOpBitwiseXor(Expr\BinaryOp\BitwiseXor $node) |
|
339 | |||
340 | 1 | protected function resolveExprBinaryOpShiftLeft(Expr\BinaryOp\ShiftLeft $node) |
|
344 | |||
345 | 1 | protected function resolveExprBinaryOpShiftRight(Expr\BinaryOp\ShiftRight $node) |
|
349 | |||
350 | 2 | protected function resolveExprBinaryOpConcat(Expr\BinaryOp\Concat $node) |
|
354 | |||
355 | 1 | protected function resolveExprTernary(Expr\Ternary $node) |
|
367 | |||
368 | 1 | protected function resolveExprBinaryOpSmallerOrEqual(Expr\BinaryOp\SmallerOrEqual $node) |
|
372 | |||
373 | 1 | protected function resolveExprBinaryOpGreaterOrEqual(Expr\BinaryOp\GreaterOrEqual $node) |
|
377 | |||
378 | 1 | protected function resolveExprBinaryOpEqual(Expr\BinaryOp\Equal $node) |
|
382 | |||
383 | 1 | protected function resolveExprBinaryOpNotEqual(Expr\BinaryOp\NotEqual $node) |
|
387 | |||
388 | 1 | protected function resolveExprBinaryOpSmaller(Expr\BinaryOp\Smaller $node) |
|
392 | |||
393 | 2 | protected function resolveExprBinaryOpGreater(Expr\BinaryOp\Greater $node) |
|
397 | |||
398 | 1 | protected function resolveExprBinaryOpIdentical(Expr\BinaryOp\Identical $node) |
|
402 | |||
403 | 1 | protected function resolveExprBinaryOpNotIdentical(Expr\BinaryOp\NotIdentical $node) |
|
407 | |||
408 | 1 | protected function resolveExprBinaryOpBooleanAnd(Expr\BinaryOp\BooleanAnd $node) |
|
412 | |||
413 | 1 | protected function resolveExprBinaryOpLogicalAnd(Expr\BinaryOp\LogicalAnd $node) |
|
417 | |||
418 | 1 | protected function resolveExprBinaryOpBooleanOr(Expr\BinaryOp\BooleanOr $node) |
|
422 | |||
423 | 1 | protected function resolveExprBinaryOpLogicalOr(Expr\BinaryOp\LogicalOr $node) |
|
427 | |||
428 | 1 | protected function resolveExprBinaryOpLogicalXor(Expr\BinaryOp\LogicalXor $node) |
|
432 | |||
433 | /** |
||
434 | * Utility method to fetch reflection class instance by name |
||
435 | * |
||
436 | * Supports: |
||
437 | * 'self' keyword |
||
438 | * 'parent' keyword |
||
439 | * not-FQN class names |
||
440 | * |
||
441 | * @param Node\Name $node Class name node |
||
442 | * |
||
443 | * @return bool|\ReflectionClass |
||
444 | * |
||
445 | * @throws ReflectionException |
||
446 | */ |
||
447 | 10 | private function fetchReflectionClass(Node\Name $node) |
|
490 | } |
||
491 |