Issues in ReflectionFile.php - All Issues - Inspection of "Fix NodeExpressionResolver to reflect system class..." - goaop/parser-reflection - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( b57357...0d5b50 )

by Alexander

created 2016-12-07 19:45 UTC

src/ReflectionFile.php (1 issue)

Labels

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
 * Parser Reflection API
 *
 * @copyright Copyright 2015, Lisachenko Alexander <[email protected]>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\ParserReflection;


use Go\ParserReflection\Instrument\PathResolver;
use PhpParser\Node;
use PhpParser\Node\Stmt\Namespace_;

/**
 * AST-based reflector for the source file
 */
class ReflectionFile
{

    /**
     * Name of the file for reflectino
     *
     * @var string
     */
    protected $fileName;

    /**
     * List of namespaces in the file
     *
     * @var ReflectionFileNamespace[]|array
     */
    protected $fileNamespaces;

    /**
     * Top-level nodes for the file
     *
     * @var Node[]
     */
    private $topLevelNodes;

    /**
     * ReflectionFile constructor.
     *
     * @param string $fileName Name of the file to reflect
     * @param null|array|Node[] $topLevelNodes Optional corresponding list of AST nodes for that file
     */
    public function __construct($fileName, $topLevelNodes = null)
    {
        $fileName            = PathResolver::realpath($fileName);
        $this->fileName      = $fileName;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->topLevelNodes = $topLevelNodes ?: ReflectionEngine::parseFile($fileName);
    }

    /**
     * Returns a namespace from the file or false if no such a namespace
     *
     * @param string $namespaceName
     *
     * @return bool|ReflectionFileNamespace
     */
    public function getFileNamespace($namespaceName)
    {
        if ($this->hasFileNamespace($namespaceName)) {
            return $this->fileNamespaces[$namespaceName];
        }

        return false;
    }

    /**
     * Gets the list of namespaces in the file
     *
     * @return array|ReflectionFileNamespace[]
     */
    public function getFileNamespaces()
    {
        if (!isset($this->fileNamespaces)) {
            $this->fileNamespaces = $this->findFileNamespaces();
        }

        return $this->fileNamespaces;
    }

    /**
     * Returns the name of current reflected file
     *
     * @return string
     */
    public function getName()
    {
        return $this->fileName;
    }

    /**
     * Returns the presence of namespace in the file
     *
     * @param string $namespaceName Namespace to check
     *
     * @return bool
     */
    public function hasFileNamespace($namespaceName)
    {
        $namespaces = $this->getFileNamespaces();

        return isset($namespaces[$namespaceName]);
    }

    /**
     * Searches for file namespaces in the given AST
     *
     * @return array|ReflectionFileNamespace[]
     */
    private function findFileNamespaces()
    {
        $namespaces = array();

        // namespaces can be only top-level nodes, so we can scan them directly
        foreach ($this->topLevelNodes as $topLevelNode) {
            if ($topLevelNode instanceof Namespace_) {
                $namespaceName = $topLevelNode->name ? $topLevelNode->name->toString() : '';

                $namespaces[$namespaceName] = new ReflectionFileNamespace(
                    $this->fileName,
                    $namespaceName,
                    $topLevelNode
                );
            }
        }

        return $namespaces;
    }
}


1		<?php
2		/**
3		* Parser Reflection API
4		*
5		* @copyright Copyright 2015, Lisachenko Alexander <[email protected]>
6		*
7		* This source file is subject to the license that is bundled
8		* with this source code in the file LICENSE.
9		*/
10
11		namespace Go\ParserReflection;
12
13
14		use Go\ParserReflection\Instrument\PathResolver;
15		use PhpParser\Node;
16		use PhpParser\Node\Stmt\Namespace_;
17
18		/**
19		* AST-based reflector for the source file
20		*/
21		class ReflectionFile
22		{
23
24		/**
25		* Name of the file for reflectino
26		*
27		* @var string
28		*/
29		protected $fileName;
30
31		/**
32		* List of namespaces in the file
33		*
34		* @var ReflectionFileNamespace[]\|array
35		*/
36		protected $fileNamespaces;
37
38		/**
39		* Top-level nodes for the file
40		*
41		* @var Node[]
42		*/
43		private $topLevelNodes;
44
45		/**
46		* ReflectionFile constructor.
47		*
48		* @param string $fileName Name of the file to reflect
49		* @param null\|array\|Node[] $topLevelNodes Optional corresponding list of AST nodes for that file
50		*/
51	145	public function __construct($fileName, $topLevelNodes = null)
52		{
53	145	$fileName = PathResolver::realpath($fileName);
54	145	$this->fileName = $fileName;
		0 ignored issues – show Documentation Bug introduced 2016-09-25 10:39 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$fileName` can also be of type `array` or `boolean`. However, the property `$fileName` is declared as type `string`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
55	145	$this->topLevelNodes = $topLevelNodes ?: ReflectionEngine::parseFile($fileName);
56	145	}
57
58		/**
59		* Returns a namespace from the file or false if no such a namespace
60		*
61		* @param string $namespaceName
62		*
63		* @return bool\|ReflectionFileNamespace
64		*/
65	136	public function getFileNamespace($namespaceName)
66		{
67	136	if ($this->hasFileNamespace($namespaceName)) {
68	136	return $this->fileNamespaces[$namespaceName];
69		}
70
71	1	return false;
72		}
73
74		/**
75		* Gets the list of namespaces in the file
76		*
77		* @return array\|ReflectionFileNamespace[]
78		*/
79	142	public function getFileNamespaces()
80		{
81	142	if (!isset($this->fileNamespaces)) {
82	142	$this->fileNamespaces = $this->findFileNamespaces();
83		}
84
85	142	return $this->fileNamespaces;
86		}
87
88		/**
89		* Returns the name of current reflected file
90		*
91		* @return string
92		*/
93	1	public function getName()
94		{
95	1	return $this->fileName;
96		}
97
98		/**
99		* Returns the presence of namespace in the file
100		*
101		* @param string $namespaceName Namespace to check
102		*
103		* @return bool
104		*/
105	137	public function hasFileNamespace($namespaceName)
106		{
107	137	$namespaces = $this->getFileNamespaces();
108
109	137	return isset($namespaces[$namespaceName]);
110		}
111
112		/**
113		* Searches for file namespaces in the given AST
114		*
115		* @return array\|ReflectionFileNamespace[]
116		*/
117	142	private function findFileNamespaces()
118		{
119	142	$namespaces = array();
120
121		// namespaces can be only top-level nodes, so we can scan them directly
122	142	foreach ($this->topLevelNodes as $topLevelNode) {
123	142	if ($topLevelNode instanceof Namespace_) {
124	142	$namespaceName = $topLevelNode->name ? $topLevelNode->name->toString() : '';
125
126	142	$namespaces[$namespaceName] = new ReflectionFileNamespace(
127	142	$this->fileName,
128		$namespaceName,
129		$topLevelNode
130		);
131		}
132		}
133
134	142	return $namespaces;
135		}
136		}
137

goaop / parser-reflection

Push — master ( b57357...0d5b50 )

src/ReflectionFile.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like