Go\Symfony\GoAopBundle\Tests\GoAopBundleTest

Complexity

Total Complexity

4

Size/Duplication

Total Lines	103
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes

0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	itThrowsExceptionWhenBundleIsNotRegisteredAsFirstBundle()	0	15	1
A	itRegistersAspectCollectorPassPass()	0	22	1
B	itBoots()	0	24	1
A	itThrowsExceptionOnBootWithoutAopComposerLoader()	0	19	1

<?php
/**
 * Go! AOP framework
 *
 * @copyright Copyright 2015, Lisachenko Alexander <lisachenko.it@gmail.com>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Symfony\GoAopBundle\Tests;

use Go\Instrument\ClassLoading\AopComposerLoader;
use Go\Symfony\GoAopBundle\DependencyInjection\Compiler\AspectCollectorPass;
use Go\Symfony\GoAopBundle\GoAopBundle;
use PHPUnit\Framework\TestCase;
use Symfony\Component\Debug\DebugClassLoader;
use Symfony\Component\DependencyInjection\ContainerBuilder;
use Symfony\Component\DependencyInjection\ContainerInterface;

/**
 * Class GoAopBundleTest
 */
class GoAopBundleTest extends TestCase
{
    /**
     * @test
     * @expectedException \InvalidArgumentException
     */
    public function itThrowsExceptionWhenBundleIsNotRegisteredAsFirstBundle()
    {
        $container = $this->getMockBuilder(ContainerBuilder::class)->getMock();

        $container
            ->method('getParameter')
            ->with('kernel.bundles')
            ->willReturn(['ArbitraryBundleName' => 'A bundle']);

        $bundle = new GoAopBundle();
        
        $bundle->getName(); // invoke resolution of bundle name

        $bundle->build($container);
    }

    /**
     * @test
     */
    public function itRegistersAspectCollectorPassPass()
    {
        $container = $this->getMockBuilder(ContainerBuilder::class)->getMock();

        $container
            ->method('getParameter')
            ->with('kernel.bundles')
            ->willReturn(['GoAopBundle' => 'A bundle']);

        $container
            ->expects($spy = $this->exactly(1))
            ->method('addCompilerPass');

        $bundle = new GoAopBundle();

        $bundle->getName(); // invoke resolution of bundle name

        $bundle->build($container);

        $invocation = $spy->getInvocations()[0];
        $this->assertInstanceOf(AspectCollectorPass::class, $invocation->parameters[0]);

Accessing parameters on the interface PHPUnit_Framework_MockObject_Invocation suggest that you code against a concrete implementation. How about adding an instanceof check?

    }

    /**
     * @test
     * @runInSeparateProcess
     */
    public function itBoots()
    {
        require_once __DIR__.'/Fixtures/mock/DebugClassLoader.php';
        require_once __DIR__.'/Fixtures/mock/AopComposerLoader.php';

        $container = $this->getMockBuilder(ContainerInterface::class)->getMock();

        $container
            ->expects($this->once())
            ->method('get')
            ->with('goaop.aspect.container');

        $bundle = new GoAopBundle();
        $bundle->setContainer($container);

        DebugClassLoader::reset();
        DebugClassLoader::enable();
        $this->assertTrue(DebugClassLoader::$enabled);

        $bundle->boot();

        $this->assertTrue(DebugClassLoader::$enabled);
        $this->assertEquals(['enable', 'disable', 'enable'], DebugClassLoader::$invocations);
    }

    /**
     * @test
     * @runInSeparateProcess
     * @expectedException \RuntimeException
     * @expectedExceptionMessage Initialization of AOP loader was failed, probably due to Debug::enable()
     */
    public function itThrowsExceptionOnBootWithoutAopComposerLoader()
    {
        require_once __DIR__.'/Fixtures/mock/DebugClassLoader.php';
        require_once __DIR__.'/Fixtures/mock/AopComposerLoader.php';

        $container = $this->getMockBuilder(ContainerInterface::class)->getMock();

        $container
            ->expects($this->once())
            ->method('get')
            ->with('goaop.aspect.container');

        $bundle = new GoAopBundle();
        $bundle->setContainer($container);

        AopComposerLoader::$initialized = false;

        $bundle->boot();
    }
}