Issues in FunctionCallArgumentListGenerator.php (master) - Issues in master - goaop/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (87)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Proxy/Part/FunctionCallArgumentListGenerator.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);
/*
 * Go! AOP framework
 *
 * @copyright Copyright 2018, Lisachenko Alexander <[email protected]>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Proxy\Part;

use Laminas\Code\Generator\AbstractGenerator;
use ReflectionFunctionAbstract;

/**
 * Prepares the function call argument list
 */
final class FunctionCallArgumentListGenerator extends AbstractGenerator
{
    /**
     * List of function arguments
     *
     * @var string[]
     */
    private array $arguments = [];


    /**
     * If function contains optional arguments
     */
    private bool $hasOptionals = false;

    /**
     * Definition of variadic argument or null if function is not variadic
     */
    private ?string $variadicArgument = null;

    /**
     * FunctionCallArgumentList constructor.
     *
     * @param ReflectionFunctionAbstract $functionLike Instance of function or method to call
     */
    public function __construct(ReflectionFunctionAbstract $functionLike)
    {
        parent::__construct();

        foreach ($functionLike->getParameters() as $parameter) {
            $byReference  = ($parameter->isPassedByReference() && !$parameter->isVariadic()) ? '&' : '';
            $this->hasOptionals = $this->hasOptionals || $parameter->isOptional();
            $this->arguments[]  = $byReference . '$' . $parameter->name;
        }
        if ($functionLike->isVariadic()) {
            // Variadic argument is last and should be handled separately
            $this->variadicArgument = array_pop($this->arguments);
        }
    }

    /**
     * @inheritDoc
     */
    public function generate(): string
    {
        $argumentsPart = [];
        if ($this->variadicArgument !== null) {
            $argumentsPart[] = $this->variadicArgument;
        }
        if (!empty($this->arguments)) {
            $argumentLine = '[' . implode(', ', $this->arguments) . ']';
            if ($this->hasOptionals) {
                $argumentLine = "\\array_slice($argumentLine, 0, \\func_num_args())";
            }
            array_unshift($argumentsPart, $argumentLine);
        }

        return implode(', ', $argumentsPart);
    }
}


1		<?php
2
3		declare(strict_types=1);
4		/*
5		* Go! AOP framework
6		*
7		* @copyright Copyright 2018, Lisachenko Alexander <[email protected]>
8		*
9		* This source file is subject to the license that is bundled
10		* with this source code in the file LICENSE.
11		*/
12
13		namespace Go\Proxy\Part;
14
15		use Laminas\Code\Generator\AbstractGenerator;
16		use ReflectionFunctionAbstract;
17
18		/**
19		* Prepares the function call argument list
20		*/
21		final class FunctionCallArgumentListGenerator extends AbstractGenerator
22		{
23		/**
24		* List of function arguments
25		*
26		* @var string[]
27		*/
28		private array $arguments = [];
		0 ignored issues – show Bug introduced 2021-01-04 17:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_ARRAY, expecting T_FUNCTION or T_CONST Loading history...
29
30		/**
31		* If function contains optional arguments
32		*/
33		private bool $hasOptionals = false;
34
35		/**
36		* Definition of variadic argument or null if function is not variadic
37		*/
38		private ?string $variadicArgument = null;
39
40		/**
41		* FunctionCallArgumentList constructor.
42		*
43		* @param ReflectionFunctionAbstract $functionLike Instance of function or method to call
44		*/
45		public function __construct(ReflectionFunctionAbstract $functionLike)
46	17	{
47		parent::__construct();
48	17
49		foreach ($functionLike->getParameters() as $parameter) {
50	17	$byReference = ($parameter->isPassedByReference() && !$parameter->isVariadic()) ? '&' : '';
51	12	$this->hasOptionals = $this->hasOptionals \|\| $parameter->isOptional();
52	12	$this->arguments[] = $byReference . '$' . $parameter->name;
53	12	}
54		if ($functionLike->isVariadic()) {
55	17	// Variadic argument is last and should be handled separately
56		$this->variadicArgument = array_pop($this->arguments);
57	3	}
58		}
59	17
60		/**
61		* @inheritDoc
62		*/
63		public function generate(): string
64	17	{
65		$argumentsPart = [];
66	17	if ($this->variadicArgument !== null) {
67	17	$argumentsPart[] = $this->variadicArgument;
68	3	}
69		if (!empty($this->arguments)) {
70	17	$argumentLine = '[' . implode(', ', $this->arguments) . ']';
71	11	if ($this->hasOptionals) {
72	11	$argumentLine = "\\array_slice($argumentLine, 0, \\func_num_args())";
73	5	}
74		array_unshift($argumentsPart, $argumentLine);
75	11	}
76
77		return implode(', ', $argumentsPart);
78	17	}
79		}
80

goaop / framework

Issues (87)

Security Analysis no request data

Proxy/Part/FunctionCallArgumentListGenerator.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like