Issues in AnnotationPointcut.php (master) - Issues in master - goaop/framework - Measure and Improve Code Quality continuously with Scrutinizer

Issues (87)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Aop/Pointcut/AnnotationPointcut.php (1 issue)

Labels

Bug 1

Severity

Critical 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

declare(strict_types=1);
/*
 * Go! AOP framework
 *
 * @copyright Copyright 2012, Lisachenko Alexander <[email protected]>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Aop\Pointcut;

use Doctrine\Common\Annotations\Reader;
use Go\Aop\Pointcut;
use InvalidArgumentException;
use ReflectionClass;
use ReflectionMethod;
use ReflectionProperty;

/**
 * Annotation property pointcut checks property annotation
 */
class AnnotationPointcut implements Pointcut
{
    use PointcutClassFilterTrait;

    /**
     * Annotation class to match
     */
    protected string $annotationName;


    /**
     * Annotation reader
     */
    protected Reader $annotationReader;

    /**
     * Kind of current filter, can be KIND_CLASS, KIND_METHOD, KIND_PROPERTY, KIND_TRAIT
     */
    protected int $filterKind = 0;

    /**
     * Specifies name of the expected class to receive
     */
    protected string $expectedClass = '';

    /**
     * Method to call for annotation reader
     */
    protected string $annotationMethod = '';

    /**
     * Static mappings of kind to expected class and method name
     */
    protected static array $mappings = [
        self::KIND_CLASS    => [ReflectionClass::class, 'getClassAnnotation'],
        self::KIND_TRAIT    => [ReflectionClass::class, 'getClassAnnotation'],
        self::KIND_METHOD   => [ReflectionMethod::class, 'getMethodAnnotation'],
        self::KIND_PROPERTY => [ReflectionProperty::class, 'getPropertyAnnotation']
    ];

    /**
     * Annotation matcher constructor
     *
     * @param int $filterKind Kind of filter, e.g. KIND_CLASS
     */
    public function __construct(int $filterKind, Reader $annotationReader, string $annotationName)
    {
        if (!isset(self::$mappings[$filterKind])) {
            throw new InvalidArgumentException("Unsupported filter kind {$filterKind}");
        }
        $this->filterKind       = $filterKind;
        $this->annotationName   = $annotationName;
        $this->annotationReader = $annotationReader;

        [$this->expectedClass, $this->annotationMethod] = self::$mappings[$filterKind];
    }

    /**
     * {@inheritdoc}
     */
    public function matches($point, $context = null, $instance = null, array $arguments = null): bool
    {
        $expectedClass = $this->expectedClass;
        if (!$point instanceof $expectedClass) {
            return false;
        }

        $annotation = $this->annotationReader->{$this->annotationMethod}($point, $this->annotationName);

        return (bool)$annotation;
    }

    /**
     * Returns the kind of point filter
     */
    public function getKind(): int
    {
        return $this->filterKind;
    }
}


1		<?php
2
3		declare(strict_types=1);
4		/*
5		* Go! AOP framework
6		*
7		* @copyright Copyright 2012, Lisachenko Alexander <[email protected]>
8		*
9		* This source file is subject to the license that is bundled
10		* with this source code in the file LICENSE.
11		*/
12
13		namespace Go\Aop\Pointcut;
14
15		use Doctrine\Common\Annotations\Reader;
16		use Go\Aop\Pointcut;
17		use InvalidArgumentException;
18		use ReflectionClass;
19		use ReflectionMethod;
20		use ReflectionProperty;
21
22		/**
23		* Annotation property pointcut checks property annotation
24		*/
25		class AnnotationPointcut implements Pointcut
26		{
27		use PointcutClassFilterTrait;
28
29		/**
30		* Annotation class to match
31		*/
32		protected string $annotationName;
		0 ignored issues – show Bug introduced 2021-01-04 17:05 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code did not parse for me. Apparently, there is an error somewhere around this line: Syntax error, unexpected T_STRING, expecting T_FUNCTION or T_CONST Loading history...
33
34		/**
35		* Annotation reader
36		*/
37		protected Reader $annotationReader;
38
39		/**
40		* Kind of current filter, can be KIND_CLASS, KIND_METHOD, KIND_PROPERTY, KIND_TRAIT
41		*/
42		protected int $filterKind = 0;
43
44		/**
45		* Specifies name of the expected class to receive
46		*/
47		protected string $expectedClass = '';
48
49		/**
50		* Method to call for annotation reader
51		*/
52		protected string $annotationMethod = '';
53
54		/**
55		* Static mappings of kind to expected class and method name
56		*/
57		protected static array $mappings = [
58		self::KIND_CLASS => [ReflectionClass::class, 'getClassAnnotation'],
59		self::KIND_TRAIT => [ReflectionClass::class, 'getClassAnnotation'],
60		self::KIND_METHOD => [ReflectionMethod::class, 'getMethodAnnotation'],
61		self::KIND_PROPERTY => [ReflectionProperty::class, 'getPropertyAnnotation']
62		];
63
64		/**
65		* Annotation matcher constructor
66		*
67		* @param int $filterKind Kind of filter, e.g. KIND_CLASS
68		*/
69		public function __construct(int $filterKind, Reader $annotationReader, string $annotationName)
70		{
71		if (!isset(self::$mappings[$filterKind])) {
72		throw new InvalidArgumentException("Unsupported filter kind {$filterKind}");
73		}
74		$this->filterKind = $filterKind;
75		$this->annotationName = $annotationName;
76	4	$this->annotationReader = $annotationReader;
77
78	4	[$this->expectedClass, $this->annotationMethod] = self::$mappings[$filterKind];
79		}
80
81	4	/**
82	4	* {@inheritdoc}
83	4	*/
84		public function matches($point, $context = null, $instance = null, array $arguments = null): bool
85	4	{
86	4	$expectedClass = $this->expectedClass;
87		if (!$point instanceof $expectedClass) {
88		return false;
89		}
90
91	1	$annotation = $this->annotationReader->{$this->annotationMethod}($point, $this->annotationName);
92
93	1	return (bool)$annotation;
94	1	}
95
96		/**
97		* Returns the kind of point filter
98	1	*/
99		public function getKind(): int
100	1	{
101		return $this->filterKind;
102		}
103		}
104

goaop / framework

Issues (87)

Security Analysis no request data

src/Aop/Pointcut/AnnotationPointcut.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like