DynamicClosureMethodInvocation::getThis() - Code Metrics - Inspection of "[BC BREAK] Introduce new ClassJoinpoint->getScope(..." - goaop/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#429)

by Alexander

created 2019-08-14 13:26 UTC

DynamicClosureMethodInvocation::getThis() A

↳ Parent: DynamicClosureMethodInvocation

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	0
crap	2

<?php
declare(strict_types = 1);
/*
 * Go! AOP framework
 *
 * @copyright Copyright 2015, Lisachenko Alexander <[email protected]>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Aop\Framework;

use function get_class;

/**
 * Dynamic closure method invocation is responsible to call dynamic methods via closure
 */
final class DynamicClosureMethodInvocation extends AbstractMethodInvocation
{
    /**
     * Closure to use
     *
     * @var \Closure
     */
    protected $closureToCall;

    /**
     * Previous instance of invocation
     *
     * @var null|object
     */
    protected $previousInstance;

    /**
     * Invokes original method and return result from it
     *
     * @return mixed
     */
    public function proceed()
    {
        if (isset($this->advices[$this->current])) {
            $currentInterceptor = $this->advices[$this->current++];

            return $currentInterceptor->invoke($this);
        }

        // Fill the closure only once if it's empty
        if ($this->closureToCall === null) {
            $this->closureToCall    = $this->reflectionMethod->getClosure($this->instance);
            $this->previousInstance = $this->instance;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        }

        // Rebind the closure if instance was changed since last time
        if ($this->previousInstance !== $this->instance) {
            $this->closureToCall    = $this->closureToCall->bindTo($this->instance, $this->reflectionMethod->class);
            $this->previousInstance = $this->instance;
        }

        return ($this->closureToCall)(...$this->arguments);
    }

    /**
     * Returns the object for which current joinpoint is invoked
     *
     * @return object Instance of object or null for static call/unavailable context
     */
    final public function getThis(): ?object
    {
        return $this->instance;

    }

    /**
     * Checks if the current joinpoint is dynamic or static
     *
     * Dynamic joinpoint contains a reference to an object that can be received via getThis() method call
     * @see ClassJoinpoint::getThis()
     */
    final public function isDynamic(): bool
    {
        return true;
    }

    /**
     * Returns the static scope name (class name) of this joinpoint.
     */
    final public function getScope(): string
    {
        // $this->instance always contains an object, so we can take it's name as a scope name
        return get_class($this->instance);
    }
}


1		<?php
2		declare(strict_types = 1);
3		/*
4		* Go! AOP framework
5		*
6		* @copyright Copyright 2015, Lisachenko Alexander <[email protected]>
7		*
8		* This source file is subject to the license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Go\Aop\Framework;
13
14		use function get_class;
15
16		/**
17		* Dynamic closure method invocation is responsible to call dynamic methods via closure
18		*/
19		final class DynamicClosureMethodInvocation extends AbstractMethodInvocation
20		{
21		/**
22		* Closure to use
23		*
24		* @var \Closure
25		*/
26		protected $closureToCall;
27
28		/**
29		* Previous instance of invocation
30		*
31		* @var null\|object
32		*/
33		protected $previousInstance;
34
35		/**
36		* Invokes original method and return result from it
37		*
38	7	* @return mixed
39		*/
40	7	public function proceed()
41	1	{
42		if (isset($this->advices[$this->current])) {
43	1	$currentInterceptor = $this->advices[$this->current++];
44
45		return $currentInterceptor->invoke($this);
46		}
47	7
48	7	// Fill the closure only once if it's empty
49	7	if ($this->closureToCall === null) {
50		$this->closureToCall = $this->reflectionMethod->getClosure($this->instance);
51		$this->previousInstance = $this->instance;
		0 ignored issues – show Documentation Bug introduced 2019-08-14 13:50 UTC by Report Bug Copy Issue Report It seems like `$this->instance` can also be of type `string`. However, the property `$previousInstance` is declared as type `null\|object`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
52		}
53	7
54		// Rebind the closure if instance was changed since last time
55		if ($this->previousInstance !== $this->instance) {
56		$this->closureToCall = $this->closureToCall->bindTo($this->instance, $this->reflectionMethod->class);
57		$this->previousInstance = $this->instance;
58	7	}
59
60		return ($this->closureToCall)(...$this->arguments);
61		}
62
63		/**
64		* Returns the object for which current joinpoint is invoked
65		*
66		* @return object Instance of object or null for static call/unavailable context
67		*/
68		final public function getThis(): ?object
69		{
70		return $this->instance;
		0 ignored issues – show Bug Compatibility introduced 2019-08-14 13:50 UTC by Report Bug Copy Issue Report The expression `$this->instance;` of type `object\|string` adds the type `string` to the return on line 70 which is incompatible with the return type declared by the interface `Go\Aop\Intercept\ClassJoinpoint::getThis` of type `object\|null`. Loading history...
71		}
72
73		/**
74		* Checks if the current joinpoint is dynamic or static
75		*
76		* Dynamic joinpoint contains a reference to an object that can be received via getThis() method call
77		* @see ClassJoinpoint::getThis()
78		*/
79		final public function isDynamic(): bool
80		{
81		return true;
82		}
83
84		/**
85		* Returns the static scope name (class name) of this joinpoint.
86		*/
87		final public function getScope(): string
88		{
89		// $this->instance always contains an object, so we can take it's name as a scope name
90		return get_class($this->instance);
91		}
92		}
93

goaop / framework

Pull Request — master (#429)

DynamicClosureMethodInvocation::getThis() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like