GoAspectContainer::getPointcut() - Code Metrics - Inspection of "Rewrite framework with PHP7.0 features" - goaop/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#320)

by Alexander

created 2017-03-26 20:42 UTC

GoAspectContainer::getPointcut() A

↳ Parent: GoAspectContainer

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	0
loc	4
ccs	0
cts	0
cp	0
rs	10
c	0
b	0
f	0
cc	1
eloc	2
nc	1
nop	1
crap	2

<?php
declare(strict_types = 1);
/*
 * Go! AOP framework
 *
 * @copyright Copyright 2012, Lisachenko Alexander <[email protected]>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Core;

use Doctrine\Common\Annotations\FileCacheReader;
use ReflectionClass;
use Go\Aop;
use Go\Aop\Pointcut\PointcutLexer;
use Go\Aop\Pointcut\PointcutGrammar;
use Go\Aop\Pointcut\PointcutParser;
use Go\Instrument\ClassLoading\CachePathManager;
use Doctrine\Common\Annotations\AnnotationReader;

/**
 * Aspect container contains list of all pointcuts and advisors
 */
class GoAspectContainer extends Container implements AspectContainer
{
    /**
     * List of resources for application
     *
     * @var array
     */
    protected $resources = [];

    /**
     * Cached timestamp for resources
     *
     * @var integer
     */
    protected $maxTimestamp = 0;

    /**
     * Constructor for container
     */
    public function __construct()
    {
        // Register all services in the container
        $this->share('aspect.loader', function(Container $container) {

            $aspectLoader = new AspectLoader(
                $container,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $container->get('aspect.annotation.reader')
            );
            $lexer  = $container->get('aspect.pointcut.lexer');
            $parser = $container->get('aspect.pointcut.parser');

            // Register general aspect loader extension
            $aspectLoader->registerLoaderExtension(new GeneralAspectLoaderExtension($lexer, $parser));
            $aspectLoader->registerLoaderExtension(new IntroductionAspectExtension($lexer, $parser));

            return $aspectLoader;
        });

        $this->share('aspect.cached.loader', function(Container $container) {

            $options = $container->get('kernel.options');
            if (!empty($options['cacheDir'])) {
                $loader = new CachedAspectLoader(
                    $container,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    'aspect.loader',
                    $container->get('kernel.options')
                );
            } else {
                $loader = $container->get('aspect.loader');
            }

            return $loader;
        });

        $this->share('aspect.advisor.accessor', function(Container $container) {

            return new LazyAdvisorAccessor(
                $container,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $container->get('aspect.cached.loader')
            );
        });

        $this->share('aspect.advice_matcher', function(Container $container) {

            return new AdviceMatcher(
                $container->get('aspect.loader'),
                $container->get('kernel.interceptFunctions')
            );
        });

        $this->share('aspect.annotation.reader', function(Container $container) {

            $options = $container->get('kernel.options');
            $reader  = new AnnotationReader();
            if (!empty($options['cacheDir'])) {
                $reader = new FileCacheReader(

                    $reader,
                    $options['cacheDir'] . DIRECTORY_SEPARATOR . '_annotations' . DIRECTORY_SEPARATOR,
                    $options['debug'],
                    0777 & (~$options['cacheFileMode'])
                );
            }

            return $reader;
        });
        $this->share('aspect.cache.path.manager', function(Container $container) {

            return new CachePathManager($container->get('kernel'));
        });

        // Pointcut services
        $this->share('aspect.pointcut.lexer', function() {

            return new PointcutLexer();
        });
        $this->share('aspect.pointcut.parser', function(Container $container) {

            return new PointcutParser(
                new PointcutGrammar(
                    $container,
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                    $container->get('aspect.annotation.reader')
                )
            );
        });
    }

    /**
     * Returns a pointcut by identifier
     *
     * @param string $id Pointcut identifier
     *
     * @return Aop\Pointcut
     */
    public function getPointcut($id)
    {
        return $this->get("pointcut.{$id}");
    }

    /**
     * Store the pointcut in the container
     *
     * @param Aop\Pointcut $pointcut Instance
     * @param string $id Key for pointcut
     */
    public function registerPointcut(Aop\Pointcut $pointcut, $id)
    {
        $this->set("pointcut.{$id}", $pointcut, ['pointcut']);
    }

    /**
     * Returns an advisor by identifier
     *
     * @param string $id Advisor identifier
     *
     * @return Aop\Advisor
     */
    public function getAdvisor($id)
    {
        return $this->get("advisor.{$id}");
    }

    /**
     * Store the advisor in the container
     *
     * @param Aop\Advisor $advisor Instance
     * @param string $id Key for advisor
     */
    public function registerAdvisor(Aop\Advisor $advisor, $id)
    {
        $this->set("advisor.{$id}", $advisor, ['advisor']);
    }

    /**
     * Returns an aspect by id or class name
     *
     * @param string $aspectName Aspect name
     *
     * @return Aop\Aspect
     */
    public function getAspect($aspectName)
    {
        return $this->get("aspect.{$aspectName}");
    }

    /**
     * Register an aspect in the container
     *
     * @param Aop\Aspect $aspect Instance of concrete aspect
     */
    public function registerAspect(Aop\Aspect $aspect)
    {
        $refAspect = new ReflectionClass($aspect);
        $this->set("aspect.{$refAspect->name}", $aspect, ['aspect']);
        $this->addResource($refAspect->getFileName());
    }

    /**
     * Add an AOP resource to the container
     *
     * Resources is used to check the freshness of AOP cache
     */
    public function addResource($resource)
    {
        $this->resources[]  = $resource;
        $this->maxTimestamp = 0;
    }

    /**
     * Returns list of AOP resources
     *
     * @return array
     */
    public function getResources()
    {
        return $this->resources;
    }

    /**
     * Checks the freshness of AOP cache
     *
     * @param integer $timestamp
     *
     * @return bool Whether or not concrete file is fresh
     */
    public function isFresh($timestamp)
    {
        if (!$this->maxTimestamp && !empty($this->resources)) {
            $this->maxTimestamp = max(array_map('filemtime', $this->resources));
        }

        return $this->maxTimestamp <= $timestamp;
    }
}


1		<?php
2		declare(strict_types = 1);
3		/*
4		* Go! AOP framework
5		*
6		* @copyright Copyright 2012, Lisachenko Alexander <[email protected]>
7		*
8		* This source file is subject to the license that is bundled
9		* with this source code in the file LICENSE.
10		*/
11
12		namespace Go\Core;
13
14		use Doctrine\Common\Annotations\FileCacheReader;
15		use ReflectionClass;
16		use Go\Aop;
17		use Go\Aop\Pointcut\PointcutLexer;
18		use Go\Aop\Pointcut\PointcutGrammar;
19		use Go\Aop\Pointcut\PointcutParser;
20		use Go\Instrument\ClassLoading\CachePathManager;
21		use Doctrine\Common\Annotations\AnnotationReader;
22
23		/**
24		* Aspect container contains list of all pointcuts and advisors
25		*/
26		class GoAspectContainer extends Container implements AspectContainer
27		{
28		/**
29		* List of resources for application
30		*
31		* @var array
32		*/
33		protected $resources = [];
34
35		/**
36		* Cached timestamp for resources
37		*
38		* @var integer
39		*/
40		protected $maxTimestamp = 0;
41
42		/**
43		* Constructor for container
44		*/
45	9	public function __construct()
46		{
47		// Register all services in the container
48		$this->share('aspect.loader', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
49	2	$aspectLoader = new AspectLoader(
50		$container,
		0 ignored issues – show Documentation introduced 2015-11-22 20:20 UTC by Report Bug Copy Issue Report `$container` is of type `object<Go\Core\Container>`, but the function expects a `object<Go\Core\AspectContainer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
51	2	$container->get('aspect.annotation.reader')
52		);
53	2	$lexer = $container->get('aspect.pointcut.lexer');
54	2	$parser = $container->get('aspect.pointcut.parser');
55
56		// Register general aspect loader extension
57	2	$aspectLoader->registerLoaderExtension(new GeneralAspectLoaderExtension($lexer, $parser));
58	2	$aspectLoader->registerLoaderExtension(new IntroductionAspectExtension($lexer, $parser));
59
60	2	return $aspectLoader;
61	9	});
62
63		$this->share('aspect.cached.loader', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
64		$options = $container->get('kernel.options');
65		if (!empty($options['cacheDir'])) {
66		$loader = new CachedAspectLoader(
67		$container,
		0 ignored issues – show Documentation introduced 2015-11-22 20:20 UTC by Report Bug Copy Issue Report `$container` is of type `object<Go\Core\Container>`, but the function expects a `object<Go\Core\AspectContainer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
68		'aspect.loader',
69		$container->get('kernel.options')
70		);
71	9	} else {
72		$loader = $container->get('aspect.loader');
73		}
74
75		return $loader;
76		});
77
78	9	$this->share('aspect.advisor.accessor', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
79		return new LazyAdvisorAccessor(
80		$container,
		0 ignored issues – show Documentation introduced 2015-11-22 20:20 UTC by Report Bug Copy Issue Report `$container` is of type `object<Go\Core\Container>`, but the function expects a `object<Go\Core\AspectContainer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
81	1	$container->get('aspect.cached.loader')
82	1	);
83	1	});
84
85	9	$this->share('aspect.advice_matcher', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
86		return new AdviceMatcher(
87		$container->get('aspect.loader'),
88	4	$container->get('kernel.interceptFunctions')
89	4	);
90	4	});
91
92		$this->share('aspect.annotation.reader', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
93		$options = $container->get('kernel.options');
94		$reader = new AnnotationReader();
95		if (!empty($options['cacheDir'])) {
96		$reader = new FileCacheReader(
		0 ignored issues – show Deprecated Code introduced 2015-11-22 20:20 UTC by Report Bug Copy Issue Report The class `Doctrine\Common\Annotations\FileCacheReader` has been deprecated with message: the FileCacheReader is deprecated and will be removed in version 2.0.0 of doctrine/annotations. Please use the {@see \Doctrine\Common\Annotations\CachedReader} instead. This class, trait or interface has been deprecated. The supplier of the file has supplied an explanatory message. The explanatory message should give you some clue as to whether and when the type will be removed from the class and what other constant to use instead. Loading history...
97		$reader,
98		$options['cacheDir'] . DIRECTORY_SEPARATOR . '_annotations' . DIRECTORY_SEPARATOR,
99	4	$options['debug'],
100	9	0777 & (~$options['cacheFileMode'])
101		);
102		}
103	9
104		return $reader;
105		});
106		$this->share('aspect.cache.path.manager', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
107	3	return new CachePathManager($container->get('kernel'));
108	9	});
109	9
110	3	// Pointcut services
111	3	$this->share('aspect.pointcut.lexer', function() {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
112		return new PointcutLexer();
113	3	});
114		$this->share('aspect.pointcut.parser', function(Container $container) {
		0 ignored issues – show Coding Style introduced 2016-02-28 20:13 UTC by Report Bug Copy Issue Report Expected 1 space after FUNCTION keyword; 0 found Loading history...
115		return new PointcutParser(
116	9	new PointcutGrammar(
117	9	$container,
		0 ignored issues – show Documentation introduced 2016-02-13 13:50 UTC by Report Bug Copy Issue Report `$container` is of type `object<Go\Core\Container>`, but the function expects a `object<Go\Core\AspectContainer>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
118		$container->get('aspect.annotation.reader')
119		)
120		);
121		});
122		}
123
124		/**
125		* Returns a pointcut by identifier
126	1	*
127		* @param string $id Pointcut identifier
128	1	*
129		* @return Aop\Pointcut
130		*/
131		public function getPointcut($id)
132		{
133		return $this->get("pointcut.{$id}");
134		}
135
136		/**
137	1	* Store the pointcut in the container
138		*
139	1	* @param Aop\Pointcut $pointcut Instance
140	1	* @param string $id Key for pointcut
141		*/
142		public function registerPointcut(Aop\Pointcut $pointcut, $id)
143		{
144		$this->set("pointcut.{$id}", $pointcut, ['pointcut']);
145		}
146
147		/**
148		* Returns an advisor by identifier
149		*
150		* @param string $id Advisor identifier
151		*
152		* @return Aop\Advisor
153		*/
154		public function getAdvisor($id)
155		{
156		return $this->get("advisor.{$id}");
157		}
158
159		/**
160	1	* Store the advisor in the container
161		*
162	1	* @param Aop\Advisor $advisor Instance
163	1	* @param string $id Key for advisor
164		*/
165		public function registerAdvisor(Aop\Advisor $advisor, $id)
166		{
167		$this->set("advisor.{$id}", $advisor, ['advisor']);
168		}
169
170		/**
171		* Returns an aspect by id or class name
172	1	*
173		* @param string $aspectName Aspect name
174	1	*
175		* @return Aop\Aspect
176		*/
177		public function getAspect($aspectName)
178		{
179		return $this->get("aspect.{$aspectName}");
180		}
181
182	1	/**
183		* Register an aspect in the container
184	1	*
185	1	* @param Aop\Aspect $aspect Instance of concrete aspect
186	1	*/
187	1	public function registerAspect(Aop\Aspect $aspect)
188		{
189		$refAspect = new ReflectionClass($aspect);
190		$this->set("aspect.{$refAspect->name}", $aspect, ['aspect']);
191		$this->addResource($refAspect->getFileName());
192		}
193
194	2	/**
195		* Add an AOP resource to the container
196	2	*
197	2	* Resources is used to check the freshness of AOP cache
198	2	*/
199		public function addResource($resource)
200		{
201		$this->resources[] = $resource;
202		$this->maxTimestamp = 0;
203		}
204
205		/**
206		* Returns list of AOP resources
207		*
208		* @return array
209		*/
210		public function getResources()
211		{
212		return $this->resources;
213		}
214
215		/**
216		* Checks the freshness of AOP cache
217	1	*
218		* @param integer $timestamp
219	1	*
220	1	* @return bool Whether or not concrete file is fresh
221		*/
222		public function isFresh($timestamp)
223	1	{
224		if (!$this->maxTimestamp && !empty($this->resources)) {
225		$this->maxTimestamp = max(array_map('filemtime', $this->resources));
226		}
227
228		return $this->maxTimestamp <= $timestamp;
229		}
230		}
231

goaop / framework

Pull Request — master (#320)

GoAspectContainer::getPointcut() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like