Go\Aop\Pointcut\OrPointcut

Complexity

Total Complexity

10

Size/Duplication

Total Lines	47
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Test Coverage

Coverage

82.35%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	1
A	matches()	0	5	2
B	matchPart()	0	14	7

<?php
declare(strict_types = 1);
/*
 * Go! AOP framework
 *
 * @copyright Copyright 2013, Lisachenko Alexander <lisachenko.it@gmail.com>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Aop\Pointcut;

use Go\Aop\Pointcut;
use Go\Aop\PointFilter;
use Go\Aop\Support\OrPointFilter;

/**
 * Logical "OR" pointcut that combines two simple pointcuts
 */
class OrPointcut extends AndPointcut
{

    /**
     * "Or" pointcut constructor
     */
    public function __construct(Pointcut $first, Pointcut $second)
    {
        $this->first  = $first;
        $this->second = $second;
        $this->kind   = $first->getKind() | $second->getKind();

        $this->classFilter = new OrPointFilter($first->getClassFilter(), $second->getClassFilter());
    }

    /**
     * Performs matching of point of code
     *
     * @param mixed $point Specific part of code, can be any Reflection class
     * @param null|mixed $context Related context, can be class or namespace
     * @param null|string|object $instance Invocation instance or string for static calls
     * @param null|array $arguments Dynamic arguments for method
     */
    public function matches($point, $context = null, $instance = null, array $arguments = null): bool
    {
        return $this->matchPart($this->first, $point, $context, $instance, $arguments)
            || $this->matchPart($this->second, $point, $context, $instance, $arguments);
    }

    /**
     * @inheritDoc
     */
    protected function matchPart(Pointcut $pointcut, $point, $context = null, $instance = null, array $arguments = null)
    {
        $pointcutKind = $pointcut->getKind();
        // We need to recheck filter kind one more time, because of OR syntax
        switch (true) {
            case ($point instanceof \ReflectionMethod && ($pointcutKind & PointFilter::KIND_METHOD)):
            case ($point instanceof \ReflectionProperty && ($pointcutKind & PointFilter::KIND_PROPERTY)):
            case ($point instanceof \ReflectionClass && ($pointcutKind & PointFilter::KIND_CLASS)):
                return parent::matchPart($pointcut, $point, $context, $instance, $arguments);

It seems like $point can also be of type object<ReflectionClass>; however, Go\Aop\Pointcut\AndPointcut::matchPart() does only seem to accept object<ReflectionMethod>|object<ReflectionProperty>, maybe add an additional type check?

            default:
                return false;
        }
    }
}