TraitProxy - Code Metrics - Inspection of "Apply PHP7 type hinting to the Proxy generator cla..." - goaop/framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#339)

by Alexander

created 2017-08-09 21:05 UTC

TraitProxy A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	135
Duplicated Lines	0 %

Coupling/Cohesion

Components	3
Dependencies	3

Test Coverage

Coverage

Importance

Changes

Metric	Value
wmc	14
lcom	3
cbo	3
dl	0
loc	135
ccs	0
cts	74
cp	0
rs	10
c	0
b	0
f	0

5 Methods

Rating	Name	Size	Complexity
A	injectJoinPoints()	4	1
B	getJoinPoint()	25	3
C	getJoinpointInvocationBody()	27	7
A	__toString()	22	1
A	getMethodAliasesCode()	9	2

<?php
declare(strict_types = 1);
/*
 * Go! AOP framework
 *
 * @copyright Copyright 2012, Lisachenko Alexander <[email protected]>
 *
 * This source file is subject to the license that is bundled
 * with this source code in the file LICENSE.
 */

namespace Go\Proxy;

use Go\Aop\Intercept\MethodInvocation;
use Go\Core\AspectContainer;
use Go\Core\AspectKernel;
use Go\Core\LazyAdvisorAccessor;
use ReflectionMethod;

/**
 * Trait proxy builder that is used to generate a trait from the list of joinpoints
 */
class TraitProxy extends ClassProxy
{

    /**
     * List of advices for traits
     *
     * @var array
     */
    protected static $traitAdvices = [];

    /**
     * Inject advices for given trait
     *
     * NB This method will be used as a callback during source code evaluation to inject joinpoints
     *
     * @param string $className Aop child proxy class
     * @param array|\Go\Aop\Advice[] $traitAdvices List of advices to inject into class
     */
    public static function injectJoinPoints(string $className, array $traitAdvices = [])
    {
        self::$traitAdvices[$className] = $traitAdvices;
    }

    /**
     * Returns a joinpoint for the specific trait
     *
     * @param string $traitName Name of the trait
     * @param string $className Name of the class
     * @param string $joinPointType Type of joinpoint (static or dynamic method)
     * @param string $methodName Name of the method
     *
     * @return MethodInvocation
     */
    public static function getJoinPoint(
        string $traitName,
        string $className,
        string $joinPointType,
        string $methodName
    ): MethodInvocation {
        /** @var LazyAdvisorAccessor $accessor */
        static $accessor = null;

        if (!isset($accessor)) {
            $aspectKernel = AspectKernel::getInstance();
            $accessor     = $aspectKernel->getContainer()->get('aspect.advisor.accessor');
        }

        $advices = self::$traitAdvices[$traitName][$joinPointType][$methodName];

        $filledAdvices = [];
        foreach ($advices as $advisorName) {
            $filledAdvices[] = $accessor->$advisorName;
        }

        $joinpoint = new self::$invocationClassMap[$joinPointType]($className, $methodName . '➩', $filledAdvices);

        return $joinpoint;
    }

    /**
     * Creates definition for trait method body
     *
     * @param ReflectionMethod $method Method reflection
     *
     * @return string new method body
     */
    protected function getJoinpointInvocationBody(ReflectionMethod $method): string
    {
        $isStatic = $method->isStatic();
        $class    = '\\' . __CLASS__;
        $scope    = $isStatic ? self::$staticLsbExpression : '$this';
        $prefix   = $isStatic ? AspectContainer::STATIC_METHOD_PREFIX : AspectContainer::METHOD_PREFIX;

        $args = $this->prepareArgsLine($method);
        $args = $scope . ($args ? ", $args" : '');

        $return = 'return ';
        if (PHP_VERSION_ID >= 70100 && $method->hasReturnType()) {
abstract class User
{
    /** @return string */
    abstract public function getPassword();
}

class MyUser extends User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}
            $returnType = (string) $method->getReturnType();
            if ($returnType === 'void') {
                // void return types should not return anything
                $return = '';
            }
        }

        return <<<BODY
static \$__joinPoint = null;
if (!\$__joinPoint) {
    \$__joinPoint = {$class}::getJoinPoint(__TRAIT__, __CLASS__, '{$prefix}', '{$method->name}');
}
{$return}\$__joinPoint->__invoke($args);
BODY;
    }

    /**
     * {@inheritDoc}
     */
    public function __toString()
    {
        $classCode = (
            $this->class->getDocComment() . "\n" . // Original doc-block
            'trait ' . // 'trait' keyword
            $this->name . "\n" . // Name of the trait
            "{\n" . // Start of trait body
            $this->indent(
                'use ' . join(', ', [-1 => $this->parentClassName] + $this->traits) .
                $this->getMethodAliasesCode()
            ) . "\n" . // Use traits and aliases section
            $this->indent(join("\n", $this->methodsCode)) . "\n" . // Method definitions
            "}" // End of trait body
        );

        return $classCode
            // Inject advices on call
            . PHP_EOL
            . '\\' . __CLASS__ . "::injectJoinPoints('"
                . $this->class->name . "',"
                . var_export($this->advices, true) . ");";
    }

    /**
     * Returns prepared aliased code for usage in trait section
     *
     * @return string
     */
    private function getMethodAliasesCode(): string
    {
        $aliasesLines = [];
        foreach (array_keys($this->methodsCode) as $methodName) {
            $aliasesLines[] = "{$this->parentClassName}::{$methodName} as protected {$methodName}➩;";
        }

        return "{\n " . $this->indent(join("\n", $aliasesLines)) . "\n}";
    }
}


1			<?php
2			declare(strict_types = 1);
3			/*
4			* Go! AOP framework
5			*
6			* @copyright Copyright 2012, Lisachenko Alexander <[email protected]>
7			*
8			* This source file is subject to the license that is bundled
9			* with this source code in the file LICENSE.
10			*/
11
12			namespace Go\Proxy;
13
14			use Go\Aop\Intercept\MethodInvocation;
15			use Go\Core\AspectContainer;
16			use Go\Core\AspectKernel;
17			use Go\Core\LazyAdvisorAccessor;
18			use ReflectionMethod;
19
20			/**
21			* Trait proxy builder that is used to generate a trait from the list of joinpoints
22			*/
23			class TraitProxy extends ClassProxy
24			{
25
26			/**
27			* List of advices for traits
28			*
29			* @var array
30			*/
31			protected static $traitAdvices = [];
32
33			/**
34			* Inject advices for given trait
35			*
36			* NB This method will be used as a callback during source code evaluation to inject joinpoints
37			*
38			* @param string $className Aop child proxy class
39			* @param array\|\Go\Aop\Advice[] $traitAdvices List of advices to inject into class
40			*/
41			public static function injectJoinPoints(string $className, array $traitAdvices = [])
42			{
43			self::$traitAdvices[$className] = $traitAdvices;
44			}
45
46			/**
47			* Returns a joinpoint for the specific trait
48			*
49			* @param string $traitName Name of the trait
50			* @param string $className Name of the class
51			* @param string $joinPointType Type of joinpoint (static or dynamic method)
52			* @param string $methodName Name of the method
53			*
54			* @return MethodInvocation
55			*/
56			public static function getJoinPoint(
57			string $traitName,
58			string $className,
59			string $joinPointType,
60			string $methodName
61			): MethodInvocation {
62			/** @var LazyAdvisorAccessor $accessor */
63			static $accessor = null;
64
65			if (!isset($accessor)) {
66			$aspectKernel = AspectKernel::getInstance();
67			$accessor = $aspectKernel->getContainer()->get('aspect.advisor.accessor');
68			}
69
70			$advices = self::$traitAdvices[$traitName][$joinPointType][$methodName];
71
72			$filledAdvices = [];
73			foreach ($advices as $advisorName) {
74			$filledAdvices[] = $accessor->$advisorName;
75			}
76
77			$joinpoint = new self::$invocationClassMap[$joinPointType]($className, $methodName . '➩', $filledAdvices);
78
79			return $joinpoint;
80			}
81
82			/**
83			* Creates definition for trait method body
84			*
85			* @param ReflectionMethod $method Method reflection
86			*
87			* @return string new method body
88			*/
89			protected function getJoinpointInvocationBody(ReflectionMethod $method): string
90			{
91			$isStatic = $method->isStatic();
92			$class = '\\' . __CLASS__;
93			$scope = $isStatic ? self::$staticLsbExpression : '$this';
94			$prefix = $isStatic ? AspectContainer::STATIC_METHOD_PREFIX : AspectContainer::METHOD_PREFIX;
95
96			$args = $this->prepareArgsLine($method);
97			$args = $scope . ($args ? ", $args" : '');
98
99			$return = 'return ';
100			if (PHP_VERSION_ID >= 70100 && $method->hasReturnType()) {
			1 ignored issue – show Bug introduced 2017-01-05 19:59 UTC by Report Bug Copy Issue Report It seems like you code against a specific sub-type and not the parent class `ReflectionMethod` as the method `hasReturnType()` does only exist in the following sub-classes of `ReflectionMethod`: `Go\ParserReflection\ReflectionMethod`. Maybe you want to `instanceof` check for one of these explicitly? Let’s take a look at an example: abstract class User { /** @return string / abstract public function getPassword(); } class MyUser extends User { public function getPassword() { // return something } public function getDisplayName() { // return some name. } } class AuthSystem { public function authenticate(User $user) { $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName())); // do something. } } In the above example, the authenticate() method works fine as long as you just pass instances of MyUser. However, if you now also want to pass a different sub-classes of User which does not have a getDisplayName() method, the code will break. Available Fixes Change the type-hint for the parameter: class AuthSystem { public function authenticate(MyUser $user) { / ... / } } Add an additional type-check: class AuthSystem { public function authenticate(User $user) { if ($user instanceof MyUser) { $this->logger->info(/* ... /); } // or alternatively if ( ! $user instanceof MyUser) { throw new \LogicException( '$user must be an instance of MyUser, ' .'other instances are not supported.' ); } } } Note:* PHP Analyzer uses reverse abstract interpretation to narrow down the types inside the if block in such a case. Add the method to the parent class: abstract class User { /** @return string / abstract public function getPassword(); /* @return string */ abstract public function getDisplayName(); } Loading history...
101			$returnType = (string) $method->getReturnType();
102			if ($returnType === 'void') {
103			// void return types should not return anything
104			$return = '';
105			}
106			}
107
108			return <<<BODY
109			static \$__joinPoint = null;
110			if (!\$__joinPoint) {
111			\$__joinPoint = {$class}::getJoinPoint(__TRAIT__, __CLASS__, '{$prefix}', '{$method->name}');
112			}
113			{$return}\$__joinPoint->__invoke($args);
114			BODY;
115			}
116
117			/**
118			* {@inheritDoc}
119			*/
120			public function __toString()
121			{
122			$classCode = (
123			$this->class->getDocComment() . "\n" . // Original doc-block
124			'trait ' . // 'trait' keyword
125			$this->name . "\n" . // Name of the trait
126			"{\n" . // Start of trait body
127			$this->indent(
128			'use ' . join(', ', [-1 => $this->parentClassName] + $this->traits) .
129			$this->getMethodAliasesCode()
130			) . "\n" . // Use traits and aliases section
131			$this->indent(join("\n", $this->methodsCode)) . "\n" . // Method definitions
132			"}" // End of trait body
133			);
134
135			return $classCode
136			// Inject advices on call
137			. PHP_EOL
138			. '\\' . __CLASS__ . "::injectJoinPoints('"
139			. $this->class->name . "',"
140			. var_export($this->advices, true) . ");";
141			}
142
143			/**
144			* Returns prepared aliased code for usage in trait section
145			*
146			* @return string
147			*/
148			private function getMethodAliasesCode(): string
149			{
150			$aliasesLines = [];
151			foreach (array_keys($this->methodsCode) as $methodName) {
152			$aliasesLines[] = "{$this->parentClassName}::{$methodName} as protected {$methodName}➩;";
153			}
154
155			return "{\n " . $this->indent(join("\n", $aliasesLines)) . "\n}";
156			}
157			}
158

goaop / framework

Pull Request — master (#339)

TraitProxy A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

5 Methods

Available Fixes

Duplication Side-by-Side

Filter issues like