Gnumoksha\FreeIpa\FreeIpa

Complexity

Total Complexity

7

Size/Duplication

Total Lines	56
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	sendRequest()	0	3	1
A	__construct()	0	9	1
A	getGroupRepository()	0	7	2
A	login()	0	3	1
A	getUserRepository()	0	7	2

<?php

/**
 * FreeIPA library for PHP
 * Copyright (C) 2015-2019 Tobias Sette <me@tobias.ws>
 *
 * This program is free software: you can redistribute it and/or modify
 * it under the terms of the GNU Lesser General Public License as published by
 * the Free Software Foundation, either version 3 of the License, or
 * (at your option) any later version.
 *
 * This program is distributed in the hope that it will be useful,
 * but WITHOUT ANY WARRANTY; without even the implied warranty of
 * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 * GNU Lesser General Public License for more details.
 *
 * You should have received a copy of the GNU Lesser General Public License
 * along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */

declare(strict_types=1);

namespace Gnumoksha\FreeIpa;

use Gnumoksha\FreeIpa\Infra\Json\JsonException;
use Gnumoksha\FreeIpa\Infra\Rpc\ClientBuilder;
use Gnumoksha\FreeIpa\Infra\Rpc\PluginClientBuilder;
use Gnumoksha\FreeIpa\Infra\Rpc\Request\Body as RequestBodyInterface;
use Gnumoksha\FreeIpa\Infra\Rpc\Request\CommonBody as CommonRequestBody;
use Gnumoksha\FreeIpa\Infra\Rpc\Response\Body as ResponseBodyInterface;
use Gnumoksha\FreeIpa\Model\User\UserRepository;
use Gnumoksha\FreeIpa\Model\Group\GroupRepository;
use Psr\Http\Client\ClientExceptionInterface;

/**
 * Façade providing easy bootstrapping and convenient methods.
 */
class FreeIpa
{
    private Infra\Rpc\Client $client;

    private CommonRequestBody|RequestBodyInterface $requestBody;

    private ?UserRepository $userRepository = null;

    private ?GroupRepository $groupRepository = null;

    public function __construct(
        Options $options,
        ClientBuilder $clientBuilder = null,
        RequestBodyInterface $requestBody = null
    ) {
        $clientBuilder = $clientBuilder ?? new PluginClientBuilder($options);

        $this->client      = $clientBuilder->build();
        $this->requestBody = $requestBody ?? new CommonRequestBody();
    }

    /**
     * @throws ClientExceptionInterface
     */
    public function login(string $username, string $password): void
    {
        $this->client->login($username, $password);
    }

    public function getUserRepository(): UserRepository
    {
        if ($this->userRepository === null) {
            $this->userRepository = new UserRepository($this->client, $this->requestBody);
        }

        return $this->userRepository;

The expression return $this->userRepository could return the type null which is incompatible with the type-hinted return Gnumoksha\FreeIpa\Model\User\UserRepository. Consider adding an additional type-check to rule them out.

    }

    public function getGroupRepository(): GroupRepository
    {
        if ($this->groupRepository === null) {
            $this->groupRepository = new GroupRepository($this->client, $this->requestBody);
        }

        return $this->groupRepository;

The expression return $this->groupRepository could return the type null which is incompatible with the type-hinted return Gnumoksha\FreeIpa\Model\Group\GroupRepository. Consider adding an additional type-check to rule them out.

    }

    /**
     * Sends a raw request.
     *
     * @throws JsonException
     * @throws ClientExceptionInterface
     */
    public function sendRequest(RequestBodyInterface $body): ResponseBodyInterface
    {
        return $this->client->sendRequest($body);
    }
}