SystemPropertyPayload - Code Metrics - Inspection of "update readme" - gnello/php-openfire-restapi - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( fa98ea...c23364 )

by Luca

created 2016-10-04 22:13 UTC

SystemPropertyPayload A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	51
Duplicated Lines	13.73 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	1
dl	7
loc	51
rs	10
c	0
b	0
f	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	setProperty()	7	7	2
A	getProperty()	0	3	1

How to fix Duplicated Code

<?php
/**
 * OpenFireRestAPI is based entirely on official documentation of the REST API
 * Plugin and you can extend it by following the directives of the documentation
 *
 * For the full copyright and license information, please read the LICENSE
 * file that was distributed with this source code. For the full list of
 * contributors, visit https://github.com/gnello/PHPOpenFireRestAPI/contributors
 *
 * @author Luca Agnello <[email protected]>
 * @link https://www.igniterealtime.org/projects/openfire/plugins/restapi/readme.html
 */

namespace Gnello\OpenFireRestAPI\Payloads;

/**
 * Payload of SystemProperty related REST Endpoint
 * Class SystemPropertyPayload
 * @package Gnello\OpenFireRestAPI\Payloads
 * @link http://www.igniterealtime.org/projects/openfire/plugins/restapi/readme.html#system-property
 */
class SystemPropertyPayload extends AbstractPayload
{
    /**
     * The name of the system property
     * Optional No
     * @var string
     */
    //private $key;

    /**
     * The value of the system property
     * Optional Yes
     * @var string
     */
    //private $value;

    /**
     * The value of the system property
     * Optional Yes
     * @var string
     */
    private $property;

    /**
     * SystemPropertyPayload constructor.
     * @param $property
     */
    public function __construct($property)
    {
        $prop['property'][$property['propertyName']] = $property['propertyValue'];
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
        parent::__construct($prop);
    }

    /**
     * @param array $properties
     */
    public function setProperty(array $properties) {

        foreach ($properties as $key => $value) {
            $property['@key'] = $key;
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
            $property['@value'] = $value;
            $this->property = $property;

        }
    }

    /**
     * @return array
     */
    public function getProperty() {
        return $this->property;
    }
}

1		<?php
2		/**
3		* OpenFireRestAPI is based entirely on official documentation of the REST API
4		* Plugin and you can extend it by following the directives of the documentation
5		*
6		* For the full copyright and license information, please read the LICENSE
7		* file that was distributed with this source code. For the full list of
8		* contributors, visit https://github.com/gnello/PHPOpenFireRestAPI/contributors
9		*
10		* @author Luca Agnello <[email protected]>
11		* @link https://www.igniterealtime.org/projects/openfire/plugins/restapi/readme.html
12		*/
13
14		namespace Gnello\OpenFireRestAPI\Payloads;
15
16		/**
17		* Payload of SystemProperty related REST Endpoint
18		* Class SystemPropertyPayload
19		* @package Gnello\OpenFireRestAPI\Payloads
20		* @link http://www.igniterealtime.org/projects/openfire/plugins/restapi/readme.html#system-property
21		*/
22		class SystemPropertyPayload extends AbstractPayload
23		{
24		/**
25		* The name of the system property
26		* Optional No
27		* @var string
28		*/
29		//private $key;
30
31		/**
32		* The value of the system property
33		* Optional Yes
34		* @var string
35		*/
36		//private $value;
37
38		/**
39		* The value of the system property
40		* Optional Yes
41		* @var string
42		*/
43		private $property;
44
45		/**
46		* SystemPropertyPayload constructor.
47		* @param $property
48		*/
49		public function __construct($property)
50		{
51		$prop['property'][$property['propertyName']] = $property['propertyValue'];
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-04 22:15 UTC by Report Bug Copy Issue Report `$prop` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$prop = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
52		parent::__construct($prop);
53		}
54
55		/**
56		* @param array $properties
57		*/
58	View Code Duplication	public function setProperty(array $properties) {
		0 ignored issues – show Duplication introduced 2016-10-04 22:15 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
59		foreach ($properties as $key => $value) {
60		$property['@key'] = $key;
		0 ignored issues – show Coding Style Comprehensibility introduced 2016-10-04 22:15 UTC by Report Bug Copy Issue Report `$property` was never initialized. Although not strictly required by PHP, it is generally a good practice to add `$property = array();` before regardless. Adding an explicit array definition is generally preferable to implicit array definition as it guarantees a stable state of the code. Let’s take a look at an example: foreach ($collection as $item) { $myArray['foo'] = $item->getFoo(); if ($item->hasBar()) { $myArray['bar'] = $item->getBar(); } // do something with $myArray } As you can see in this example, the array `$myArray` is initialized the first time when the foreach loop is entered. You can also see that the value of the `bar` key is only written conditionally; thus, its value might result from a previous iteration. This might or might not be intended. To make your intention clear, your code more readible and to avoid accidental bugs, we recommend to add an explicit initialization `$myArray = array()` either outside or inside the foreach loop. Loading history...
61		$property['@value'] = $value;
62		$this->property = $property;
		0 ignored issues – show Documentation Bug introduced 2016-10-04 22:15 UTC by Report Bug Copy Issue Report It seems like `$property` of type `array<string,?,{"@value":"?"}>` is incompatible with the declared type `string` of property `$property`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
63		}
64		}
65
66		/**
67		* @return array
68		*/
69		public function getProperty() {
70		return $this->property;
71		}
72		}

gnello / php-openfire-restapi

Push — master ( fa98ea...c23364 )

SystemPropertyPayload A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

3 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like