glorand / laravel-model-settings

src/Managers/TableSettingsManager.php

<?php

namespace Glorand\Model\Settings\Managers;

use Glorand\Model\Settings\Contracts\SettingsManagerContract;
use Glorand\Model\Settings\Models\ModelSettings;

/**
 * Class TableSettingsManager
 * @package Glorand\Model\Settings\Managers
 * @property  \Illuminate\Database\Eloquent\Model|\Glorand\Model\Settings\Traits\HasSettingsTable $model
 */
class TableSettingsManager extends AbstractSettingsManager
{
    /**
     * @param  array  $settings
     * @return \Glorand\Model\Settings\Contracts\SettingsManagerContract
     * @throws \Exception
     * @SuppressWarnings(PHPMD.ElseExpression)
     */
    public function apply(array $settings = []): SettingsManagerContract
    {
        $this->validate($settings);

        $modelSettings = $this->model->modelSettings()->first();
        if (!count($settings)) {
            if ($modelSettings) {
                $modelSettings->delete();
            }
        } else {
            if (!$modelSettings) {
                $modelSettings = new ModelSettings();
                $modelSettings->setConnection($this->model->getConnectionName());

The method getConnectionName() does not exist on Glorand\Model\Settings\Traits\HasSettingsTable. Since you implemented __call, consider adding a @method annotation.

It seems like $this->model->getConnectionName() can also be of type Glorand\Model\Settings\Contracts\SettingsManagerContract; however, parameter $name of Illuminate\Database\Eloquent\Model::setConnection() does only seem to accept null|string, maybe add an additional type check?

                $modelSettings->model()->associate($this->model);
            }
            $modelSettings->settings = $settings;
            $modelSettings->save();
        }

        cache()->forget($this->model->getSettingsCacheKey());

It seems like $this->model->getSettingsCacheKey() can also be of type Illuminate\Database\Eloquent\Builder; however, parameter $key of Illuminate\Cache\Repository::forget() does only seem to accept string, maybe add an additional type check?

        return $this;
    }
}