Glorand\Model\Settings\Traits\HasSettingsField

Complexity

Total Complexity

4

Size/Duplication

Total Lines	20
Duplicated Lines	0 %

Test Coverage

Coverage

0%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getSettingsAttribute()	0	3	1
A	setSettingsAttribute()	0	3	1
A	settings()	0	3	2

<?php

namespace Glorand\Model\Settings\Traits;

use Glorand\Model\Settings\Contracts\SettingsManagerContract;
use Glorand\Model\Settings\Managers\FieldSettingsManager;

/**
 * Trait HasSettingsField
 * @package Glorand\Model\Settings\Traits
 * @property array $settings
 */
trait HasSettingsField
{
    /**
     * @param string $path
     * @param null $default

Are you sure the doc-type for parameter $default is correct as it would always require null to be passed?

     * @return \Glorand\Model\Settings\Contracts\SettingsManagerContract
     */
    public function settings(string $path = null, $default = null): SettingsManagerContract
    {
        return $path ? $this->settings()->get($path, $default) : new FieldSettingsManager($this);
    }

    protected function getSettingsAttribute()
    {
        return json_decode($this->getAttributes()['settings'], true);

It seems like getAttributes() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function setSettingsAttribute($settings)
    {
        $this->attributes['settings'] = json_encode($settings);

The property attributes does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
}