Api::makeRequest() - Code Metrics - Inspection of "Accounts support" - glorand/drip - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#3)

by Gombos

created 2018-12-04 14:44 UTC

Api::makeRequest() B

↳ Parent: Api

Complexity

Conditions	7
Paths	16

Size

Total Lines	28
Code Lines	18

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	7
eloc	18
nc	16
nop	3
dl	0
loc	28
rs	8.8333
c	0
b	0
f	0

<?php

namespace Glorand\Drip\Api;

use Glorand\Drip\Api\Response\ApiResponse;
use GuzzleHttp\Client;
use GuzzleHttp\Exception\GuzzleException;
use GuzzleHttp\Psr7\Response;

abstract class Api
{
    const GET = 'get';
    const POST = 'post';
    const PUT = 'put';
    const DELETE = 'delete';

    /**
     * @var Client
     */
    protected $client;

    /**
     * Api constructor.
     *
     * @param Client $client
     */
    public function __construct(Client $client)
    {
        $this->client = $client;
    }

    protected function prepareUrl(string $url): string
    {
        return 'v2/'.$url;
    }

    /**
     * @param       $method
     * @param       $url
     * @param array $params
     *
     * @return ApiResponse
     */
    public function makeRequest($method, $url, $params = [])
    {
        $options = [];
        switch ($method) {
            case self::GET:
                $options['query'] = $params;
                break;
            case self::POST:
            case self::DELETE:
                // @codeCoverageIgnoreStart
            case self::PUT:
                // @codeCoverageIgnoreEnd
                $options['body'] = is_array($params) ? json_encode($params) : $params;

                break;
            default:
                // @codeCoverageIgnoreStart
                $method = 'GET';
                break;
            // @codeCoverageIgnoreEnd
        }

        try {
            $response = $this->client->request($method, $url, $options);
        } catch (GuzzleException $e) {
            $response = new Response($e->getCode(), [], $e->getMessage());
        }

        return new ApiResponse($url, $options, $response);
    }
}


1			<?php
2
3			namespace Glorand\Drip\Api;
4
5			use Glorand\Drip\Api\Response\ApiResponse;
6			use GuzzleHttp\Client;
7			use GuzzleHttp\Exception\GuzzleException;
8			use GuzzleHttp\Psr7\Response;
9
10			abstract class Api
11			{
12			const GET = 'get';
13			const POST = 'post';
14			const PUT = 'put';
15			const DELETE = 'delete';
16
17			/**
18			* @var Client
19			*/
20			protected $client;
21
22			/**
23			* Api constructor.
24			*
25			* @param Client $client
26			*/
27			public function __construct(Client $client)
28			{
29			$this->client = $client;
30			}
31
32			protected function prepareUrl(string $url): string
33			{
34			return 'v2/'.$url;
35			}
36
37			/**
38			* @param $method
39			* @param $url
40			* @param array $params
41			*
42			* @return ApiResponse
43			*/
44			public function makeRequest($method, $url, $params = [])
45			{
46			$options = [];
47			switch ($method) {
48			case self::GET:
49			$options['query'] = $params;
50			break;
51			case self::POST:
52			case self::DELETE:
53			// @codeCoverageIgnoreStart
54			case self::PUT:
55			// @codeCoverageIgnoreEnd
56			$options['body'] = is_array($params) ? json_encode($params) : $params;
			0 ignored issues – show introduced 2018-12-04 11:04 UTC by Report Bug Copy Issue Report The condition `is_array($params)` is always `true`. Loading history...
57			break;
58			default:
59			// @codeCoverageIgnoreStart
60			$method = 'GET';
61			break;
62			// @codeCoverageIgnoreEnd
63			}
64
65			try {
66			$response = $this->client->request($method, $url, $options);
67			} catch (GuzzleException $e) {
68			$response = new Response($e->getCode(), [], $e->getMessage());
69			}
70
71			return new ApiResponse($url, $options, $response);
72			}
73			}
74

glorand / drip

Pull Request — master (#3)

Api::makeRequest() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like