Issues in QueuedTaskRepository.php - New Issues - Inspection of "Made sure not to queue a job when already queued" - glooby/task-bundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 682c42...b25a4a )

by Emil

created 2017-03-16 19:06 UTC

src/Entity/QueuedTaskRepository.php (2 issues)

Labels

Duplication 2

Severity

Informational 2

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace Glooby\TaskBundle\Entity;

use Doctrine\ORM\EntityRepository;
use Doctrine\ORM\NoResultException;
use Glooby\TaskBundle\Model\QueuedTaskInterface;

/**
 * @author Emil Kilhage
 */
class QueuedTaskRepository extends EntityRepository
{
    /**
     * @param string $name
     * @param \DateTime $executeAt
     * @return QueuedTaskInterface
     */
    public function getByNameAndExecuteAt($name, \DateTime $executeAt)
    {
        return $this->getEntityManager()
            ->createQuery('SELECT r
              FROM GloobyTaskBundle:QueuedTask r
              WHERE r.name = :name AND r.executeAt = :executeAt')
            ->setParameter('name', $name)
            ->setParameter('executeAt', $executeAt)
            ->useQueryCache(true)
            ->getSingleResult();
    }

    /**
     * @param string $name
     * @return QueuedTaskInterface
     */
    public function getByNameAndExecuteAtBeforeNow($name)
    {
        return $this->getEntityManager()
            ->createQuery('SELECT r
              FROM GloobyTaskBundle:QueuedTask r
              WHERE r.name = :name AND r.executeAt <= :now')
            ->setParameter('name', $name)
            ->setParameter('now', new \DateTime())
            ->useQueryCache(true)
            ->setMaxResults(1)
            ->getSingleResult();
    }

    /**
     * @param int $limit
     * @return QueuedTaskInterface[]
     */
    public function findQueued($limit)
    {
        return $this->getEntityManager()
            ->createQuery('SELECT r
              FROM GloobyTaskBundle:QueuedTask r
              WHERE r.status = :status AND r.executeAt <= :now
              ORDER BY r.executeAt ASC')
            ->setParameter('status', QueuedTaskInterface::STATUS_QUEUED)
            ->setParameter('now', new \DateTime())
            ->setMaxResults($limit)
            ->useQueryCache(true)
            ->getResult();
    }

    /**
     * @param string $name
     * @return bool
     */
    public function isRunning($name)

    {
        try {
            $this->getEntityManager()
                ->createQuery('SELECT r
                  FROM GloobyTaskBundle:QueuedTask r
                  WHERE r.name = :name AND r.status = :status')
                ->setParameter('name', $name)
                ->setParameter('status', QueuedTaskInterface::STATUS_RUNNING)
                ->useQueryCache(true)
                ->setMaxResults(1)
                ->getSingleResult();

            return true;
        } catch (NoResultException $e) {
            return false;
        }
    }

    /**
     * @param string $name
     * @return bool
     */
    public function isQueued($name)

    {
        try {
            $this->getEntityManager()
                ->createQuery('SELECT r
                  FROM GloobyTaskBundle:QueuedTask r
                  WHERE r.name = :name AND r.status = :status')
                ->setParameter('name', $name)
                ->setParameter('status', QueuedTaskInterface::STATUS_QUEUED)
                ->useQueryCache(true)
                ->setMaxResults(1)
                ->getSingleResult();

            return true;
        } catch (NoResultException $e) {
            return false;
        }
    }
}


1		<?php
2
3		namespace Glooby\TaskBundle\Entity;
4
5		use Doctrine\ORM\EntityRepository;
6		use Doctrine\ORM\NoResultException;
7		use Glooby\TaskBundle\Model\QueuedTaskInterface;
8
9		/**
10		* @author Emil Kilhage
11		*/
12		class QueuedTaskRepository extends EntityRepository
13		{
14		/**
15		* @param string $name
16		* @param \DateTime $executeAt
17		* @return QueuedTaskInterface
18		*/
19		public function getByNameAndExecuteAt($name, \DateTime $executeAt)
20		{
21		return $this->getEntityManager()
22		->createQuery('SELECT r
23		FROM GloobyTaskBundle:QueuedTask r
24		WHERE r.name = :name AND r.executeAt = :executeAt')
25		->setParameter('name', $name)
26		->setParameter('executeAt', $executeAt)
27		->useQueryCache(true)
28		->getSingleResult();
29		}
30
31		/**
32		* @param string $name
33		* @return QueuedTaskInterface
34		*/
35		public function getByNameAndExecuteAtBeforeNow($name)
36		{
37		return $this->getEntityManager()
38		->createQuery('SELECT r
39		FROM GloobyTaskBundle:QueuedTask r
40		WHERE r.name = :name AND r.executeAt <= :now')
41		->setParameter('name', $name)
42		->setParameter('now', new \DateTime())
43		->useQueryCache(true)
44		->setMaxResults(1)
45		->getSingleResult();
46		}
47
48		/**
49		* @param int $limit
50		* @return QueuedTaskInterface[]
51		*/
52		public function findQueued($limit)
53		{
54		return $this->getEntityManager()
55		->createQuery('SELECT r
56		FROM GloobyTaskBundle:QueuedTask r
57		WHERE r.status = :status AND r.executeAt <= :now
58		ORDER BY r.executeAt ASC')
59		->setParameter('status', QueuedTaskInterface::STATUS_QUEUED)
60		->setParameter('now', new \DateTime())
61		->setMaxResults($limit)
62		->useQueryCache(true)
63		->getResult();
64		}
65
66		/**
67		* @param string $name
68		* @return bool
69		*/
70	View Code Duplication	public function isRunning($name)
		0 ignored issues – show Duplication introduced 2017-03-16 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		{
72		try {
73		$this->getEntityManager()
74		->createQuery('SELECT r
75		FROM GloobyTaskBundle:QueuedTask r
76		WHERE r.name = :name AND r.status = :status')
77		->setParameter('name', $name)
78		->setParameter('status', QueuedTaskInterface::STATUS_RUNNING)
79		->useQueryCache(true)
80		->setMaxResults(1)
81		->getSingleResult();
82
83		return true;
84		} catch (NoResultException $e) {
85		return false;
86		}
87		}
88
89		/**
90		* @param string $name
91		* @return bool
92		*/
93	View Code Duplication	public function isQueued($name)
		0 ignored issues – show Duplication introduced 2017-03-16 19:08 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
94		{
95		try {
96		$this->getEntityManager()
97		->createQuery('SELECT r
98		FROM GloobyTaskBundle:QueuedTask r
99		WHERE r.name = :name AND r.status = :status')
100		->setParameter('name', $name)
101		->setParameter('status', QueuedTaskInterface::STATUS_QUEUED)
102		->useQueryCache(true)
103		->setMaxResults(1)
104		->getSingleResult();
105
106		return true;
107		} catch (NoResultException $e) {
108		return false;
109		}
110		}
111		}
112

glooby / task-bundle

Push — master ( 682c42...b25a4a )

src/Entity/QueuedTaskRepository.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like