Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
10 | class JsonParserTest extends PHPUnit_Framework_TestCase |
||
11 | { |
||
12 | /** |
||
13 | * Test valid json input. |
||
14 | * |
||
15 | * @author Glenn McEwan <[email protected]> |
||
16 | */ |
||
17 | public function testValidJsonFromFile() |
||
36 | |||
37 | /** |
||
38 | * Test invalid json due to single quotes enclosing strings. |
||
39 | * |
||
40 | * @author Glenn McEwan <[email protected]> |
||
41 | */ |
||
42 | View Code Duplication | public function testInvalidJsonSingleQuotes() |
|
52 | |||
53 | /** |
||
54 | * Test invalid json due to trailing commas. |
||
55 | * |
||
56 | * @author Glenn McEwan <[email protected]> |
||
57 | */ |
||
58 | View Code Duplication | public function testInvalidJsonTrailingComma() |
|
68 | } |
||
69 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.