Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
1 | <?php |
||
18 | class Locker |
||
19 | { |
||
20 | /** |
||
21 | * @var string |
||
22 | */ |
||
23 | private $file; |
||
24 | |||
25 | /** |
||
26 | * @var resource |
||
27 | */ |
||
28 | private $handle; |
||
29 | |||
30 | /** |
||
31 | * @param string $context The unique lock name |
||
32 | */ |
||
33 | public function __construct($context) |
||
42 | |||
43 | /** |
||
44 | * Lock the resource |
||
45 | * |
||
46 | * @return bool Returns true if the lock was acquired, false otherwise |
||
47 | * @throws \RuntimeException If the lock file could not be created or opened |
||
48 | */ |
||
49 | public function lock() |
||
85 | |||
86 | /** |
||
87 | * Release the resource |
||
88 | */ |
||
89 | public function release() |
||
97 | } |
||
98 |
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.